[GitHub] [incubator-druid] satybald commented on issue #8078: Upgrade Kafka library for kafka-lookup module

2019-07-16 Thread GitBox
satybald commented on issue #8078: Upgrade Kafka library for kafka-lookup module URL: https://github.com/apache/incubator-druid/pull/8078#issuecomment-511715093 thanks @jihoonson for review. I've updated the licenses doc. This

[GitHub] [incubator-druid] sanastas commented on issue #5698: Oak: New Concurrent Key-Value Map

2019-07-16 Thread GitBox
sanastas commented on issue #5698: Oak: New Concurrent Key-Value Map URL: https://github.com/apache/incubator-druid/issues/5698#issuecomment-511734712 @gianm , @jon-wei , @jihoonson and everyone! Oak has a great ability to scan forward ***and backward*** with the same speed! As Jav

[GitHub] [incubator-druid] clintropolis opened a new pull request #8089: add CachingClusteredClient benchmark, refactor some stuff

2019-07-16 Thread GitBox
clintropolis opened a new pull request #8089: add CachingClusteredClient benchmark, refactor some stuff URL: https://github.com/apache/incubator-druid/pull/8089 ### Description This PR adds a benchmark for `CachingClusteredClient` and some refactoring of the query processing pipelin

[GitHub] [incubator-druid] JackyYangPassion commented on issue #7594: [for master] general exactly count distinct support in Druid

2019-07-16 Thread GitBox
JackyYangPassion commented on issue #7594: [for master] general exactly count distinct support in Druid URL: https://github.com/apache/incubator-druid/pull/7594#issuecomment-511795351 when i use quickstart example wikiticker-2015-09-12-sampled.json with unique user: record: `{"time"

[GitHub] [incubator-druid] JackyYangPassion edited a comment on issue #7594: [for master] general exactly count distinct support in Druid

2019-07-16 Thread GitBox
JackyYangPassion edited a comment on issue #7594: [for master] general exactly count distinct support in Druid URL: https://github.com/apache/incubator-druid/pull/7594#issuecomment-511795351 when i use quickstart example wikiticker-2015-09-12-sampled.json with unique user: ### record:

[GitHub] [incubator-druid] JackyYangPassion commented on issue #7594: [for master] general exactly count distinct support in Druid

2019-07-16 Thread GitBox
JackyYangPassion commented on issue #7594: [for master] general exactly count distinct support in Druid URL: https://github.com/apache/incubator-druid/pull/7594#issuecomment-511800536 from the error message ,i think there is must be an error in built dictionary stage ! so when in the inge

[GitHub] [incubator-druid] JackyYangPassion edited a comment on issue #7594: [for master] general exactly count distinct support in Druid

2019-07-16 Thread GitBox
JackyYangPassion edited a comment on issue #7594: [for master] general exactly count distinct support in Druid URL: https://github.com/apache/incubator-druid/pull/7594#issuecomment-511800536 From the error message ,i think there is must be an error in built dictionary stage ! so when in t

[GitHub] [incubator-druid] leventov commented on issue #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource

2019-07-16 Thread GitBox
leventov commented on issue #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource URL: https://github.com/apache/incubator-druid/pull/7653#issuecomment-511808804 @egor-ryashin could you please check this PR again?

[GitHub] [incubator-druid] leventov commented on a change in pull request #8060: 6855 add Checkstyle for constant name static final

2019-07-16 Thread GitBox
leventov commented on a change in pull request #8060: 6855 add Checkstyle for constant name static final URL: https://github.com/apache/incubator-druid/pull/8060#discussion_r303900541 ## File path: extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafk

[GitHub] [incubator-druid] leventov commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues`

2019-07-16 Thread GitBox
leventov commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues` URL: https://github.com/apache/incubator-druid/pull/8059#discussion_r303901726 ## File path: core/src/main/java/org/apache/druid/utils/CollectionUtils.java ## @@ -88,12 +89

[incubator-druid] branch leventov-patch-1 deleted (was e8ef50b)

2019-07-16 Thread leventov
This is an automated email from the ASF dual-hosted git repository. leventov pushed a change to branch leventov-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. was e8ef50b Add instruction about skipping up-to-date checks when running integration tests The r

[GitHub] [incubator-druid] leventov commented on issue #7991: Add development principles

2019-07-16 Thread GitBox
leventov commented on issue #7991: Add development principles URL: https://github.com/apache/incubator-druid/pull/7991#issuecomment-511830784 @gianm I don't see how to make the document significantly shorter without cutting important (in my opinion) content. The document already skips almos

[GitHub] [incubator-druid] leventov edited a comment on issue #7991: Add development principles

2019-07-16 Thread GitBox
leventov edited a comment on issue #7991: Add development principles URL: https://github.com/apache/incubator-druid/pull/7991#issuecomment-511830784 @gianm I don't see how to make the document significantly shorter without cutting important (in my opinion) content. The document already skip

[GitHub] [incubator-druid] leventov commented on a change in pull request #8086: add checkstyle to forbid unecessary use of Class.getCanonicalName

2019-07-16 Thread GitBox
leventov commented on a change in pull request #8086: add checkstyle to forbid unecessary use of Class.getCanonicalName URL: https://github.com/apache/incubator-druid/pull/8086#discussion_r303959138 ## File path: codestyle/checkstyle.xml ## @@ -319,5 +319,11 @@ codestyle/c

[GitHub] [incubator-druid] leventov commented on issue #7842: The instruction for running integration tests from integration-tests/README.md doesn't work

2019-07-16 Thread GitBox
leventov commented on issue #7842: The instruction for running integration tests from integration-tests/README.md doesn't work URL: https://github.com/apache/incubator-druid/issues/7842#issuecomment-511874813 @jon-wei thank you, yes, the cert generation step failed because of the followin

[GitHub] [incubator-druid] fjy merged pull request #8007: Web console: update dependencies

2019-07-16 Thread GitBox
fjy merged pull request #8007: Web console: update dependencies URL: https://github.com/apache/incubator-druid/pull/8007 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-druid] fjy closed issue #8074: Unified console broken: resizeSensor.js unexpected token { on line 88

2019-07-16 Thread GitBox
fjy closed issue #8074: Unified console broken: resizeSensor.js unexpected token { on line 88 URL: https://github.com/apache/incubator-druid/issues/8074 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues`

2019-07-16 Thread GitBox
surekhasaharan commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues` URL: https://github.com/apache/incubator-druid/pull/8059#discussion_r304007145 ## File path: core/src/main/java/org/apache/druid/utils/CollectionUtils.java ## @@ -88,

[GitHub] [incubator-druid] leventov commented on issue #8084: Add more excempt tags for stalebot; Make stalebot to close PRs/issues in 21 days rather than in 7/14 days

2019-07-16 Thread GitBox
leventov commented on issue #8084: Add more excempt tags for stalebot; Make stalebot to close PRs/issues in 21 days rather than in 7/14 days URL: https://github.com/apache/incubator-druid/pull/8084#issuecomment-511896406 I overlooked the PR/issue distinction. Indeed, I also don't see the po

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8086: add checkstyle to forbid unecessary use of Class.getCanonicalName

2019-07-16 Thread GitBox
clintropolis commented on a change in pull request #8086: add checkstyle to forbid unecessary use of Class.getCanonicalName URL: https://github.com/apache/incubator-druid/pull/8086#discussion_r304040441 ## File path: codestyle/checkstyle.xml ## @@ -319,5 +319,11 @@ codesty

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8086: add Class.getCanonicalName to forbidden-api

2019-07-16 Thread GitBox
himanshug commented on a change in pull request #8086: add Class.getCanonicalName to forbidden-api URL: https://github.com/apache/incubator-druid/pull/8086#discussion_r304047609 ## File path: codestyle/druid-forbidden-apis.txt ## @@ -34,6 +34,7 @@ java.util.Random#() @ Use

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8086: add Class.getCanonicalName to forbidden-api

2019-07-16 Thread GitBox
himanshug commented on a change in pull request #8086: add Class.getCanonicalName to forbidden-api URL: https://github.com/apache/incubator-druid/pull/8086#discussion_r304047609 ## File path: codestyle/druid-forbidden-apis.txt ## @@ -34,6 +34,7 @@ java.util.Random#() @ Use

[GitHub] [incubator-druid] capistrant commented on issue #7562: Enable ability to toggle SegmentMetadata request logging on/off

2019-07-16 Thread GitBox
capistrant commented on issue #7562: Enable ability to toggle SegmentMetadata request logging on/off URL: https://github.com/apache/incubator-druid/pull/7562#issuecomment-511932914 Thanks all for the tips and info! I'll be cleaning this up this week following all the feedback

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304066400 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/IntermediaryDataManager.java

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304068750 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/http/ShuffleResource.java ##

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304065976 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/IntermediaryDataManager.java

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304063075 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java #

[GitHub] [incubator-druid] mihai-cazacu-adswizz commented on issue #8063: The compaction task fails without errors

2019-07-16 Thread GitBox
mihai-cazacu-adswizz commented on issue #8063: The compaction task fails without errors URL: https://github.com/apache/incubator-druid/issues/8063#issuecomment-511942787 I have solved this by changing the value of `Xmx` and `MaxDirectMemorySize` for Peons. Even so, it would be nic

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304067921 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/IntermediaryDataManager.java

[GitHub] [incubator-druid] jihoonson commented on issue #7547: Add support minor compaction with segment locking

2019-07-16 Thread GitBox
jihoonson commented on issue #7547: Add support minor compaction with segment locking URL: https://github.com/apache/incubator-druid/pull/7547#issuecomment-511966275 @clintropolis I ran some benchmark and here are some results. The benchmark code is available in [my branch](https://github

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304107048 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java #

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304107067 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/IntermediaryDataManager.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304107095 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/IntermediaryDataManager.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304107143 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/http/ShuffleResource.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
jihoonson commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304107124 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/IntermediaryDataManager.java

[GitHub] [incubator-druid] jihoonson commented on issue #8089: add CachingClusteredClient benchmark, refactor some stuff

2019-07-16 Thread GitBox
jihoonson commented on issue #8089: add CachingClusteredClient benchmark, refactor some stuff URL: https://github.com/apache/incubator-druid/pull/8089#issuecomment-512006804 LGTM overall. Would you fix the Line 198 of BrokerServerView? It should be `QueryableDruidServer retVal = new Querya

[GitHub] [incubator-druid] himanshug merged pull request #8086: add Class.getCanonicalName to forbidden-apis

2019-07-16 Thread GitBox
himanshug merged pull request #8086: add Class.getCanonicalName to forbidden-apis URL: https://github.com/apache/incubator-druid/pull/8086 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: add Class.getCanonicalName to forbidden-apis (#8086)

2019-07-16 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 15fbf59 add Class.getCanonicalName

[GitHub] [incubator-druid] vogievetsky opened a new pull request #8090: Web console: add missing dynamic coordinator configs

2019-07-16 Thread GitBox
vogievetsky opened a new pull request #8090: Web console: add missing dynamic coordinator configs URL: https://github.com/apache/incubator-druid/pull/8090 Added `decommissioningNodes` and `decommissioningMaxPercentOfMaxSegmentsToMove` were missing from the dynamic config dialog. !

[GitHub] [incubator-druid] clintropolis merged pull request #8090: Web console: add missing dynamic coordinator configs

2019-07-16 Thread GitBox
clintropolis merged pull request #8090: Web console: add missing dynamic coordinator configs URL: https://github.com/apache/incubator-druid/pull/8090 This is an automated message from the Apache Git Service. To respond to th

[incubator-druid] branch master updated: add missing dynamic coordinator configs (#8090)

2019-07-16 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new b80f20f add missing dynamic coordinato

[GitHub] [incubator-druid] ccaominh commented on issue #7866: Moving project to Gradle

2019-07-16 Thread GitBox
ccaominh commented on issue #7866: Moving project to Gradle URL: https://github.com/apache/incubator-druid/issues/7866#issuecomment-512060236 My earlier measurements for maven were unfair as I have not converted most of the maven plugins to their gradle equivalents. The adjusted numbers fo

[GitHub] [incubator-druid] pzhdfy commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)

2019-07-16 Thread GitBox
pzhdfy commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster) URL: https://github.com/apache/incubator-druid/pull/6988#issuecomment-512068329 > I apply it to 0.12.3, but inoperative. I just apply and restart on one historical node of clust

[GitHub] [incubator-druid] pzhdfy commented on issue #7594: [for master] general exactly count distinct support in Druid

2019-07-16 Thread GitBox
pzhdfy commented on issue #7594: [for master] general exactly count distinct support in Druid URL: https://github.com/apache/incubator-druid/pull/7594#issuecomment-512074338 > From the error message ,i think there is must be an error in built dictionary stage ! so when in the ingestion sta

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
clintropolis commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304182914 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/worker/IntermediaryDataManagerMan

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8088: Add intermediary data server for shuffle

2019-07-16 Thread GitBox
clintropolis commented on a change in pull request #8088: Add intermediary data server for shuffle URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304204101 ## File path: server/src/main/java/org/apache/druid/server/http/security/TaskShuffleResourceFilter.java

[GitHub] [incubator-druid] JackyYangPassion commented on issue #7594: [for master] general exactly count distinct support in Druid

2019-07-16 Thread GitBox
JackyYangPassion commented on issue #7594: [for master] general exactly count distinct support in Druid URL: https://github.com/apache/incubator-druid/pull/7594#issuecomment-512086460 > > From the error message ,i think there is must be an error in built dictionary stage ! so when in the i

[GitHub] [incubator-druid] gianm opened a new issue #8091: groupBy with subtotalsSpec doesn't fully group each set

2019-07-16 Thread GitBox
gianm opened a new issue #8091: groupBy with subtotalsSpec doesn't fully group each set URL: https://github.com/apache/incubator-druid/issues/8091 These two queries (if posed in GroupByQueryRunnerTest) return different results, but I think they should return the same results. The only diff

[GitHub] [incubator-druid] alonshoshani commented on issue #8058: Graphite Emitter Issue Druid 0.14

2019-07-16 Thread GitBox
alonshoshani commented on issue #8058: Graphite Emitter Issue Druid 0.14 URL: https://github.com/apache/incubator-druid/issues/8058#issuecomment-512113264 @vogievetsk Hi Vadim, I opened the issues 6 days ago and no response yet. I didn't find someone which the graphite metrics wor

[GitHub] [incubator-druid] shizhengchao opened a new issue #8092: `Connection[xxxx] already open` exception when concurrent queries(BUG)

2019-07-16 Thread GitBox
shizhengchao opened a new issue #8092: `Connection[] already open` exception when concurrent queries(BUG) URL: https://github.com/apache/incubator-druid/issues/8092 `Connection[] already open` exception when concurrent queries ### Affected Version 0.16.0-incubating-SNA

[GitHub] [incubator-druid] samarthjain opened a new issue #8093: SQL GroupBy query fails for aggregations returning complex type

2019-07-16 Thread GitBox
samarthjain opened a new issue #8093: SQL GroupBy query fails for aggregations returning complex type URL: https://github.com/apache/incubator-druid/issues/8093 Please provide a detailed title (e.g. "Broker crashes when using TopN query with Bound filter" instead of just "Broker crashes").