[GitHub] [druid] himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category

2020-02-21 Thread GitBox
himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category URL: https://github.com/apache/druid/pull/9350#discussion_r382888794 ## File path:

[GitHub] [druid] himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category

2020-02-21 Thread GitBox
himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category URL: https://github.com/apache/druid/pull/9350#discussion_r382714533 ## File path: docs/configuration/index.md ## @@ -990,6 +985,22 @@ To view last

[GitHub] [druid] himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category

2020-02-21 Thread GitBox
himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category URL: https://github.com/apache/druid/pull/9350#discussion_r382716878 ## File path:

[GitHub] [druid] himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category

2020-02-21 Thread GitBox
himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category URL: https://github.com/apache/druid/pull/9350#discussion_r382888648 ## File path:

[GitHub] [druid] suneet-s opened a new issue #9392: Update Kinesis Indexing service to use amazon-kinesis-client

2020-02-21 Thread GitBox
suneet-s opened a new issue #9392: Update Kinesis Indexing service to use amazon-kinesis-client URL: https://github.com/apache/druid/issues/9392 ### Description In KinesisRecordSupplier this comment indicates that the kinesis client is not compatible with the apache license. As of

[GitHub] [druid] suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

2020-02-21 Thread GitBox
suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check URL: https://github.com/apache/druid/pull/9384#discussion_r382872068 ## File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java ## @@ -114,4 +118,37

[GitHub] [druid] suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

2020-02-21 Thread GitBox
suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check URL: https://github.com/apache/druid/pull/9384#discussion_r382871144 ## File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java ## @@ -114,4 +118,37

[GitHub] [druid] suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

2020-02-21 Thread GitBox
suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check URL: https://github.com/apache/druid/pull/9384#discussion_r382870885 ## File path: processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java ##

[GitHub] [druid] suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

2020-02-21 Thread GitBox
suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check URL: https://github.com/apache/druid/pull/9384#discussion_r382873394 ## File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java ## @@ -114,4 +118,37

[GitHub] [druid] suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

2020-02-21 Thread GitBox
suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check URL: https://github.com/apache/druid/pull/9384#discussion_r382871126 ## File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java ## @@ -114,4 +118,37

[GitHub] [druid] suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

2020-02-21 Thread GitBox
suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check URL: https://github.com/apache/druid/pull/9384#discussion_r382873381 ## File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java ## @@ -114,4 +118,37

[GitHub] [druid] jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing URL: https://github.com/apache/druid/pull/9360#discussion_r382872400 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/input/DruidInputSource.java

[GitHub] [druid] jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing URL: https://github.com/apache/druid/pull/9360#discussion_r382870128 ## File path: core/src/main/java/org/apache/druid/data/input/impl/InputEntityIteratingReader.java

[GitHub] [druid] jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing URL: https://github.com/apache/druid/pull/9360#discussion_r382869968 ## File path: core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java ## @@

[GitHub] [druid] jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing URL: https://github.com/apache/druid/pull/9360#discussion_r382870157 ## File path: core/src/main/java/org/apache/druid/data/input/impl/InputEntityIteratingReader.java

[GitHub] [druid] jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing URL: https://github.com/apache/druid/pull/9360#discussion_r382871722 ## File path:

[GitHub] [druid] jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing URL: https://github.com/apache/druid/pull/9360#discussion_r382870695 ## File path: core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java ## @@

[GitHub] [druid] jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9360: Create splits of multiple files for parallel indexing URL: https://github.com/apache/druid/pull/9360#discussion_r382860923 ## File path: core/src/main/java/org/apache/druid/data/input/MaxSizeSplitHintSpec.java ## @@

[druid] branch master updated (05258dc -> 6d8dd5e)

2020-02-21 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 05258dc Improved the readability and fixed few java warnings (#9163) add 6d8dd5e string -> expression ->

[GitHub] [druid] jon-wei merged pull request #9367: string -> expression -> string -> expression

2020-02-21 Thread GitBox
jon-wei merged pull request #9367: string -> expression -> string -> expression URL: https://github.com/apache/druid/pull/9367 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] jihoonson commented on a change in pull request #9367: string -> expression -> string -> expression

2020-02-21 Thread GitBox
jihoonson commented on a change in pull request #9367: string -> expression -> string -> expression URL: https://github.com/apache/druid/pull/9367#discussion_r382849066 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java ## @@ -188,9 +195,15

[druid] branch master updated (f707064 -> 05258dc)

2020-02-21 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from f707064 Add Azure config options for segment prefix and max listing length (#9356) add 05258dc Improved the

[GitHub] [druid] gianm commented on a change in pull request #9163: Improved the readability and fixed few java warnings

2020-02-21 Thread GitBox
gianm commented on a change in pull request #9163: Improved the readability and fixed few java warnings URL: https://github.com/apache/druid/pull/9163#discussion_r382836818 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidConvention.java ## @@ -73,7

[GitHub] [druid] gianm merged pull request #9163: Improved the readability and fixed few java warnings

2020-02-21 Thread GitBox
gianm merged pull request #9163: Improved the readability and fixed few java warnings URL: https://github.com/apache/druid/pull/9163 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [druid] gianm commented on a change in pull request #9163: Improved the readability and fixed few java warnings

2020-02-21 Thread GitBox
gianm commented on a change in pull request #9163: Improved the readability and fixed few java warnings URL: https://github.com/apache/druid/pull/9163#discussion_r382836818 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidConvention.java ## @@ -73,7

[druid] branch master updated (141d8dd -> f707064)

2020-02-21 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 141d8dd Enable druid.coordinator.kill.pendingSegments.on by default (#9385) add f707064 Add Azure config

[GitHub] [druid] jon-wei merged pull request #9356: Add Azure config options for segment prefix and max listing length

2020-02-21 Thread GitBox
jon-wei merged pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356 This is an automated message from the Apache Git Service. To respond to

[GitHub] [druid] clintropolis merged pull request #9385: Enable druid.coordinator.kill.pendingSegments.on by default

2020-02-21 Thread GitBox
clintropolis merged pull request #9385: Enable druid.coordinator.kill.pendingSegments.on by default URL: https://github.com/apache/druid/pull/9385 This is an automated message from the Apache Git Service. To respond to the

[druid] branch master updated (3f848e6 -> 141d8dd)

2020-02-21 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3f848e6 Suppress CVE-2020-8840 for htrace-core-4.0.1 (#9379) add 141d8dd Enable

[GitHub] [druid] himanshug commented on issue #9122: Add SQL GROUPING SETS support.

2020-02-21 Thread GitBox
himanshug commented on issue #9122: Add SQL GROUPING SETS support. URL: https://github.com/apache/druid/pull/9122#issuecomment-589828549 > Alter behavior so limitSpec is applied after subtotalsSpec, rather than applied to each grouping set. This is more in line with SQL standard

[GitHub] [druid] himanshug commented on issue #9179: Run IntelliJ inspections on Travis

2020-02-21 Thread GitBox
himanshug commented on issue #9179: Run IntelliJ inspections on Travis URL: https://github.com/apache/druid/pull/9179#issuecomment-589810557 @ccaominh :+1: This is an automated message from the Apache Git Service. To

[GitHub] [druid] zachjsh commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

2020-02-21 Thread GitBox
zachjsh commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356#discussion_r382757696 ## File path: docs/development/extensions-contrib/azure.md ## @@ -29,68 +29,15 @@

[GitHub] [druid] zachjsh commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

2020-02-21 Thread GitBox
zachjsh commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356#discussion_r382757746 ## File path: docs/development/extensions-core/google.md ## @@ -34,6 +34,13 @@ To

[GitHub] [druid] zachjsh commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

2020-02-21 Thread GitBox
zachjsh commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356#discussion_r382757664 ## File path: docs/development/extensions-contrib/azure.md ## @@ -29,68 +29,15 @@

[GitHub] [druid] jon-wei commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356#discussion_r382755361 ## File path: docs/development/extensions-core/google.md ## @@ -34,6 +34,13 @@ To

[druid] branch master updated (30c24df -> 3f848e6)

2020-02-21 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 30c24df Add config option for namespacePrefix (#9372) add 3f848e6 Suppress CVE-2020-8840 for

[GitHub] [druid] ccaominh merged pull request #9379: Suppress CVE-2020-8840 for htrace-core-4.0.1

2020-02-21 Thread GitBox
ccaominh merged pull request #9379: Suppress CVE-2020-8840 for htrace-core-4.0.1 URL: https://github.com/apache/druid/pull/9379 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] jon-wei commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356#discussion_r382731857 ## File path: docs/development/extensions-contrib/azure.md ## @@ -29,68 +29,15 @@

[GitHub] [druid] jon-wei commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

2020-02-21 Thread GitBox
jon-wei commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356#discussion_r382732277 ## File path: docs/development/extensions-contrib/azure.md ## @@ -29,68 +29,15 @@

[GitHub] [druid] acdn-mpreston opened a new issue #9391: 0.17.0 Kafka Supervisor becomes "unhealthy" due to missing inputFormat when Overlord is restarted

2020-02-21 Thread GitBox
acdn-mpreston opened a new issue #9391: 0.17.0 Kafka Supervisor becomes "unhealthy" due to missing inputFormat when Overlord is restarted URL: https://github.com/apache/druid/issues/9391 ### Affected Version 0.17.0 The Druid version where the problem was encountered.

[GitHub] [druid] a2l007 commented on issue #9389: CombiningFirehoseFactory cannot be cast to FiniteFirehoseFactory

2020-02-21 Thread GitBox
a2l007 commented on issue #9389: CombiningFirehoseFactory cannot be cast to FiniteFirehoseFactory URL: https://github.com/apache/druid/issues/9389#issuecomment-589692443 It looks like a bug since `CombiningFirehoseFactory` should be implementing `FiniteFirehoseFactory` and there isn't an

[GitHub] [druid] pzhdfy opened a new pull request #9390: [bugfix]fix sequences ArrayIndexOutOfBoundsException in SeekableStreamIndexTaskRunner

2020-02-21 Thread GitBox
pzhdfy opened a new pull request #9390: [bugfix]fix sequences ArrayIndexOutOfBoundsException in SeekableStreamIndexTaskRunner URL: https://github.com/apache/druid/pull/9390 ### Description getLastSequenceMetadata in SeekableStreamIndexTaskRunner ` private SequenceMetadata

[GitHub] [druid] lgtm-com[bot] commented on issue #9367: string -> expression -> string -> expression

2020-02-21 Thread GitBox
lgtm-com[bot] commented on issue #9367: string -> expression -> string -> expression URL: https://github.com/apache/druid/pull/9367#issuecomment-589622619 This pull request **introduces 1 alert** when merging 7efa7d616fb97e0c67e254ff2a174205acf85ad5 into

[GitHub] [druid] gunjdesai opened a new issue #9389: CombiningFirehoseFactory cannot be cast to FiniteFirehoseFactory

2020-02-21 Thread GitBox
gunjdesai opened a new issue #9389: CombiningFirehoseFactory cannot be cast to FiniteFirehoseFactory URL: https://github.com/apache/druid/issues/9389 I am attempting to combing two datasources using the CombiningFirehoseFactory For reference, I am following the [update data

[GitHub] [druid] pomdtr opened a new issue #9388: Unable to set maxNumConcurrentSubTasks property for index_parallel ingestion task

2020-02-21 Thread GitBox
pomdtr opened a new issue #9388: Unable to set maxNumConcurrentSubTasks property for index_parallel ingestion task URL: https://github.com/apache/druid/issues/9388 ### Affected Version Druid 0.17 ### Description The maxNumConcurrentSubTasks property is not parsed

[GitHub] [druid] clintropolis commented on a change in pull request #9367: string -> expression -> string -> expression

2020-02-21 Thread GitBox
clintropolis commented on a change in pull request #9367: string -> expression -> string -> expression URL: https://github.com/apache/druid/pull/9367#discussion_r382516560 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java ## @@ -188,9

[GitHub] [druid] clintropolis commented on a change in pull request #9367: string -> expression -> string -> expression

2020-02-21 Thread GitBox
clintropolis commented on a change in pull request #9367: string -> expression -> string -> expression URL: https://github.com/apache/druid/pull/9367#discussion_r382516560 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java ## @@ -188,9

[GitHub] [druid] frnidito edited a comment on issue #8987: Adding support for autoscaling in GCE

2020-02-21 Thread GitBox
frnidito edited a comment on issue #8987: Adding support for autoscaling in GCE URL: https://github.com/apache/druid/pull/8987#issuecomment-589081325 @clintropolis — I should have either replied or fixed to the various comments but I have an (I believe) unrelated test failing

[GitHub] [druid] clintropolis commented on a change in pull request #9367: string -> expression -> string -> expression

2020-02-21 Thread GitBox
clintropolis commented on a change in pull request #9367: string -> expression -> string -> expression URL: https://github.com/apache/druid/pull/9367#discussion_r382514476 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprMacroTable.java ## @@ -132,17

[GitHub] [druid] dars1608 commented on issue #7931: a problem with druid jdbc support

2020-02-21 Thread GitBox
dars1608 commented on issue #7931: a problem with druid jdbc support URL: https://github.com/apache/druid/issues/7931#issuecomment-589580329 Are there any plans to patch this in the next updates? This is an automated message

[GitHub] [druid] frnidito opened a new pull request #9387: Improves on the fix for 8918

2020-02-21 Thread GitBox
frnidito opened a new pull request #9387: Improves on the fix for 8918 URL: https://github.com/apache/druid/pull/9387 Improves on the fixes for #8918 ### Description It just changes the `ITRetryUtil.retryUntilTrue` with a `ITRetryUtil.retryUntil` in order to increase the

[GitHub] [druid] frnidito edited a comment on issue #8987: Adding support for autoscaling in GCE

2020-02-21 Thread GitBox
frnidito edited a comment on issue #8987: Adding support for autoscaling in GCE URL: https://github.com/apache/druid/pull/8987#issuecomment-589081325 @clintropolis — I should have either replied or fixed to the various comments but I have an (I believe) unrelated test failing