[GitHub] [druid] clintropolis opened a new pull request #10124: bump version to 0.20.0-SNAPSHOT

2020-07-01 Thread GitBox
clintropolis opened a new pull request #10124: URL: https://github.com/apache/druid/pull/10124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[druid] branch 0.19.0 created (now ed981ef)

2020-07-01 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch 0.19.0 in repository https://gitbox.apache.org/repos/asf/druid.git. at ed981ef Add DimFilter.toOptimizedFilter(), ensure that join filter pre-analysis operates on optimized filters (#1005

[druid] branch master updated: Add DimFilter.toOptimizedFilter(), ensure that join filter pre-analysis operates on optimized filters (#10056)

2020-07-01 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new ed981ef Add DimFilter.toOptimizedFilter(), ens

[GitHub] [druid] ccaominh merged pull request #10056: Add DimFilter.toOptimizedFilter(), ensure that join filter pre-analysis operates on optimized filters

2020-07-01 Thread GitBox
ccaominh merged pull request #10056: URL: https://github.com/apache/druid/pull/10056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (60c6bd5 -> 367eaed)

2020-07-01 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 60c6bd5 support Aliyun OSS service as deep storage (#9898) add 367eaed Clarify change in behavior for druid.ser

[GitHub] [druid] clintropolis merged pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-07-01 Thread GitBox
clintropolis merged pull request #10105: URL: https://github.com/apache/druid/pull/10105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (e2c5bcc -> 60c6bd5)

2020-07-01 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from e2c5bcc Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning … (#10123) add 60c6bd5 support Al

[GitHub] [druid] clintropolis merged pull request #9898: support Aliyun OSS service as deep storage

2020-07-01 Thread GitBox
clintropolis merged pull request #9898: URL: https://github.com/apache/druid/pull/9898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] samarthjain merged pull request #10123: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning …

2020-07-01 Thread GitBox
samarthjain merged pull request #10123: URL: https://github.com/apache/druid/pull/10123 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[druid] branch master updated: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning … (#10123)

2020-07-01 Thread samarth
This is an automated email from the ASF dual-hosted git repository. samarth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new e2c5bcc Fix UnknownComplexTypeColumn#makeVector

[GitHub] [druid] samarthjain commented on a change in pull request #10123: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning …

2020-07-01 Thread GitBox
samarthjain commented on a change in pull request #10123: URL: https://github.com/apache/druid/pull/10123#discussion_r448722745 ## File path: processing/src/main/java/org/apache/druid/segment/serde/ComplexColumnPartSerde.java ## @@ -33,11 +34,17 @@ @Nullable private fina

[GitHub] [druid] ccaominh commented on a change in pull request #10056: Add DimFilter.toOptimizedFilter(), ensure that join filter pre-analysis operates on optimized filters

2020-07-01 Thread GitBox
ccaominh commented on a change in pull request #10056: URL: https://github.com/apache/druid/pull/10056#discussion_r448715436 ## File path: processing/src/main/java/org/apache/druid/query/filter/DimFilter.java ## @@ -23,7 +23,11 @@ import com.fasterxml.jackson.annotation.JsonTy

[GitHub] [druid] clintropolis commented on a change in pull request #10123: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning …

2020-07-01 Thread GitBox
clintropolis commented on a change in pull request #10123: URL: https://github.com/apache/druid/pull/10123#discussion_r448709942 ## File path: processing/src/main/java/org/apache/druid/segment/serde/ComplexColumnPartSerde.java ## @@ -33,11 +34,17 @@ @Nullable private fin

[druid] branch master updated (1676ba2 -> c5540f4)

2020-07-01 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 1676ba2 Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram (#10120) add c5540f4 fixe

[GitHub] [druid] clintropolis merged pull request #10109: fixes for apache ranger extension docs

2020-07-01 Thread GitBox
clintropolis merged pull request #10109: URL: https://github.com/apache/druid/pull/10109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [druid] FrankChen021 commented on issue #10122: StorageLocation.availableSizeBytes doesn't consider segment cache usage on disk

2020-07-01 Thread GitBox
FrankChen021 commented on issue #10122: URL: https://github.com/apache/druid/issues/10122#issuecomment-652720683 There's another problem related to `CurrSize` which I have not investigated. That is `CurrSize` is bigger than the actual disk consumption. On several default tier histori

[GitHub] [druid] jon-wei merged pull request #10120: Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram

2020-07-01 Thread GitBox
jon-wei merged pull request #10120: URL: https://github.com/apache/druid/pull/10120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] jon-wei closed issue #9906: Stack overflow with SELECT ARRAY ['Hello', NULL]

2020-07-01 Thread GitBox
jon-wei closed issue #9906: URL: https://github.com/apache/druid/issues/9906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[druid] branch master updated: Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram (#10120)

2020-07-01 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 1676ba2 Fix Stack overflow with infinite loop in

[GitHub] [druid] samarthjain commented on a change in pull request #10123: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning …

2020-07-01 Thread GitBox
samarthjain commented on a change in pull request #10123: URL: https://github.com/apache/druid/pull/10123#discussion_r448684854 ## File path: processing/src/main/java/org/apache/druid/segment/column/SimpleColumnHolder.java ## @@ -21,6 +21,7 @@ import com.google.common.base.

[GitHub] [druid] clintropolis commented on a change in pull request #10123: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning …

2020-07-01 Thread GitBox
clintropolis commented on a change in pull request #10123: URL: https://github.com/apache/druid/pull/10123#discussion_r448682947 ## File path: processing/src/main/java/org/apache/druid/segment/column/SimpleColumnHolder.java ## @@ -21,6 +21,7 @@ import com.google.common.base

[GitHub] [druid] lgtm-com[bot] commented on pull request #10097: Do not echo back username on auth failure

2020-07-01 Thread GitBox
lgtm-com[bot] commented on pull request #10097: URL: https://github.com/apache/druid/pull/10097#issuecomment-652689662 This pull request **fixes 1 alert** when merging 37e88dab5afdc8ff077f6503a88db79faa5f7a89 into 477335abb4fe3e872a1b8f71d9c2bd90e4315fbc - [view on LGTM.com](https://lgtm.

[GitHub] [druid] gianm commented on a change in pull request #10106: Add validation for authorizer name

2020-07-01 Thread GitBox
gianm commented on a change in pull request #10106: URL: https://github.com/apache/druid/pull/10106#discussion_r448641609 ## File path: server/src/main/java/org/apache/druid/server/initialization/AuthorizerMapperModule.java ## @@ -58,7 +62,10 @@ public void configure(Binder bi

[GitHub] [druid] clintropolis commented on a change in pull request #10123: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning …

2020-07-01 Thread GitBox
clintropolis commented on a change in pull request #10123: URL: https://github.com/apache/druid/pull/10123#discussion_r448642655 ## File path: processing/src/main/java/org/apache/druid/segment/column/SimpleColumnHolder.java ## @@ -61,6 +63,8 @@ capabilities.getType(

[GitHub] [druid] suneet-s commented on pull request #10097: Do not echo back username on auth failure

2020-07-01 Thread GitBox
suneet-s commented on pull request #10097: URL: https://github.com/apache/druid/pull/10097#issuecomment-652667680 Since this wasn't an issue before this patch, I've removed the label `Security` @clintropolis please add it back / lmk if it's needed. ---

[GitHub] [druid] jihoonson edited a comment on pull request #10121: Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector"

2020-07-01 Thread GitBox
jihoonson edited a comment on pull request #10121: URL: https://github.com/apache/druid/pull/10121#issuecomment-652667303 I'm fine with doing it in a follow-up too. This is an automated message from the Apache Git Service. To

[GitHub] [druid] jihoonson commented on pull request #10121: Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector"

2020-07-01 Thread GitBox
jihoonson commented on pull request #10121: URL: https://github.com/apache/druid/pull/10121#issuecomment-652667303 I'm fine with follow-up too. This is an automated message from the Apache Git Service. To respond to the messa

[druid] branch master updated (3e92cdf -> 477335a)

2020-07-01 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3e92cdf Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector" (#10121) add 477335a update links dat

[GitHub] [druid] ccaominh merged pull request #10107: update links datasketches.github.io to datasketches.apache.org

2020-07-01 Thread GitBox
ccaominh merged pull request #10107: URL: https://github.com/apache/druid/pull/10107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] samarthjain opened a new pull request #10123: Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a warning …

2020-07-01 Thread GitBox
samarthjain opened a new pull request #10123: URL: https://github.com/apache/druid/pull/10123 Follow up fix for #9422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [druid] clintropolis commented on pull request #10121: Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector"

2020-07-01 Thread GitBox
clintropolis commented on pull request #10121: URL: https://github.com/apache/druid/pull/10121#issuecomment-652658749 @samarthjain could you open a PR to make the change of this revert, also maybe consider adding a log.warn somewhere https://github.com/apache/druid/pull/9422#discussion_r44

[GitHub] [druid] clintropolis commented on pull request #10121: Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector"

2020-07-01 Thread GitBox
clintropolis commented on pull request #10121: URL: https://github.com/apache/druid/pull/10121#issuecomment-652657541 skipping CI since this is a revert This is an automated message from the Apache Git Service. To respond to

[GitHub] [druid] clintropolis merged pull request #10121: Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector"

2020-07-01 Thread GitBox
clintropolis merged pull request #10121: URL: https://github.com/apache/druid/pull/10121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated: Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector" (#10121)

2020-07-01 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 3e92cdf Revert "Fix UnknownTypeComplexColumn#ma

[GitHub] [druid] clintropolis commented on a change in pull request #9422: Handle unknown complex types

2020-07-01 Thread GitBox
clintropolis commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448621794 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apach

[druid] branch master updated (657f8ee -> a337ef3)

2020-07-01 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 657f8ee Fix RetryQueryRunner to actually do the job (#10082) add a337ef3 Closing yielder from ParallelMergeCombin

[GitHub] [druid] gianm merged pull request #10117: Closing yielder from ParallelMergeCombiningSequence should trigger cancellation

2020-07-01 Thread GitBox
gianm merged pull request #10117: URL: https://github.com/apache/druid/pull/10117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [druid] jihoonson commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
jihoonson commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652645612 @gianm @clintropolis thank you for the review. I'll address @gianm's last comments in follow-ups. This is an

[GitHub] [druid] clintropolis merged pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
clintropolis merged pull request #10082: URL: https://github.com/apache/druid/pull/10082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [druid] jon-wei commented on a change in pull request #10056: Add DimFilter.toOptimizedFilter(), ensure that join filter pre-analysis operates on optimized filters

2020-07-01 Thread GitBox
jon-wei commented on a change in pull request #10056: URL: https://github.com/apache/druid/pull/10056#discussion_r448611416 ## File path: processing/src/main/java/org/apache/druid/query/filter/AbstractOptimizableDimFilter.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[GitHub] [druid] gianm commented on a change in pull request #10056: Add DimFilter.toOptimizedFilter(), ensure that join filter pre-analysis operates on optimized filters

2020-07-01 Thread GitBox
gianm commented on a change in pull request #10056: URL: https://github.com/apache/druid/pull/10056#discussion_r448606808 ## File path: processing/src/main/java/org/apache/druid/query/filter/AbstractOptimizableDimFilter.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache S

[GitHub] [druid] a2l007 opened a new issue #10122: StorageLocation.availableSizeBytes doesn't consider segment cache usage on disk

2020-07-01 Thread GitBox
a2l007 opened a new issue #10122: URL: https://github.com/apache/druid/issues/10122 One of our internal clusters had a weird issue where certain historicals were running out of disk space and during the investigation I came across the following behavior: It looks like [StorageLocation.

[GitHub] [druid] suneet-s commented on a change in pull request #10109: fixes for apache ranger extension docs

2020-07-01 Thread GitBox
suneet-s commented on a change in pull request #10109: URL: https://github.com/apache/druid/pull/10109#discussion_r448592173 ## File path: docs/development/extensions-core/druid-ranger-security.md ## @@ -22,43 +22,30 @@ title: "Apache Ranger Security" ~ under the License.

[GitHub] [druid] maytasm commented on a change in pull request #10120: Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram

2020-07-01 Thread GitBox
maytasm commented on a change in pull request #10120: URL: https://github.com/apache/druid/pull/10120#discussion_r448587442 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/Rules.java ## @@ -85,6 +88,13 @@ public static final int DRUID_CONVENTION_RULES =

[GitHub] [druid] suneet-s commented on a change in pull request #10120: Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram

2020-07-01 Thread GitBox
suneet-s commented on a change in pull request #10120: URL: https://github.com/apache/druid/pull/10120#discussion_r448570647 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/Rules.java ## @@ -85,6 +88,13 @@ public static final int DRUID_CONVENTION_RULES =

[GitHub] [druid] maytasm closed pull request #10114: Add integration tests for CSV InputFormat

2020-07-01 Thread GitBox
maytasm closed pull request #10114: URL: https://github.com/apache/druid/pull/10114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] lgtm-com[bot] commented on pull request #10097: Do not echo back username on auth failure

2020-07-01 Thread GitBox
lgtm-com[bot] commented on pull request #10097: URL: https://github.com/apache/druid/pull/10097#issuecomment-652601110 This pull request **fixes 1 alert** when merging a08f140cd9c07f7116173bf987d4a535b3bc95ae into d3497a6581c69f810090f5180f1f18328b06c781 - [view on LGTM.com](https://lgtm.

[GitHub] [druid] samarthjain opened a new pull request #10121: Revert "Fix UnknownTypeComplexColumn#makeVectorObjectSelector"

2020-07-01 Thread GitBox
samarthjain opened a new pull request #10121: URL: https://github.com/apache/druid/pull/10121 This reverts commit 7bb7489afc7a2cc496be93ae69681b6ab13a7c66. This is an automated message from the Apache Git Service. To respond

[GitHub] [druid] suneet-s commented on pull request #10107: update links datasketches.github.io to datasketches.apache.org

2020-07-01 Thread GitBox
suneet-s commented on pull request #10107: URL: https://github.com/apache/druid/pull/10107#issuecomment-652598589 It looks like travis passed, but the trigger didn't change the CI to green. I re-triggered the `animal-sniffer-checker` job hopefully it will mark this as passed soon ---

[GitHub] [druid] maytasm opened a new pull request #10120: Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram

2020-07-01 Thread GitBox
maytasm opened a new pull request #10120: URL: https://github.com/apache/druid/pull/10120 Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram ### Description This fix https://github.com/apache/druid/issues/9906 Due to Calcite bug (CALCITE-3845),

[druid] branch master updated (d3497a6 -> 7bb7489)

2020-07-01 Thread samarth
This is an automated email from the ASF dual-hosted git repository. samarth pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from d3497a6 Filter on metrics doc (#10087) add 7bb7489 Fix UnknownTypeComplexColumn#makeVectorObjectSelector No n

[GitHub] [druid] clintropolis commented on a change in pull request #9422: Handle unknown complex types

2020-07-01 Thread GitBox
clintropolis commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448557485 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apach

[GitHub] [druid] samarthjain commented on a change in pull request #9422: Handle unknown complex types

2020-07-01 Thread GitBox
samarthjain commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448544157 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

[GitHub] [druid] samarthjain commented on a change in pull request #9422: Handle unknown complex types

2020-07-01 Thread GitBox
samarthjain commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448544343 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

[GitHub] [druid] samarthjain commented on a change in pull request #9422: Handle unknown complex types

2020-07-01 Thread GitBox
samarthjain commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448544157 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

[GitHub] [druid] gianm commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
gianm commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652576873 > @gianm thanks for the review. As Travis is extremely slow recently, I'd like to address your last comments in a follow-up with doc for the known issue with response context not

[GitHub] [druid] jihoonson commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
jihoonson commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652572586 @gianm thanks for the review. As Travis is extremely slow recently, I'd like to address your last comments in a follow-up with doc for the known issue with response context no

[GitHub] [druid] gianm commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
gianm commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652569145 Btw, if you can do the above two things (and add integration tests) in follow-ups before the next release, I think that would be OK. Let us know what you prefer @jihoonson.

[GitHub] [druid] gianm commented on a change in pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
gianm commented on a change in pull request #10082: URL: https://github.com/apache/druid/pull/10082#discussion_r448525940 ## File path: processing/src/main/java/org/apache/druid/query/QueryInterruptedException.java ## @@ -105,6 +106,8 @@ private static String getErrorCodeFromT

[GitHub] [druid] damnMeddlingKid commented on issue #10072: Average aggregate does not ignore nulls in long column when druid.generic.useDefaultValueForNull=false

2020-07-01 Thread GitBox
damnMeddlingKid commented on issue #10072: URL: https://github.com/apache/druid/issues/10072#issuecomment-652560849 Thanks Gian, I'll refactor it and put up a PR. This is an automated message from the Apache Git Service. To r

[GitHub] [druid] gianm edited a comment on issue #10072: Average aggregate does not ignore nulls in long column when druid.generic.useDefaultValueForNull=false

2020-07-01 Thread GitBox
gianm edited a comment on issue #10072: URL: https://github.com/apache/druid/issues/10072#issuecomment-652550179 Ah, it's possible both cases (nullable and non-nullable) would be covered by existing tests, but if not, please add enough tests to cover both to CalciteQueryTest. ---

[GitHub] [druid] gianm commented on issue #10072: Average aggregate does not ignore nulls in long column when druid.generic.useDefaultValueForNull=false

2020-07-01 Thread GitBox
gianm commented on issue #10072: URL: https://github.com/apache/druid/issues/10072#issuecomment-652550179 It's possible both cases (nullable and non-nullable) would be covered by existing tests, but if not, please add enough tests to cover both to CalciteQueryTest. --

[GitHub] [druid] gianm commented on issue #10072: Average aggregate does not ignore nulls in long column when druid.generic.useDefaultValueForNull=false

2020-07-01 Thread GitBox
gianm commented on issue #10072: URL: https://github.com/apache/druid/issues/10072#issuecomment-652548762 Hi @damnMeddlingKid, Looks like this is a bug and you got the right fix. The logic is similar to what's in CountSqlAggregator already, so I'd suggest extracting it to a helper f

[GitHub] [druid] suneet-s closed pull request #10106: Add validation for authorizer name

2020-07-01 Thread GitBox
suneet-s closed pull request #10106: URL: https://github.com/apache/druid/pull/10106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] gianm opened a new pull request #10119: Combine InDimFilter, InFilter.

2020-07-01 Thread GitBox
gianm opened a new pull request #10119: URL: https://github.com/apache/druid/pull/10119 There are two motivations: 1. Ensure that when HashJoinSegmentStorageAdapter compares its Filter to the original one, and it is an "in" type, the comparison is by reference and does not

[GitHub] [druid] lgtm-com[bot] commented on pull request #10097: Do not echo back username on auth failure

2020-07-01 Thread GitBox
lgtm-com[bot] commented on pull request #10097: URL: https://github.com/apache/druid/pull/10097#issuecomment-652489374 This pull request **fixes 1 alert** when merging 01999dae21e5d60fa5cf9344e6d0a0a30c95ace6 into d3497a6581c69f810090f5180f1f18328b06c781 - [view on LGTM.com](https://lgtm.

[GitHub] [druid] xiangqiao123 opened a new issue #10118: DruidSchema is not thread safe

2020-07-01 Thread GitBox
xiangqiao123 opened a new issue #10118: URL: https://github.com/apache/druid/issues/10118 ### Affected Version 0.18.1 ### Description Suppose that an interval has more than one segment, if some segments are deleted, then refreshing the remaining segments by refreshing segme

[GitHub] [druid] a2l007 commented on pull request #10080: Add integration tests for SqlInputSource

2020-07-01 Thread GitBox
a2l007 commented on pull request #10080: URL: https://github.com/apache/druid/pull/10080#issuecomment-652427533 Thank you for adding this! This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [druid] jihoonson commented on a change in pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
jihoonson commented on a change in pull request #10082: URL: https://github.com/apache/druid/pull/10082#discussion_r448229976 ## File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] jihoonson commented on a change in pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
jihoonson commented on a change in pull request #10082: URL: https://github.com/apache/druid/pull/10082#discussion_r448229976 ## File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] jp707049 commented on issue #10078: How to use environment variables in runtime.properties?

2020-07-01 Thread GitBox
jp707049 commented on issue #10078: URL: https://github.com/apache/druid/issues/10078#issuecomment-652285832 Great, I will check and update here soon using your first method. Thanks :) This is an automated message from

[GitHub] [druid] FrankChen021 commented on issue #10078: How to use environment variables in runtime.properties?

2020-07-01 Thread GitBox
FrankChen021 commented on issue #10078: URL: https://github.com/apache/druid/issues/10078#issuecomment-652251590 I checked the `run-druid` file, putting environment variables in `jvm.config` won't take effect. But you can try the first method I mention above, that is putting `-Ddr

[GitHub] [druid] clintropolis opened a new pull request #10117: Closing yielder from ParallelMergeCombiningSequence should trigger cancellation

2020-07-01 Thread GitBox
clintropolis opened a new pull request #10117: URL: https://github.com/apache/druid/pull/10117 ### Description This PR fixes an issue with/modifies the behavior of closing a `Yielder` created from a `ParallelMergeCombiningSequence` to trigger a cancellation to immediately halt any addit

[GitHub] [druid] maytasm opened a new pull request #10116: Add integration tests for parquet InputFormat

2020-07-01 Thread GitBox
maytasm opened a new pull request #10116: URL: https://github.com/apache/druid/pull/10116 Add integration tests for parquet InputFormat ### Description Add integration tests for parquet InputFormat This PR has: - [x] been self-reviewed. - [ ] using the [concurre

[GitHub] [druid] maytasm opened a new pull request #10115: Add integration tests for ORC InputFormat

2020-07-01 Thread GitBox
maytasm opened a new pull request #10115: URL: https://github.com/apache/druid/pull/10115 Add integration tests for ORC InputFormat ### Description Add integration tests for ORC InputFormat This PR has: - [x] been self-reviewed. - [ ] using the [concurrency che