This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a change to branch 0.19.0
in repository https://gitbox.apache.org/repos/asf/druid.git.
at ed981ef Add DimFilter.toOptimizedFilter(), ensure that join filter
pre-analysis operates on optimized filters
This is an automated email from the ASF dual-hosted git repository.
ccaominh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new ed981ef Add DimFilter.toOptimizedFilter(),
ccaominh merged pull request #10056:
URL: https://github.com/apache/druid/pull/10056
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from 60c6bd5 support Aliyun OSS service as deep storage (#9898)
add 367eaed Clarify change in behavior for
clintropolis merged pull request #10105:
URL: https://github.com/apache/druid/pull/10105
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from e2c5bcc Fix UnknownComplexTypeColumn#makeVectorObjectSelector. Add a
warning … (#10123)
add 60c6bd5 support
clintropolis merged pull request #9898:
URL: https://github.com/apache/druid/pull/9898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
samarthjain merged pull request #10123:
URL: https://github.com/apache/druid/pull/10123
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
samarth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new e2c5bcc Fix
samarthjain commented on a change in pull request #10123:
URL: https://github.com/apache/druid/pull/10123#discussion_r448722745
##
File path:
processing/src/main/java/org/apache/druid/segment/serde/ComplexColumnPartSerde.java
##
@@ -33,11 +34,17 @@
@Nullable
private
ccaominh commented on a change in pull request #10056:
URL: https://github.com/apache/druid/pull/10056#discussion_r448715436
##
File path: processing/src/main/java/org/apache/druid/query/filter/DimFilter.java
##
@@ -23,7 +23,11 @@
import
clintropolis commented on a change in pull request #10123:
URL: https://github.com/apache/druid/pull/10123#discussion_r448709942
##
File path:
processing/src/main/java/org/apache/druid/segment/serde/ComplexColumnPartSerde.java
##
@@ -33,11 +34,17 @@
@Nullable
private
This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from 1676ba2 Fix Stack overflow with infinite loop in
ReduceExpressionsRule of HepProgram (#10120)
add c5540f4
clintropolis merged pull request #10109:
URL: https://github.com/apache/druid/pull/10109
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
FrankChen021 commented on issue #10122:
URL: https://github.com/apache/druid/issues/10122#issuecomment-652720683
There's another problem related to `CurrSize` which I have not investigated.
That is `CurrSize` is bigger than the actual disk consumption.
On several default tier
jon-wei merged pull request #10120:
URL: https://github.com/apache/druid/pull/10120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jon-wei closed issue #9906:
URL: https://github.com/apache/druid/issues/9906
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
jonwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 1676ba2 Fix Stack overflow with infinite loop
samarthjain commented on a change in pull request #10123:
URL: https://github.com/apache/druid/pull/10123#discussion_r448684854
##
File path:
processing/src/main/java/org/apache/druid/segment/column/SimpleColumnHolder.java
##
@@ -21,6 +21,7 @@
import
clintropolis commented on a change in pull request #10123:
URL: https://github.com/apache/druid/pull/10123#discussion_r448682947
##
File path:
processing/src/main/java/org/apache/druid/segment/column/SimpleColumnHolder.java
##
@@ -21,6 +21,7 @@
import
lgtm-com[bot] commented on pull request #10097:
URL: https://github.com/apache/druid/pull/10097#issuecomment-652689662
This pull request **fixes 1 alert** when merging
37e88dab5afdc8ff077f6503a88db79faa5f7a89 into
477335abb4fe3e872a1b8f71d9c2bd90e4315fbc - [view on
gianm commented on a change in pull request #10106:
URL: https://github.com/apache/druid/pull/10106#discussion_r448641609
##
File path:
server/src/main/java/org/apache/druid/server/initialization/AuthorizerMapperModule.java
##
@@ -58,7 +62,10 @@ public void configure(Binder
clintropolis commented on a change in pull request #10123:
URL: https://github.com/apache/druid/pull/10123#discussion_r448642655
##
File path:
processing/src/main/java/org/apache/druid/segment/column/SimpleColumnHolder.java
##
@@ -61,6 +63,8 @@
suneet-s commented on pull request #10097:
URL: https://github.com/apache/druid/pull/10097#issuecomment-652667680
Since this wasn't an issue before this patch, I've removed the label
`Security` @clintropolis please add it back / lmk if it's needed.
jihoonson edited a comment on pull request #10121:
URL: https://github.com/apache/druid/pull/10121#issuecomment-652667303
I'm fine with doing it in a follow-up too.
This is an automated message from the Apache Git Service.
jihoonson commented on pull request #10121:
URL: https://github.com/apache/druid/pull/10121#issuecomment-652667303
I'm fine with follow-up too.
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
ccaominh pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from 3e92cdf Revert "Fix
UnknownTypeComplexColumn#makeVectorObjectSelector" (#10121)
add 477335a update links
ccaominh merged pull request #10107:
URL: https://github.com/apache/druid/pull/10107
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
samarthjain opened a new pull request #10123:
URL: https://github.com/apache/druid/pull/10123
Follow up fix for #9422
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
clintropolis commented on pull request #10121:
URL: https://github.com/apache/druid/pull/10121#issuecomment-652658749
@samarthjain could you open a PR to make the change of this revert, also
maybe consider adding a log.warn somewhere
clintropolis commented on pull request #10121:
URL: https://github.com/apache/druid/pull/10121#issuecomment-652657541
skipping CI since this is a revert
This is an automated message from the Apache Git Service.
To respond to
clintropolis merged pull request #10121:
URL: https://github.com/apache/druid/pull/10121
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 3e92cdf Revert "Fix
clintropolis commented on a change in pull request #9422:
URL: https://github.com/apache/druid/pull/9422#discussion_r448621794
##
File path:
processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the
This is an automated email from the ASF dual-hosted git repository.
gian pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from 657f8ee Fix RetryQueryRunner to actually do the job (#10082)
add a337ef3 Closing yielder from
gianm merged pull request #10117:
URL: https://github.com/apache/druid/pull/10117
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jihoonson commented on pull request #10082:
URL: https://github.com/apache/druid/pull/10082#issuecomment-652645612
@gianm @clintropolis thank you for the review. I'll address @gianm's last
comments in follow-ups.
This is
clintropolis merged pull request #10082:
URL: https://github.com/apache/druid/pull/10082
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jon-wei commented on a change in pull request #10056:
URL: https://github.com/apache/druid/pull/10056#discussion_r448611416
##
File path:
processing/src/main/java/org/apache/druid/query/filter/AbstractOptimizableDimFilter.java
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
gianm commented on a change in pull request #10056:
URL: https://github.com/apache/druid/pull/10056#discussion_r448606808
##
File path:
processing/src/main/java/org/apache/druid/query/filter/AbstractOptimizableDimFilter.java
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache
a2l007 opened a new issue #10122:
URL: https://github.com/apache/druid/issues/10122
One of our internal clusters had a weird issue where certain historicals
were running out of disk space and during the investigation I came across the
following behavior:
It looks like
suneet-s commented on a change in pull request #10109:
URL: https://github.com/apache/druid/pull/10109#discussion_r448592173
##
File path: docs/development/extensions-core/druid-ranger-security.md
##
@@ -22,43 +22,30 @@ title: "Apache Ranger Security"
~ under the License.
maytasm commented on a change in pull request #10120:
URL: https://github.com/apache/druid/pull/10120#discussion_r448587442
##
File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/Rules.java
##
@@ -85,6 +88,13 @@
public static final int DRUID_CONVENTION_RULES =
suneet-s commented on a change in pull request #10120:
URL: https://github.com/apache/druid/pull/10120#discussion_r448570647
##
File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/Rules.java
##
@@ -85,6 +88,13 @@
public static final int DRUID_CONVENTION_RULES
maytasm closed pull request #10114:
URL: https://github.com/apache/druid/pull/10114
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lgtm-com[bot] commented on pull request #10097:
URL: https://github.com/apache/druid/pull/10097#issuecomment-652601110
This pull request **fixes 1 alert** when merging
a08f140cd9c07f7116173bf987d4a535b3bc95ae into
d3497a6581c69f810090f5180f1f18328b06c781 - [view on
samarthjain opened a new pull request #10121:
URL: https://github.com/apache/druid/pull/10121
This reverts commit 7bb7489afc7a2cc496be93ae69681b6ab13a7c66.
This is an automated message from the Apache Git Service.
To respond
suneet-s commented on pull request #10107:
URL: https://github.com/apache/druid/pull/10107#issuecomment-652598589
It looks like travis passed, but the trigger didn't change the CI to green.
I re-triggered the `animal-sniffer-checker` job hopefully it will mark this as
passed soon
maytasm opened a new pull request #10120:
URL: https://github.com/apache/druid/pull/10120
Fix Stack overflow with infinite loop in ReduceExpressionsRule of HepProgram
### Description
This fix https://github.com/apache/druid/issues/9906
Due to Calcite bug (CALCITE-3845),
This is an automated email from the ASF dual-hosted git repository.
samarth pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from d3497a6 Filter on metrics doc (#10087)
add 7bb7489 Fix UnknownTypeComplexColumn#makeVectorObjectSelector
No
clintropolis commented on a change in pull request #9422:
URL: https://github.com/apache/druid/pull/9422#discussion_r448557485
##
File path:
processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the
samarthjain commented on a change in pull request #9422:
URL: https://github.com/apache/druid/pull/9422#discussion_r448544157
##
File path:
processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the
samarthjain commented on a change in pull request #9422:
URL: https://github.com/apache/druid/pull/9422#discussion_r448544343
##
File path:
processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the
samarthjain commented on a change in pull request #9422:
URL: https://github.com/apache/druid/pull/9422#discussion_r448544157
##
File path:
processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the
gianm commented on pull request #10082:
URL: https://github.com/apache/druid/pull/10082#issuecomment-652576873
> @gianm thanks for the review. As Travis is extremely slow recently, I'd
like to address your last comments in a follow-up with doc for the known issue
with response context not
jihoonson commented on pull request #10082:
URL: https://github.com/apache/druid/pull/10082#issuecomment-652572586
@gianm thanks for the review. As Travis is extremely slow recently, I'd like
to address your last comments in a follow-up with doc for the known issue with
response context
gianm commented on pull request #10082:
URL: https://github.com/apache/druid/pull/10082#issuecomment-652569145
Btw, if you can do the above two things (and add integration tests) in
follow-ups before the next release, I think that would be OK. Let us know what
you prefer @jihoonson.
gianm commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448525940
##
File path:
processing/src/main/java/org/apache/druid/query/QueryInterruptedException.java
##
@@ -105,6 +106,8 @@ private static String
damnMeddlingKid commented on issue #10072:
URL: https://github.com/apache/druid/issues/10072#issuecomment-652560849
Thanks Gian, I'll refactor it and put up a PR.
This is an automated message from the Apache Git Service.
To
gianm edited a comment on issue #10072:
URL: https://github.com/apache/druid/issues/10072#issuecomment-652550179
Ah, it's possible both cases (nullable and non-nullable) would be covered by
existing tests, but if not, please add enough tests to cover both to
CalciteQueryTest.
gianm commented on issue #10072:
URL: https://github.com/apache/druid/issues/10072#issuecomment-652550179
It's possible both cases (nullable and non-nullable) would be covered by
existing tests, but if not, please add enough tests to cover both to
CalciteQueryTest.
gianm commented on issue #10072:
URL: https://github.com/apache/druid/issues/10072#issuecomment-652548762
Hi @damnMeddlingKid,
Looks like this is a bug and you got the right fix. The logic is similar to
what's in CountSqlAggregator already, so I'd suggest extracting it to a helper
suneet-s closed pull request #10106:
URL: https://github.com/apache/druid/pull/10106
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gianm opened a new pull request #10119:
URL: https://github.com/apache/druid/pull/10119
There are two motivations:
1. Ensure that when HashJoinSegmentStorageAdapter compares its Filter
to the original one, and it is an "in" type, the comparison is by
reference and does
lgtm-com[bot] commented on pull request #10097:
URL: https://github.com/apache/druid/pull/10097#issuecomment-652489374
This pull request **fixes 1 alert** when merging
01999dae21e5d60fa5cf9344e6d0a0a30c95ace6 into
d3497a6581c69f810090f5180f1f18328b06c781 - [view on
xiangqiao123 opened a new issue #10118:
URL: https://github.com/apache/druid/issues/10118
### Affected Version
0.18.1
### Description
Suppose that an interval has more than one segment, if some segments are
deleted, then refreshing the remaining segments by refreshing
a2l007 commented on pull request #10080:
URL: https://github.com/apache/druid/pull/10080#issuecomment-652427533
Thank you for adding this!
This is an automated message from the Apache Git Service.
To respond to the message,
jihoonson commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448229976
##
File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation
jihoonson commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448229976
##
File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation
jp707049 commented on issue #10078:
URL: https://github.com/apache/druid/issues/10078#issuecomment-652285832
Great,
I will check and update here soon using your first method.
Thanks :)
This is an automated message from
FrankChen021 commented on issue #10078:
URL: https://github.com/apache/druid/issues/10078#issuecomment-652251590
I checked the `run-druid` file, putting environment variables in
`jvm.config` won't take effect.
But you can try the first method I mention above, that is putting
clintropolis opened a new pull request #10117:
URL: https://github.com/apache/druid/pull/10117
### Description
This PR fixes an issue with/modifies the behavior of closing a `Yielder`
created from a `ParallelMergeCombiningSequence` to trigger a cancellation to
immediately halt any
maytasm opened a new pull request #10116:
URL: https://github.com/apache/druid/pull/10116
Add integration tests for parquet InputFormat
### Description
Add integration tests for parquet InputFormat
This PR has:
- [x] been self-reviewed.
- [ ] using the
maytasm opened a new pull request #10115:
URL: https://github.com/apache/druid/pull/10115
Add integration tests for ORC InputFormat
### Description
Add integration tests for ORC InputFormat
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
maytasm opened a new pull request #10114:
URL: https://github.com/apache/druid/pull/10114
Add integration tests for CSV InputFormat
### Description
Add integration tests for CSV InputFormat
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
maytasm opened a new pull request #10113:
URL: https://github.com/apache/druid/pull/10113
Add integration tests for TSV InputFormat
### Description
Add integration tests for TSV InputFormat
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
FrankChen021 commented on a change in pull request #9898:
URL: https://github.com/apache/druid/pull/9898#discussion_r448150182
##
File path:
extensions-contrib/aliyun-oss-extensions/src/main/java/org/apache/druid/storage/aliyun/OssStorageDruidModule.java
##
@@ -0,0 +1,106 @@
FrankChen021 commented on a change in pull request #9898:
URL: https://github.com/apache/druid/pull/9898#discussion_r448148488
##
File path:
extensions-contrib/aliyun-oss-extensions/src/test/java/org/apache/druid/storage/aliyun/OssDataSegmentMoverTest.java
##
@@ -0,0 +1,266
maytasm opened a new pull request #10112:
URL: https://github.com/apache/druid/pull/10112
Add integration tests for Avro InputFormat
### Description
Add integration tests for Avro InputFormat
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
FrankChen021 commented on a change in pull request #9898:
URL: https://github.com/apache/druid/pull/9898#discussion_r448146198
##
File path:
integration-tests/src/test/java/org/apache/druid/tests/TestNGGroup.java
##
@@ -76,6 +76,13 @@
*/
public static final String
Fullstop000 opened a new pull request #10111:
URL: https://github.com/apache/druid/pull/10111
### Description
Remove the unsupported task types in the doc
This PR has:
- [ ] been self-reviewed.
- [ ]
maytasm opened a new pull request #10110:
URL: https://github.com/apache/druid/pull/10110
Add integration test for JSON input format
### Description
Add integration test for JSON input format
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
jihoonson commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448136240
##
File path:
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java
##
@@ -329,15 +329,18 @@ private DataSource
jihoonson commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448135794
##
File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation
jihoonson commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448136101
##
File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation
jihoonson commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448135388
##
File path:
processing/src/main/java/org/apache/druid/query/context/ResponseContext.java
##
@@ -112,6 +114,30 @@
86 matches
Mail list logo
