abhishekagarwal87 commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760715147
By the way, I did a similar thing in
https://github.com/apache/druid/pull/10304 to reduce some boilerplate code but
used composition instead of inheritance. Added
This is an automated email from the ASF dual-hosted git repository.
gian pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from 7354953 VectorMatch: Disallow "copyFrom", "addAll" on self; improve
tests. (#10755)
add a82910e OrFilter:
gianm merged pull request #10754:
URL: https://github.com/apache/druid/pull/10754
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gianm opened a new pull request #10767:
URL: https://github.com/apache/druid/pull/10767
Also a refactoring of BufferAggregator and VectorAggregator such that
they share a common interface, BaseBufferAggregator. This allows
implementing both in the same file with an abstract + dual
clintropolis commented on a change in pull request #10688:
URL: https://github.com/apache/druid/pull/10688#discussion_r557891831
##
File path: .travis.yml
##
@@ -154,7 +154,7 @@ jobs:
# Set MAVEN_OPTS for Surefire launcher. Skip remoteresources to avoid
intermittent
clintropolis commented on pull request #10412:
URL: https://github.com/apache/druid/pull/10412#issuecomment-760677409
hmm, it looks like the commits have become sort of messed up for this PR one
way or another and github is showing a lot of unrelated commits. @Tiaaa any
chance you can try
zhangyue19921010 commented on a change in pull request #10688:
URL: https://github.com/apache/druid/pull/10688#discussion_r557884345
##
File path: .travis.yml
##
@@ -154,7 +154,7 @@ jobs:
# Set MAVEN_OPTS for Surefire launcher. Skip remoteresources to avoid
zhangyue19921010 commented on a change in pull request #10688:
URL: https://github.com/apache/druid/pull/10688#discussion_r557884345
##
File path: .travis.yml
##
@@ -154,7 +154,7 @@ jobs:
# Set MAVEN_OPTS for Surefire launcher. Skip remoteresources to avoid
clintropolis commented on a change in pull request #10688:
URL: https://github.com/apache/druid/pull/10688#discussion_r557882013
##
File path: .travis.yml
##
@@ -154,7 +154,7 @@ jobs:
# Set MAVEN_OPTS for Surefire launcher. Skip remoteresources to avoid
intermittent
abhishekagarwal87 commented on pull request #10766:
URL: https://github.com/apache/druid/pull/10766#issuecomment-760662800
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please
michaelschiff commented on a change in pull request #10412:
URL: https://github.com/apache/druid/pull/10412#discussion_r557865992
##
File path:
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java
##
@@ -0,0 +1,153 @@
michaelschiff commented on a change in pull request #10412:
URL: https://github.com/apache/druid/pull/10412#discussion_r557865992
##
File path:
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java
##
@@ -0,0 +1,153 @@
michaelschiff commented on pull request #10412:
URL: https://github.com/apache/druid/pull/10412#issuecomment-760648631
@Tiaaa awesome! I see peon metrics in pushgateway as well.
https://user-images.githubusercontent.com/1669670/104682480-a0131900-56a9-11eb-8817-3dea4d0b3b0d.png;>
clintropolis opened a new pull request #10766:
URL: https://github.com/apache/druid/pull/10766
Extra tests I wrote that didn't make it into #10743 before it got merged
This is an automated message from the Apache Git
Tiaaa commented on pull request #10412:
URL: https://github.com/apache/druid/pull/10412#issuecomment-760624945
Verification of metrics on a local mini druid cluster as shown in below
table.
Coordinator, historical, broker, router, middle-manager, overlord set up as
prometheus
This is an automated email from the ASF dual-hosted git repository.
suneet pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git.
from 4437c6a use actual dataInterval in cache key (#10714)
add e52db19 treat null as not defined (#10751)
No new
suneet-s merged pull request #10751:
URL: https://github.com/apache/druid/pull/10751
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
suneet-s commented on pull request #10751:
URL: https://github.com/apache/druid/pull/10751#issuecomment-760601305
@jihoonson I think this should be added to 0.21.0. I've added the milestone,
feel free to remove the milestone if you disagree
jihoonson commented on pull request #10751:
URL: https://github.com/apache/druid/pull/10751#issuecomment-760615444
@suneet-s makes sense to me.
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 7354953 VectorMatch: Disallow "copyFrom",
gianm merged pull request #10755:
URL: https://github.com/apache/druid/pull/10755
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 2bbf89d Remove FalseVectorMatcher,
gianm merged pull request #10757:
URL: https://github.com/apache/druid/pull/10757
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
FrankChen021 commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760587384
> @FrankChen021 Any thoughts on this? Thanks for your time.
Based on my knowledge, I think this problem is more related to redis cluster
itself and I have no idea what
jihoonson commented on issue #10752:
URL: https://github.com/apache/druid/issues/10752#issuecomment-760575610
Thanks. That sounds good :slightly_smiling_face:
This is an automated message from the Apache Git Service.
To
himanshug commented on issue #10752:
URL: https://github.com/apache/druid/issues/10752#issuecomment-760562141
sure, you are the release manager :)
anyways, now that the conversation is here in this issue, power users would
likely note the upcoming improvements. however, by that time
loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r55778
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##
@@ -398,22 +375,21 @@ private
loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r557784750
##
File path:
indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopDruidIndexerConfig.java
##
@@ -314,9 +313,9 @@ public void
loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r55778
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##
@@ -398,22 +375,21 @@ private
jihoonson commented on issue #10752:
URL: https://github.com/apache/druid/issues/10752#issuecomment-760555607
> that said, I think, 0.21.0 should continue to go on its schedule. For that
reason, I think we should remove the mention of this new feature in 0.21.0
release notes and we can
himanshug edited a comment on issue #10752:
URL: https://github.com/apache/druid/issues/10752#issuecomment-760547707
hey @jihoonson , I am very excited about `Service discovery and leader
election based on Kubernetes` but I am in the process of writing a PR that runs
#10680 for k8s based
himanshug commented on issue #10752:
URL: https://github.com/apache/druid/issues/10752#issuecomment-760547707
hey @jihoonson , I am very excited about `Service discovery and leader
election based on Kubernetes` but I am in the process of writing a PR that runs
#10680 for k8s based
himanshug commented on pull request #10524:
URL: https://github.com/apache/druid/pull/10524#issuecomment-760533912
As I am going through the code, I notice, overall the patch does
following
(1) periodically update lag statistics in the background
(2) periodically trigger the
suneet-s commented on pull request #10751:
URL: https://github.com/apache/druid/pull/10751#issuecomment-760529823
I've re-triggered the flaky tests 爛
This is an automated message from the Apache Git Service.
To respond to
misqos opened a new pull request #10765:
URL: https://github.com/apache/druid/pull/10765
### Description
Add the ability to supply client certificate to dsql command line tool.
If the server is configured to do mutual SSL auth, there is no way of making
clintropolis commented on a change in pull request #10763:
URL: https://github.com/apache/druid/pull/10763#discussion_r557725191
##
File path: integration-tests/README.md
##
@@ -70,6 +74,28 @@ The file must contain one property per line, the key must
start with `druid_` an
xvrl opened a new pull request #10764:
URL: https://github.com/apache/druid/pull/10764
except success and failure stats, task count metrics should all be
gauges, since they represent the current state and not some aggregate
counter over time.
Karthikeyantkr edited a comment on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760473363
I am seeing this message now when I restart the broker. Broker log:
```
2021-01-14T20:56:13,304 WARN [DruidSchema-Cache-0]
Karthikeyantkr edited a comment on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760477607
This error in historical node :
```
2021-01-14T20:56:13,647 WARN
[segmentMetadata_dsp_media_and_bids_[2020-08-09T09:00:00.000Z/2020-08-09T10:00:00.000Z]]
Karthikeyantkr commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760477607
This error in historical node : ```
2021-01-14T20:56:13,647 WARN
[segmentMetadata_dsp_media_and_bids_[2020-08-09T09:00:00.000Z/2020-08-09T10:00:00.000Z]]
Karthikeyantkr commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760474818
@FrankChen021 Any thoughts on this? Thanks for your time.
This is an automated message from the Apache Git
Karthikeyantkr edited a comment on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760472690
>
Karthikeyantkr commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760474355
1) I don't see an error message every time when I run a query. (Since the
Redis was not connected at startup itself)
2) Redis version : redis-cli 6.0.5
Karthikeyantkr commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760473363
I am seeing this message now when I restart the broker.
```
2021-01-14T20:56:13,304 WARN [DruidSchema-Cache-0]
org.apache.druid.client.cache.AbstractRedisCache -
Karthikeyantkr commented on issue #10753:
URL: https://github.com/apache/druid/issues/10753#issuecomment-760472690
jihoonson edited a comment on pull request #10677:
URL: https://github.com/apache/druid/pull/10677#issuecomment-760395019
@nishantmonu51 sorry to say, but I created a release branch yesterday. As
this PR is unlikely backported (it's a feature and we backport only bug fixes
since features
jihoonson commented on pull request #10677:
URL: https://github.com/apache/druid/pull/10677#issuecomment-760395019
@nishantmonu51 sorry to say, but I created a release branch yesterday. As
this PR is unlikely backported (it's a feature and we backport only bug fixes
since features can
loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r557576226
##
File path:
server/src/main/java/org/apache/druid/segment/indexing/LookupIntervalBuckets.java
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r557576226
##
File path:
server/src/main/java/org/apache/druid/segment/indexing/LookupIntervalBuckets.java
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
loquisgon opened a new pull request #10763:
URL: https://github.com/apache/druid/pull/10763
Add a troubleshooting note for the case when RSA generation fails because
using a DNS that returns IP addresses for unresolved domains.
This PR has:
- [X ] been self-reviewed.
smit-aterlo commented on pull request #8223:
URL: https://github.com/apache/druid/pull/8223#issuecomment-760213468
These functions are really useful. Is there any plan to add IPv6 functions
as well?
This is an automated
zhangyue19921010 commented on pull request #10524:
URL: https://github.com/apache/druid/pull/10524#issuecomment-760194424
@suneet-s Sure, will do it :)
This is an automated message from the Apache Git Service.
To respond to
maytasm commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r557248198
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##
@@ -398,22 +375,21 @@ private boolean
abhishekagarwal87 commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r557231606
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##
@@ -578,6 +578,10
54 matches
Mail list logo
