Re: [PR] Add retries to handle connection reset errors for GZIPInputStream (druid)

2024-06-16 Thread via GitHub
Akshat-Jain commented on PR #16606: URL: https://github.com/apache/druid/pull/16606#issuecomment-2172412274 > Does it mean that when the server is disconnected, the inner input stream is working fine (and returning partial data), however the wrapping GZ stream is throwing because the data i

Re: [PR] Add retries to handle connection reset errors for GZIPInputStream (druid)

2024-06-16 Thread via GitHub
LakshSingla commented on PR #16606: URL: https://github.com/apache/druid/pull/16606#issuecomment-2172405545 > But this particular error Unexpected end of ZLIB input stream is for gz file only I don't think we need to solve for the error, but we are adding the missing retries. The err

Re: [PR] Add retries to handle connection reset errors for GZIPInputStream (druid)

2024-06-16 Thread via GitHub
Akshat-Jain commented on PR #16606: URL: https://github.com/apache/druid/pull/16606#issuecomment-2172382548 @LakshSingla I haven't tried it out. But this particular error `Unexpected end of ZLIB input stream` is for gz file only. The problem was that we were wrapping the RetryingInputStream

Re: [PR] Add retries to handle connection reset errors for GZIPInputStream (druid)

2024-06-16 Thread via GitHub
LakshSingla commented on PR #16606: URL: https://github.com/apache/druid/pull/16606#issuecomment-2172371162 This error doesn't seem limited to the GZIPInputStream. What will happen if you retry the experiment, but not with a .gz file? Do we still retry in that case? -- This is an autom

Re: [PR] Fix complex columns with export (druid)

2024-06-16 Thread via GitHub
LakshSingla commented on code in PR #16572: URL: https://github.com/apache/druid/pull/16572#discussion_r164664 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/results/ExportResultsFrameProcessor.java: ## @@ -167,9 +175,22 @@ private void expo

(druid-website-src) 01/01: Merge pull request #480 from adarshsanjeev/30.0.0-docs

2024-06-16 Thread adarshsanjeev
This is an automated email from the ASF dual-hosted git repository. adarshsanjeev pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid-website-src.git commit 04e7c211e82ab3b96d2bd1079a74fecbcc30946c Merge: dd4219cba 031645647 Author: Adarsh Sanjeev AuthorDate:

Re: [PR] Update site for Druid 30 [druid-website-src]

2024-06-16 Thread via GitHub
adarshsanjeev merged PR #480: URL: https://github.com/apache/druid-website-src/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

Re: [PR] Window range - corner case of offset equals to window size (druid)

2024-06-16 Thread via GitHub
sreemanamala closed pull request #16348: Window range - corner case of offset equals to window size URL: https://github.com/apache/druid/pull/16348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] handling window frame selection in case of same bound kind (druid)

2024-06-16 Thread via GitHub
sreemanamala closed pull request #16231: handling window frame selection in case of same bound kind URL: https://github.com/apache/druid/pull/16231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Fix window output column name for aggregators (druid)

2024-06-16 Thread via GitHub
sreemanamala opened a new pull request, #16615: URL: https://github.com/apache/druid/pull/16615 ### Description In case of few aggregators for example BloomSqlAggregator, BaseVarianceSqlAggregator etc, the aggName is being updated `w0 to w0:agg`. This

(druid-website) 01/01: Merge pull request #278 from adarshsanjeev/30.0.0-docs

2024-06-16 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/druid-website.git commit acc45d3c4b6cb938814469d21336a1e6eb8cc6e1 Merge: 0c7336451 869cb2811 Author: Karan Kumar AuthorDate: Mon Jun 17 0

Re: [PR] Update site for Druid 30 [druid-website]

2024-06-16 Thread via GitHub
cryptoe merged PR #278: URL: https://github.com/apache/druid-website/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.

Re: [PR] Improve retry log messages in integration tests (druid)

2024-06-16 Thread via GitHub
github-actions[bot] commented on PR #14664: URL: https://github.com/apache/druid/pull/14664#issuecomment-2171956273 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. -

Re: [PR] Improve retry log messages in integration tests (druid)

2024-06-16 Thread via GitHub
github-actions[bot] closed pull request #14664: Improve retry log messages in integration tests URL: https://github.com/apache/druid/pull/14664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] docs: Update Azure extension (druid)

2024-06-16 Thread via GitHub
amaechler commented on PR #16585: URL: https://github.com/apache/druid/pull/16585#issuecomment-2171747474 Thanks for the detailed feedback @vtlim. I have addressed your comments now. Ready for another round! 🙇 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] docs: Update Azure extension (druid)

2024-06-16 Thread via GitHub
amaechler commented on code in PR #16585: URL: https://github.com/apache/druid/pull/16585#discussion_r1641907364 ## docs/configuration/index.md: ## @@ -670,14 +670,9 @@ Store task logs in S3. Note that the `druid-s3-extensions` extension must be loa # Azure Blob Store ta

Re: [PR] Fix replica task failures with metadata inconsistency while running concurrent append replace (druid)

2024-06-16 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16614: URL: https://github.com/apache/druid/pull/16614#discussion_r1641898566 ## server/src/main/java/org/apache/druid/segment/realtime/appenderator/BaseAppenderatorDriver.java: ## @@ -558,15 +559,7 @@ return Futures.