[GitHub] [druid] jihoonson commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-25 Thread GitBox
jihoonson commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649804890 > If those unit tests had been in `core` instead of `server` then the coverage check for this PR would have passed since the relevant unit tests were added to

[GitHub] [druid] jihoonson commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-24 Thread GitBox
jihoonson commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649222738 ``` 133 F default boolean sharePartitionSpace(PartialShardSpec partialShardSpec) 134 F { 135 F | L | B(0/2)return