[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-20 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267602505 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-20 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267598907 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267156636 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267163198 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ## @@ -70,9

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267163198 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ## @@ -70,9

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r26714 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r26714 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267144903 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-19 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267139172 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-15 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r266172262 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java ## @@ -36,26 +40,88 @@ pub

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-15 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r266170777 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java ## @@ -36,26 +40,88 @@ pub

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-08 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263972589 ## File path: docs/content/querying/scan-query.md ## @@ -194,3 +194,11 @@ Legacy mode can be triggered either b

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263628213 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ## @@ -19,35

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263625061 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ## @@ -70,9

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263640043 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263618624 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java ## @@ -123,15 +123,18

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263622889 ## File path: docs/content/querying/scan-query.md ## @@ -194,3 +194,11 @@ Legacy mode can be triggered either b

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263617590 ## File path: docs/content/querying/scan-query.md ## @@ -168,18 +148,38 @@ The format of the result when result

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263639613 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java ## @@ -68,34 +8

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans

2019-03-07 Thread GitBox
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263622464 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java ## @@ -36,26 +39,88 @@ pub