adamsaghy merged PR #5081:
URL: https://github.com/apache/fineract/pull/5081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
adamsaghy commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2409812371
##
fineract-loan/src/main/resources/db/changelog/tenant/module/loan/parts/1033_add_reage_reasons_for_loan.xml:
##
@@ -0,0 +1,47 @@
+
+
+http://www.liquibase.org/xml/
vidakovic commented on code in PR #5037:
URL: https://github.com/apache/fineract/pull/5037#discussion_r2408205151
##
fineract-provider/src/main/java/org/apache/fineract/commands/api/MakercheckersApiResource.java:
##
@@ -77,13 +81,10 @@ public List retrieveCommands(@Context final
galovics merged PR #5058:
URL: https://github.com/apache/fineract/pull/5058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract
Lymah123 commented on PR #4623:
URL: https://github.com/apache/fineract/pull/4623#issuecomment-3369802767
> > Additional issues:
> >
> > * Liquibase scripts are missing (to add the new column to the savings
account transaction database table)
> > * Testing is missing
> > * Addin
kengneruphine commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3366976567
@galovics, @adamsaghy, please could this PR be merged? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
peter-kovacs-dpc opened a new pull request, #5075:
URL: https://github.com/apache/fineract/pull/5075
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://issues.apach
steinwinde opened a new pull request, #5076:
URL: https://github.com/apache/fineract/pull/5076
## Description
This is a general overhaul of the existing README page: Corrects many
details, removes sections, adds structure and a
## Checklist
Please make sure these boxes are
bharathcgowda commented on PR #5038:
URL: https://github.com/apache/fineract/pull/5038#issuecomment-3364303806
@adamsaghy could you please help in review of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
adamsaghy commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2389098513
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/reaging/LoanReAgeInterestHandlingType.java:
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to
adamsaghy opened a new pull request, #5068:
URL: https://github.com/apache/fineract/pull/5068
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
adamsaghy commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2375741684
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/reaging/LoanReAgeInterestHandlingType.java:
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to
adamsaghy merged PR #5023:
URL: https://github.com/apache/fineract/pull/5023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
galovics merged PR #5073:
URL: https://github.com/apache/fineract/pull/5073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract
bharathcgowda commented on PR #5038:
URL: https://github.com/apache/fineract/pull/5038#issuecomment-3361636667
@sidshas03 one check is failing, could you please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
bharathcgowda commented on PR #4793:
URL: https://github.com/apache/fineract/pull/4793#issuecomment-3361634367
@sidshas03 @adamsaghy anything pending to be done on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dependabot[bot] opened a new pull request, #5074:
URL: https://github.com/apache/fineract/pull/5074
Bumps [gradle/actions](https://github.com/gradle/actions) from 4 to 5.
Release notes
Sourced from https://github.com/gradle/actions/releases";>gradle/actions's
releases.
v5.0.
adamsaghy opened a new pull request, #5073:
URL: https://github.com/apache/fineract/pull/5073
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
alberto-art3ch opened a new pull request, #5072:
URL: https://github.com/apache/fineract/pull/5072
## Description
Currently, the ‘Losses Written-off' Accounting GL mapping is debited in case
a loan got written-off .
This need to be extended now based on the Write-off reasons (i
adamsaghy commented on PR #5068:
URL: https://github.com/apache/fineract/pull/5068#issuecomment-3357955985
@galovics Thank you for your feedback! Kindly asking you to take a look on
it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
adamsaghy commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3357958362
> Hello @galovics, I think the fact that "Bitnami has stopped publishing new
Docker images for Apache Kafka" as mentioned by Adam Saghy in the mailing list
is causing the test here to
adamsaghy commented on code in PR #5068:
URL: https://github.com/apache/fineract/pull/5068#discussion_r2395703882
##
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobConfiguration.java:
##
@@ -0,0 +1,141 @@
adamsaghy commented on code in PR #5068:
URL: https://github.com/apache/fineract/pull/5068#discussion_r2395701010
##
fineract-provider/src/main/resources/application.properties:
##
@@ -71,6 +71,11 @@
fineract.correlation.header-name=${FINERACT_LOGGING_HTTP_CORRELATION_ID_HEADER
adamsaghy commented on code in PR #5068:
URL: https://github.com/apache/fineract/pull/5068#discussion_r2395646206
##
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobReader.java:
##
@@ -0,0 +1,126 @@
+/**
+
adamsaghy merged PR #5065:
URL: https://github.com/apache/fineract/pull/5065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
alberto-art3ch closed pull request #5069: FINERACT-2358: Advance Accounting
rule for write-off reason
URL: https://github.com/apache/fineract/pull/5069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
kengneruphine commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3357156064
Hello @galovics, I think the fact that "Bitnami has stopped publishing new
Docker images for Apache Kafka" as mentioned by Adam Saghy in the mailing list
is causing the test here t
adamsaghy opened a new pull request, #5071:
URL: https://github.com/apache/fineract/pull/5071
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
alberto-art3ch opened a new pull request, #5070:
URL: https://github.com/apache/fineract/pull/5070
## Description
Currently Fineract is not handling the Flat-Cumulative-Multi Disbursement
configuration laan account schedule calculation correctly and has a validation
at loan product l
adamsaghy merged PR #5029:
URL: https://github.com/apache/fineract/pull/5029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
ruzeynalov commented on code in PR #5067:
URL: https://github.com/apache/fineract/pull/5067#discussion_r2391370013
##
fineract-doc/src/docs/en/chapters/testing/cucumber.adoc:
##
@@ -1,6 +1,553 @@
[[testing-cucumber]]
-= Cucumber
+= Cucumber E2E Tests
-TBD
+Apache Fineract's E
budaidev commented on code in PR #5067:
URL: https://github.com/apache/fineract/pull/5067#discussion_r2391400815
##
fineract-doc/src/docs/en/chapters/testing/cucumber.adoc:
##
@@ -1,6 +1,553 @@
[[testing-cucumber]]
-= Cucumber
+= Cucumber E2E Tests
-TBD
+Apache Fineract's E2E
adamsaghy opened a new pull request, #5066:
URL: https://github.com/apache/fineract/pull/5066
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
adamsaghy merged PR #5066:
URL: https://github.com/apache/fineract/pull/5066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
kengneruphine commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3347619399
@galovics, done that. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
galovics commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3345215657
@kengneruphine the commit should also have the title "FINERACT-2359: blah
blah"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
kapil-panchal commented on code in PR #5035:
URL: https://github.com/apache/fineract/pull/5035#discussion_r2378290873
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/repository/CollectionSheetDao.java:
##
@@ -0,0 +1,283 @@
+/**
+ * Licensed to th
github-actions[bot] commented on PR #4623:
URL: https://github.com/apache/fineract/pull/4623#issuecomment-3342139740
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
--
This is an automated message from the Apache Git
github-actions[bot] closed pull request #4878: FINERACT-2234: Add COB
performance test scenarios
URL: https://github.com/apache/fineract/pull/4878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #4939:
URL: https://github.com/apache/fineract/pull/4939#issuecomment-3342139703
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
--
This is an automated message from the Apache Git
kengneruphine commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3341550697
Hello @adamsaghy, @galovics,
could you please review this PR? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
kengneruphine commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3341986080
@galovics, the requested changes have been made. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kengneruphine commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3341705878
@galovics thank you for the review.
I think the Fineract tick number
([FINERACT-1234](https://issues.apache.org/jira/browse/FINERACT-1234) is not
the one for this issue
--
Th
galovics merged PR #5060:
URL: https://github.com/apache/fineract/pull/5060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract
galovics commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3341703887
Oh and make sure to reformat your code, use `./gradlew spotlessApply` right
before committing.
--
This is an automated message from the Apache Git Service.
To respond to the message,
galovics commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3341703590
@kengneruphine this looks good to make, few things though:
- Name the PR properly with the Fineract ticket number (FINERACT-1234)
- Squash your commits into a single one and prefix
pwairuru closed pull request #5062: 1.12.0 finmis
URL: https://github.com/apache/fineract/pull/5062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: comm
pwairuru opened a new pull request, #5062:
URL: https://github.com/apache/fineract/pull/5062
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
meonkeys commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3341013172
Sorry no, I don't know this area of the codebase well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
danielales2541 closed pull request #5030: FINERACT-2376: Unable to re-invest
maturity amount or principal for fixed deposit at closing
URL: https://github.com/apache/fineract/pull/5030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
adamsaghy merged PR #5057:
URL: https://github.com/apache/fineract/pull/5057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
JohnAlva opened a new pull request, #5059:
URL: https://github.com/apache/fineract/pull/5059
## Description
Integration test started to fail:
org.apache.fineract.integrationtests.SchedulerJobsTestResults#testInterestTransferForSavings
Test result
org.opentest
adamsaghy commented on PR #4793:
URL: https://github.com/apache/fineract/pull/4793#issuecomment-3324180565
```
* What went wrong:
Execution failed for task ':fineract-savings:spotlessJavaCheck'.
> The following files had format violations:
src/main/java/org/apache/fineract/
kapil-panchal commented on code in PR #5034:
URL: https://github.com/apache/fineract/pull/5034#discussion_r2376006275
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/service/CollectionSheetWritePlatformServiceJpaRepositoryImpl.java:
##
@@ -142,7
adamsaghy commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2375693019
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ReprocessLoanTransactionsServiceImpl.java:
##
@@ -219,7 +217,7 @@ private Change
adamsaghy commented on PR #5044:
URL: https://github.com/apache/fineract/pull/5044#issuecomment-3324293937
@somasorosdpc Please check the failing tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] closed pull request #4858: FINERACT-2290: New command
processing - Collection Sheet (org.apache.fineract.portfolio.collectionsheet)
URL: https://github.com/apache/fineract/pull/4858
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
Aman-Mittal commented on code in PR #4979:
URL: https://github.com/apache/fineract/pull/4979#discussion_r2375672025
##
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##
@@ -784,4 +780,11 @@ public int hashCode() {
return Objects.h
kapil-panchal commented on PR #5034:
URL: https://github.com/apache/fineract/pull/5034#issuecomment-3328836764
Will raise a new pull request with code review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
kengneruphine commented on PR #5058:
URL: https://github.com/apache/fineract/pull/5058#issuecomment-3335631592
Hello @meonkeys, could you please review this PR? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kengneruphine opened a new pull request, #5058:
URL: https://github.com/apache/fineract/pull/5058
## Description
Added the dayInYear variable as a parameter to the aprCalculator function
used in calculating interest
[Fineract 2359](https://issues.apache.org/jira/browse/FINERACT
adamsaghy opened a new pull request, #5057:
URL: https://github.com/apache/fineract/pull/5057
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
alberto-art3ch commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2376323384
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/reaging/LoanReAgeInterestHandlingType.java:
##
@@ -0,0 +1,46 @@
+/**
+ * License
meonkeys merged PR #5051:
URL: https://github.com/apache/fineract/pull/5051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract
meonkeys commented on PR #5051:
URL: https://github.com/apache/fineract/pull/5051#issuecomment-3334353807
@kengneruphine please squash this PR into a single commit and rebase on
`develop`, then I'll fast-forward merge it. We don't need to wait for the
checks to finish since this PR only tou
kapil-panchal opened a new pull request, #5056:
URL: https://github.com/apache/fineract/pull/5056
## Description
Describe the changes made and why they were made.
Added changes as per the code review comments. Refer #5034.
Ignore if these details are present on the associ
adamsaghy commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2375048750
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##
@@ -300,6 +300,8 @@ private PostLoanProductsRequ
adamsaghy opened a new pull request, #5055:
URL: https://github.com/apache/fineract/pull/5055
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
kapil-panchal commented on PR #5035:
URL: https://github.com/apache/fineract/pull/5035#issuecomment-3332919813
I will implement the code review comments and raise another pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kapil-panchal closed pull request #5035: FINERACT-2361: Collection Sheet -
[Refactor] - Generate Collection Sheet - Individual Collection Sheet
URL: https://github.com/apache/fineract/pull/5035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
somasorosdpc commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2378245945
##
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##
@@ -220,13 +220,34 @@
somasorosdpc commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2378244997
##
fineract-provider/src/main/resources/db/changelog/tenant/parts/0198_write_off_reason_mapping_loan.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://www.liquibase.org/xml/ns
galovics merged PR #5011:
URL: https://github.com/apache/fineract/pull/5011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract
dependabot[bot] opened a new pull request, #5054:
URL: https://github.com/apache/fineract/pull/5054
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.4 to 4.3.0.
Release notes
Sourced from https://github.com/actions/cache/releases";>actions/cache's
releases.
v
meonkeys commented on code in PR #5051:
URL: https://github.com/apache/fineract/pull/5051#discussion_r2377065170
##
README.md:
##
@@ -69,6 +69,20 @@ Run the following commands:
1. `./gradlew createDB -PdbName=fineract_default`
1. `./gradlew devRun`
+Fineract is now running,
adamsaghy merged PR #5049:
URL: https://github.com/apache/fineract/pull/5049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
alberto-art3ch commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2376325943
##
fineract-loan/src/main/resources/db/changelog/tenant/module/loan/parts/1033_add_reage_reasons_for_loan.xml:
##
@@ -0,0 +1,53 @@
+
+
+http://www.liquibase.org
alberto-art3ch commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2376308504
##
fineract-loan/src/main/resources/db/changelog/tenant/module/loan/parts/1033_add_reage_reasons_for_loan.xml:
##
@@ -0,0 +1,53 @@
+
+
+http://www.liquibase.org
adamsaghy commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2375744160
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTransactionData.java:
##
@@ -116,6 +118,10 @@ public class LoanTransactionData impl
adamsaghy commented on code in PR #5046:
URL: https://github.com/apache/fineract/pull/5046#discussion_r2375749255
##
fineract-loan/src/main/resources/db/changelog/tenant/module/loan/parts/1033_add_reage_reasons_for_loan.xml:
##
@@ -0,0 +1,53 @@
+
+
+http://www.liquibase.org/xml/
adamsaghy commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2375709238
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java:
##
@@ -2109,6 +2111,58 @@ private void vali
adamsaghy commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2375709926
##
fineract-provider/src/main/resources/db/changelog/tenant/parts/0198_write_off_reason_mapping_loan.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://www.liquibase.org/xml/ns/db
adamsaghy commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2375701998
##
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##
@@ -514,6 +594,26 @@ pri
adamsaghy commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2375704117
##
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##
@@ -577,12 +677,46 @@ pu
adamsaghy commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2375697605
##
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##
@@ -220,13 +220,34 @@ pu
adamsaghy commented on code in PR #5044:
URL: https://github.com/apache/fineract/pull/5044#discussion_r2375695278
##
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##
@@ -220,13 +220,34 @@ pu
adamsaghy commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2375690826
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ReprocessLoanTransactionsServiceImpl.java:
##
@@ -147,28 +145,28 @@ &&
doesLoan
Aman-Mittal commented on PR #4979:
URL: https://github.com/apache/fineract/pull/4979#issuecomment-3328252117
@adamsaghy Please rerun workflow and review my changes again.
Workflow run crosschecked at my forked branch
https://github.com/Aman-Mittal/fineract/commit/b478abcb8b429cd35
adamsaghy commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2375678964
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/InterestScheduleModelRepositoryWrapperImpl.java:
##
@@ -111,7 +112,8 @@
Aman-Mittal commented on code in PR #4979:
URL: https://github.com/apache/fineract/pull/4979#discussion_r2375675380
##
fineract-accounting/src/main/java/org/apache/fineract/accounting/closure/api/GLClosuresApiResource.java:
##
@@ -89,10 +88,14 @@ public List
retrieveAllClosures
adamsaghy commented on PR #5034:
URL: https://github.com/apache/fineract/pull/5034#issuecomment-3328242583
@kapil-panchal Can you please write some testing for this to ensure the
changed behaviour is the correct one?
--
This is an automated message from the Apache Git Service.
To respond
adamsaghy commented on PR #5029:
URL: https://github.com/apache/fineract/pull/5029#issuecomment-3328227612
@somasorosdpc Please rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
adamsaghy merged PR #5032:
URL: https://github.com/apache/fineract/pull/5032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@finerac
adamsaghy commented on code in PR #5029:
URL: https://github.com/apache/fineract/pull/5029#discussion_r2375620794
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
#
adamsaghy commented on code in PR #5029:
URL: https://github.com/apache/fineract/pull/5029#discussion_r2375610365
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
#
adamsaghy commented on code in PR #5029:
URL: https://github.com/apache/fineract/pull/5029#discussion_r2375606177
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
#
adamsaghy commented on PR #5051:
URL: https://github.com/apache/fineract/pull/5051#issuecomment-3326838819
> Thanks for your patch, @kengneruphine !
>
> Please also review https://github.com/apache/fineract#pull-requests ...
you need to create a JIRA ticket. Every Apache Fineract GitH
steinwinde commented on code in PR #5051:
URL: https://github.com/apache/fineract/pull/5051#discussion_r2374619829
##
README.md:
##
@@ -69,6 +69,9 @@ Run the following commands:
1. `./gradlew createDB -PdbName=fineract_default`
1. `./gradlew devRun`
+Fineract is running at h
steinwinde commented on code in PR #5051:
URL: https://github.com/apache/fineract/pull/5051#discussion_r2374618147
##
README.md:
##
@@ -69,6 +69,9 @@ Run the following commands:
1. `./gradlew createDB -PdbName=fineract_default`
1. `./gradlew devRun`
+Fineract is running at h
meonkeys commented on PR #5051:
URL: https://github.com/apache/fineract/pull/5051#issuecomment-3325827126
Thanks for your patch, @kengneruphine !
Please also review https://github.com/apache/fineract#pull-requests ... you
need to create a JIRA ticket. Every Apache Fineract GitHub PR h
1 - 100 of 6921 matches
Mail list logo
