RE: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35187 - explicitly set default border to none, so viewports can ignore non-existent borders.

2016-11-29 Thread Yishay Weiss
I ended up taking a different approach because changing the default border style exposed a different bug in FlexJS [1] [1] https://issues.apache.org/jira/browse/FLEX-35189 From: Yishay Weiss<mailto:yishayj...@hotmail.com> Sent: Tuesday, November 29, 2016 8:53 AM To: d...@flex.apac

RE: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35187 - explicitly set default border to none, so viewports can ignore non-existent borders.

2016-11-28 Thread Yishay Weiss
‘none’ is the default value of border-style, so it shouldn’t affect rendering. The problem was in CSSContainerUtils.getBorderMetrics(): var borderStyle:Object = ValuesManager.valuesImpl.getValue(object, "border-style"); borderStyle was evaluated in JS to undefined and the condition that f

RE: git commit: [flex-asjs] [refs/heads/develop] - Don't let order of bead addition confuse collapse bead.

2016-11-28 Thread Yishay Weiss
This is a form of lazy loading. We’re not baking in any new dependencies that weren’t there before. If you look in ContainerView.performLayout(), for example, you’ll see it’s doing the same thing. Some beads rely on other beads to already be loaded, this code essentially makes sure that the d