Re: [PR] [VL] Support array transform function [incubator-gluten]

2024-04-22 Thread via GitHub
Yohahaha commented on PR #5410: URL: https://github.com/apache/incubator-gluten/pull/5410#issuecomment-2071456999 @liujiayi771 please help take a look, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [VL] Enable remaining passed 3.5 UT [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494#issuecomment-2071455986 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4836][VL]Add support for WindowGroupLimitExec in gluten [incubator-gluten]

2024-04-22 Thread via GitHub
JkSelf commented on PR #5398: URL: https://github.com/apache/incubator-gluten/pull/5398#issuecomment-2071439131 @ayushi-agarwal Can you help to fix the following compile error in clickhouse backend? ``` 17:47:31 [INFO] --- scala-maven-plugin:4.8.0:compile (scala-compile-first)

Re: [PR] [VL] Enable remaining passed 3.5 UT [incubator-gluten]

2024-04-22 Thread via GitHub
yma11 commented on PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494#issuecomment-2071433407 > Thank you! @gaoyangxiaozhu . @yma11 Can you confirm? Hi @FelixYBW these are the failures happens in the ones we copied from Spark3.4. The gaps are not filled yet. I will

Re: [PR] [VL] Improve checkNativeWrite in VeloxParquetWriteForHiveSuite [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5496: URL: https://github.com/apache/incubator-gluten/pull/5496#issuecomment-2071418381 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] UDF: Support variable arity in function sigatures [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5495: URL: https://github.com/apache/incubator-gluten/pull/5495#issuecomment-2071407030 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

(incubator-gluten) branch main updated: [VL][DOC] Separate udf doc (#5475)

2024-04-22 Thread marong
This is an automated email from the ASF dual-hosted git repository. marong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 7c024157c [VL][DOC] Separate udf doc

Re: [PR] [VL][DOC] Separate udf doc [incubator-gluten]

2024-04-22 Thread via GitHub
marin-ma merged PR #5475: URL: https://github.com/apache/incubator-gluten/pull/5475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Enable remaining passed 3.5 UT [incubator-gluten]

2024-04-22 Thread via GitHub
FelixYBW commented on PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494#issuecomment-2071367419 Thank you! @gaoyangxiaozhu . @yma11 Can you confirm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [GLUTEN-5341] Fixes SPARK-42782: Hive compatibility check for get_json_object [incubator-gluten]

2024-04-22 Thread via GitHub
zhouyuan commented on PR #5467: URL: https://github.com/apache/incubator-gluten/pull/5467#issuecomment-2071366567 CC @PHILO-HE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [CH] Fix CH CI [incubator-gluten]

2024-04-22 Thread via GitHub
liuneng1994 commented on PR #5493: URL: https://github.com/apache/incubator-gluten/pull/5493#issuecomment-2071350832 Does the singleton implementation of SparkDirectoryUtil lack the necessary thread synchronization? -- This is an automated message from the Apache Git Service. To respond

Re: [I] UT failures for Spark3.5 [incubator-gluten]

2024-04-22 Thread via GitHub
gaoyangxiaozhu commented on issue #5341: URL: https://github.com/apache/incubator-gluten/issues/5341#issuecomment-2071348441 the task lists missed below 3 uts: 1. test udf 2. test udaf 3. GlutenDeleteFromTableSuite @zhouyuan / @yma11 FYI, this PR is address to enable

Re: [PR] [VL] Enable passed 3.5 UT [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494#issuecomment-2071347771 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot commented on PR #5482: URL: https://github.com/apache/incubator-gluten/pull/5482#issuecomment-2071347708 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Enable passed 3.5 UT [incubator-gluten]

2024-04-22 Thread via GitHub
gaoyangxiaozhu commented on PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494#issuecomment-2071347602 @zhouyuan / @yma11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [VL] Enable passed 3.5 UT [incubator-gluten]

2024-04-22 Thread via GitHub
gaoyangxiaozhu opened a new pull request, #5494: URL: https://github.com/apache/incubator-gluten/pull/5494 ## What changes were proposed in this pull request? @FelixYBW / @zhouyuan / @yma11 I do a global search with keyworkd `disable for spark3.5`, those 3 uts should be the only

Re: [PR] [CH] Fix CHColumnarShuffleWriter compile error [incubator-gluten]

2024-04-22 Thread via GitHub
exmy closed pull request #5492: [CH] Fix CHColumnarShuffleWriter compile error URL: https://github.com/apache/incubator-gluten/pull/5492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Fix case-class inheritance for VeloxColumnarWriteFilesExec [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5480: URL: https://github.com/apache/incubator-gluten/pull/5480#issuecomment-2071343035 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][DOC] Add ABFS doc [incubator-gluten]

2024-04-22 Thread via GitHub
acvictor commented on code in PR #5479: URL: https://github.com/apache/incubator-gluten/pull/5479#discussion_r1575596443 ## docs/get-started/Velox.md: ## @@ -191,6 +191,19 @@ Here are two steps to enable kerberos. The ticket cache file can be found by `klist`. +## Azure

Re: [PR] [GLUTEN-5341] Fixes SPARK-42782: Hive compatibility check for get_json_object [incubator-gluten]

2024-04-22 Thread via GitHub
ayushi-agarwal commented on code in PR #5467: URL: https://github.com/apache/incubator-gluten/pull/5467#discussion_r1575594379 ## gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -126,7 +126,7 @@ class VeloxTestSettings extends

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-22 Thread via GitHub
SinghAsDev commented on code in PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#discussion_r1575594340 ## gluten-iceberg/src/test/scala/org/apache/gluten/execution/VeloxIcebergSuite.scala: ## @@ -58,8 +58,7 @@ class VeloxIcebergSuite extends

Re: [PR] [CH] Fix CH CI [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5493: URL: https://github.com/apache/incubator-gluten/pull/5493#issuecomment-2071338427 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] Fix CH CI [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5493: URL: https://github.com/apache/incubator-gluten/pull/5493#issuecomment-2071338202 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CH] Fix CH CI [incubator-gluten]

2024-04-22 Thread via GitHub
zhztheplayer opened a new pull request, #5493: URL: https://github.com/apache/incubator-gluten/pull/5493 There is a CI error related to https://github.com/apache/incubator-gluten/pull/5482 but was not detected since CH CI was broken at that time. The patch fixes the error.. -- This is

Re: [PR] [CH] Fix CHColumnarShuffleWriter compile error [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5492: URL: https://github.com/apache/incubator-gluten/pull/5492#issuecomment-2071337809 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] Fix CHColumnarShuffleWriter compile error [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5492: URL: https://github.com/apache/incubator-gluten/pull/5492#issuecomment-2071337583 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CH] Fix CHColumnarShuffleWriter compile error [incubator-gluten]

2024-04-22 Thread via GitHub
exmy opened a new pull request, #5492: URL: https://github.com/apache/incubator-gluten/pull/5492 ## What changes were proposed in this pull request? ## How was this patch tested? Pass CI -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [VL] Fix case-class inheritance for VeloxColumnarWriteFilesExec [incubator-gluten]

2024-04-22 Thread via GitHub
JkSelf commented on code in PR #5480: URL: https://github.com/apache/incubator-gluten/pull/5480#discussion_r1575590215 ## backends-velox/src/main/scala/org/apache/spark/sql/execution/VeloxColumnarWriteFilesExec.scala: ## @@ -254,20 +255,28 @@ class VeloxColumnarWriteFilesRDD(

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2071333754 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2071326533 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5352][GLUTEN-5459][CH]Fix and improve year function [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5455: URL: https://github.com/apache/incubator-gluten/pull/5455#issuecomment-2071321434 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fixes SPARK-42782: Hive compatibility check for get_json_object [incubator-gluten]

2024-04-22 Thread via GitHub
zhli1142015 commented on code in PR #5467: URL: https://github.com/apache/incubator-gluten/pull/5467#discussion_r1575580237 ## gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -126,7 +126,7 @@ class VeloxTestSettings extends

Re: [PR] [GLUTEN-5484] add missing tests for clickhouse [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5485: URL: https://github.com/apache/incubator-gluten/pull/5485#issuecomment-2071318283 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support fallback processing of velox_bloom_filter_agg [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot commented on PR #5477: URL: https://github.com/apache/incubator-gluten/pull/5477#issuecomment-2071312171 = Performance report for TPCH SF2000 with Velox backend, for reference only query

[I] I can't build gluten on an Intel MacOS machine [incubator-gluten]

2024-04-22 Thread via GitHub
NEUpanning opened a new issue, #5491: URL: https://github.com/apache/incubator-gluten/issues/5491 ### Problem description I ran `./dev/buildbundle-veloxbe.sh` and it failed. ### System information Velox System Info v0.0.2 Commit:

Re: [PR] [VL] Fix case-class inheritance for VeloxColumnarWriteFilesExec [incubator-gluten]

2024-04-22 Thread via GitHub
zhztheplayer commented on PR #5480: URL: https://github.com/apache/incubator-gluten/pull/5480#issuecomment-2071283933 @JkSelf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Fix case-class inheritance for VeloxColumnarWriteFilesExec [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5480: URL: https://github.com/apache/incubator-gluten/pull/5480#issuecomment-2071284061 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5484] add missing tests for clickhouse [incubator-gluten]

2024-04-22 Thread via GitHub
zzcclp commented on PR #5485: URL: https://github.com/apache/incubator-gluten/pull/5485#issuecomment-2071276560 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(incubator-gluten) branch main updated: [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest

2024-04-22 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new c2e77860f [VL] Avoid using debug instance

Re: [PR] [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest [incubator-gluten]

2024-04-22 Thread via GitHub
zhztheplayer merged PR #5482: URL: https://github.com/apache/incubator-gluten/pull/5482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL][DOC] Add ABFS doc [incubator-gluten]

2024-04-22 Thread via GitHub
PHILO-HE commented on code in PR #5479: URL: https://github.com/apache/incubator-gluten/pull/5479#discussion_r1575546016 ## docs/get-started/Velox.md: ## @@ -191,6 +191,19 @@ Here are two steps to enable kerberos. The ticket cache file can be found by `klist`. +## Azure

(incubator-gluten) branch main updated: [VL] Support fallback processing of velox_bloom_filter_agg (#5477)

2024-04-22 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new a7806e159 [VL] Support fallback

Re: [PR] [VL] Support fallback processing of velox_bloom_filter_agg [incubator-gluten]

2024-04-22 Thread via GitHub
zhztheplayer merged PR #5477: URL: https://github.com/apache/incubator-gluten/pull/5477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-22 Thread via GitHub
yma11 commented on PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#issuecomment-2071270127 @SinghAsDev Can you help review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [VL] Support array transform function [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5410: URL: https://github.com/apache/incubator-gluten/pull/5410#issuecomment-2071271684 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] CI: Add TPC-H / TPC-DS job at SF30 with Spark 3.4 [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5490: URL: https://github.com/apache/incubator-gluten/pull/5490#issuecomment-2071269785 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2071266203 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240420) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5468: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240420) URL: https://github.com/apache/incubator-gluten/pull/5468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4039][VL] support array_sort [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #4904: URL: https://github.com/apache/incubator-gluten/pull/4904#issuecomment-2071257474 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240415) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5399: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240415) URL: https://github.com/apache/incubator-gluten/pull/5399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4502][VL] Allow TIMESTAMP & complex types in cast expression [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #4509: URL: https://github.com/apache/incubator-gluten/pull/4509#issuecomment-2071257544 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240419) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5451: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240419) URL: https://github.com/apache/incubator-gluten/pull/5451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240417) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5428: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240417) URL: https://github.com/apache/incubator-gluten/pull/5428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240418) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5440: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240418) URL: https://github.com/apache/incubator-gluten/pull/5440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240421) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5470: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240421) URL: https://github.com/apache/incubator-gluten/pull/5470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240422) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5473: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240422) URL: https://github.com/apache/incubator-gluten/pull/5473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240413) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5389: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240413) URL: https://github.com/apache/incubator-gluten/pull/5389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240416) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5412: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240416) URL: https://github.com/apache/incubator-gluten/pull/5412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240414) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5396: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240414) URL: https://github.com/apache/incubator-gluten/pull/5396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4502][VL] Allow TIMESTAMP & complex types in cast expression [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] closed pull request #4509: [GLUTEN-4502][VL] Allow TIMESTAMP & complex types in cast expression URL: https://github.com/apache/incubator-gluten/pull/4509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-22 Thread via GitHub
baibaichen closed pull request #5374: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) URL: https://github.com/apache/incubator-gluten/pull/5374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4039][VL] Add array forall and exists function support [incubator-gluten]

2024-04-22 Thread via GitHub
PHILO-HE commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2071244214 > @PHILO-HE Would you have time to help review this patch? The pr looks good! Sorry for late response due to my time off in the last a few days. -- This is an

Re: [PR] [VL] Improve checkNativeWrite in VeloxParquetWriteForHiveSuite [incubator-gluten]

2024-04-22 Thread via GitHub
Zouxxyy closed pull request #5487: [VL] Improve checkNativeWrite in VeloxParquetWriteForHiveSuite URL: https://github.com/apache/incubator-gluten/pull/5487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_04_23) [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5489: URL: https://github.com/apache/incubator-gluten/pull/5489#issuecomment-2071167465 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_04_23) [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot opened a new pull request, #5489: URL: https://github.com/apache/incubator-gluten/pull/5489 Upstream Velox's New Commits: ```txt 28a1f187d by xiaoxmeng, Fix tempfile access in HdfsFileSystemTest.cpp (9565) aea1becb3 by Kevin Wilfong, Make copies of Vectors in

Re: [PR] [WIP][GLUTEN-5471][VL]feat: Support read Hudi COW table [incubator-gluten]

2024-04-22 Thread via GitHub
xushiyan commented on code in PR #5472: URL: https://github.com/apache/incubator-gluten/pull/5472#discussion_r1575490167 ## gluten-hudi/src/main/scala/org/apache/gluten/execution/HudiScanTransformer.scala: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [VL] Fix negative function mapping [incubator-gluten]

2024-04-22 Thread via GitHub
zhli1142015 merged PR #5481: URL: https://github.com/apache/incubator-gluten/pull/5481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Fix negative function mapping (#5481)

2024-04-22 Thread zhli
This is an automated email from the ASF dual-hosted git repository. zhli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 6100b60a8 [VL] Fix negative function

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240423) [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/incubator-gluten/pull/5488#issuecomment-2071094754 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240423) [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/incubator-gluten/pull/5488#issuecomment-2071094546 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240423) [incubator-gluten]

2024-04-22 Thread via GitHub
kyligence-git opened a new pull request, #5488: URL: https://github.com/apache/incubator-gluten/pull/5488 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CH][HOTFIX] Fix compile error after merging PR#5308 [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot commented on PR #5478: URL: https://github.com/apache/incubator-gluten/pull/5478#issuecomment-2071055772 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL][DOC] Separate udf doc [incubator-gluten]

2024-04-22 Thread via GitHub
FelixYBW commented on code in PR #5475: URL: https://github.com/apache/incubator-gluten/pull/5475#discussion_r1575103059 ## docs/get-started/Velox.md: ## @@ -351,178 +351,6 @@ Using the following configuration options to customize spilling: |

Re: [PR] [VL] Improve checkNativeWrite in VeloxParquetWriteForHiveSuite [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5487: URL: https://github.com/apache/incubator-gluten/pull/5487#issuecomment-2070069602 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2069325030 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5471][VL]feat: Support read Hudi COW table [incubator-gluten]

2024-04-22 Thread via GitHub
leesf commented on code in PR #5472: URL: https://github.com/apache/incubator-gluten/pull/5472#discussion_r1574585325 ## gluten-hudi/src/main/scala/org/apache/gluten/execution/HudiScanTransformer.scala: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2069127351 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4039][VL] Add array forall and exists function support [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2069126725 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Refactor VeloxParquetDatasource [incubator-gluten]

2024-04-22 Thread via GitHub
gaoyangxiaozhu commented on PR #5486: URL: https://github.com/apache/incubator-gluten/pull/5486#issuecomment-2069102973 @FelixYBW / @tigrux -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Add support to write parquet files to GCS [incubator-gluten]

2024-04-22 Thread via GitHub
gaoyangxiaozhu commented on code in PR #3978: URL: https://github.com/apache/incubator-gluten/pull/3978#discussion_r1574564412 ## cpp/velox/operators/writer/VeloxParquetDatasource.h: ## @@ -54,12 +58,14 @@ class VeloxParquetDatasource final : public Datasource { const

Re: [PR] [VL] Refactor VeloxParquetDatasource [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5486: URL: https://github.com/apache/incubator-gluten/pull/5486#issuecomment-2069100818 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2069081100 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH][HOTFIX] Fix compile error after merging PR#5308 [incubator-gluten]

2024-04-22 Thread via GitHub
zzcclp merged PR #5478: URL: https://github.com/apache/incubator-gluten/pull/5478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [CH][HOTFIX] Fix compile error after merging PR#5308 (#5478)

2024-04-22 Thread zhangzc
This is an automated email from the ASF dual-hosted git repository. zhangzc pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b4641c9eb [CH][HOTFIX] Fix compile error

Re: [PR] [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot commented on PR #5482: URL: https://github.com/apache/incubator-gluten/pull/5482#issuecomment-2069038974 = Performance report for TPCH SF2000 with Velox backend, for reference only query

(incubator-gluten) branch main updated (4fca32594 -> 471f3829a)

2024-04-22 Thread yangzy
This is an automated email from the ASF dual-hosted git repository. yangzy pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 4fca32594 [CH]feat: Support external sort shuffle, reduce shuffle memory usage when the number of partitions

Re: [PR] [GLUTEN-4039][VL] Add array forall and exists function support [incubator-gluten]

2024-04-22 Thread via GitHub
Yohahaha merged PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5484] add missing tests for clickhouse [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5485: URL: https://github.com/apache/incubator-gluten/pull/5485#issuecomment-2068988604 https://github.com/apache/incubator-gluten/issues/5484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5484] add missing tests for clickhouse [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5485: URL: https://github.com/apache/incubator-gluten/pull/5485#issuecomment-2068989101 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix Velox Parquet Write UT [incubator-gluten]

2024-04-22 Thread via GitHub
gaoyangxiaozhu commented on PR #5483: URL: https://github.com/apache/incubator-gluten/pull/5483#issuecomment-2068961331 @JkSelf the test case before always fallback which is actually not cover velox native write scenario -- This is an automated message from the Apache Git

Re: [PR] [VL] Fix Velox Parquet Write UT [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5483: URL: https://github.com/apache/incubator-gluten/pull/5483#issuecomment-2068960686 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CH]feat: Support external sort shuffle, reduce shuffle memory usage when the number of partitions is high [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot commented on PR #5279: URL: https://github.com/apache/incubator-gluten/pull/5279#issuecomment-2068947192 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4836][VL]Add support for WindowGroupLimitExec in gluten [incubator-gluten]

2024-04-22 Thread via GitHub
ayushi-agarwal commented on PR #5398: URL: https://github.com/apache/incubator-gluten/pull/5398#issuecomment-2068882457 > @ayushi-agarwal Can you help to resolve the conflicts? Thanks. @JkSelf I have updated it. -- This is an automated message from the Apache Git Service. To

Re: [PR] [GLUTEN-4836][VL]Add support for WindowGroupLimitExec in gluten [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5398: URL: https://github.com/apache/incubator-gluten/pull/5398#issuecomment-2068882325 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4039][VL] Add array forall and exists function support [incubator-gluten]

2024-04-22 Thread via GitHub
lyy-pineapple commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2068873554 > LGTM! please fix conflicts and wait all CI passed. has solved conflict ~ thanks -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-22 Thread via GitHub
GlutenPerfBot commented on PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#issuecomment-2068852615 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest [incubator-gluten]

2024-04-22 Thread via GitHub
zhztheplayer commented on PR #5482: URL: https://github.com/apache/incubator-gluten/pull/5482#issuecomment-2068831763 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5482: URL: https://github.com/apache/incubator-gluten/pull/5482#issuecomment-2068830572 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest [incubator-gluten]

2024-04-22 Thread via GitHub
zhztheplayer opened a new pull request, #5482: URL: https://github.com/apache/incubator-gluten/pull/5482 This is a minor fix to let VeloxBloomFilterTest use regular code path to get JniWorkspace, with some minor refactors. -- This is an automated message from the Apache Git Service. To

Re: [PR] [VL] Avoid using debug instance of JniWorkspace in VeloxBloomFilterTest [incubator-gluten]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #5482: URL: https://github.com/apache/incubator-gluten/pull/5482#issuecomment-2068830948 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >