(incubator-gluten) branch main updated: [GLUTEN-5620][CORE] Simplify Decimal process logic (#5621)

2024-05-07 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new c9018cdd8 [GLUTEN-5620][CORE] Simplify

Re: [I] Simplify Decimal process logic for https://github.com/apache/spark/pull/36698 [incubator-gluten]

2024-05-07 Thread via GitHub
baibaichen closed issue #5620: Simplify Decimal process logic for https://github.com/apache/spark/pull/36698 URL: https://github.com/apache/incubator-gluten/issues/5620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
baibaichen merged PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] spillRun.rows.empty() Error [incubator-gluten]

2024-05-07 Thread via GitHub
weiting-chen commented on issue #5348: URL: https://github.com/apache/incubator-gluten/issues/5348#issuecomment-2099791499 Close #5121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] spillRun.rows.empty() Error [incubator-gluten]

2024-05-07 Thread via GitHub
weiting-chen closed issue #5348: spillRun.rows.empty() Error URL: https://github.com/apache/incubator-gluten/issues/5348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(incubator-gluten) branch main updated: [GLUTEN-5352][GLUTEN-5459][CH]Fix and improve year function (#5455)

2024-05-07 Thread liuneng
This is an automated email from the ASF dual-hosted git repository. liuneng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 071d891cf

Re: [PR] [GLUTEN-5352][GLUTEN-5459][CH]Fix and improve year function [incubator-gluten]

2024-05-07 Thread via GitHub
liuneng1994 merged PR #5455: URL: https://github.com/apache/incubator-gluten/pull/5455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Diff result of year function [incubator-gluten]

2024-05-07 Thread via GitHub
liuneng1994 closed issue #5352: [CH] Diff result of year function URL: https://github.com/apache/incubator-gluten/issues/5352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2099774721 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5599][VL] Support json_tuple [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5600: URL: https://github.com/apache/incubator-gluten/pull/5600#issuecomment-2099763397 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add test for getbit Spark function [incubator-gluten]

2024-05-07 Thread via GitHub
acvictor commented on code in PR #5633: URL: https://github.com/apache/incubator-gluten/pull/5633#discussion_r1593398847 ## backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala: ## @@ -41,6 +41,12 @@ class ScalarFunctionsValidateSuite

[I] [VL] TProtocolException: Invalid data [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW opened a new issue, #5653: URL: https://github.com/apache/incubator-gluten/issues/5653 ### Backend VL (Velox) ### Bug description ``` 24/05/07 14:12:50 ERROR [Executor task launch worker for task 6355.0 in stage 0.0 (TID 6377)] util.TaskResources: Task 6377

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240508) [incubator-gluten]

2024-05-07 Thread via GitHub
liuneng1994 merged PR #5645: URL: https://github.com/apache/incubator-gluten/pull/5645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240508) (#5645)

2024-05-07 Thread liuneng
This is an automated email from the ASF dual-hosted git repository. liuneng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 3f0bd06cf [GLUTEN-1632][CH]Daily Update

Re: [PR] [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not [incubator-gluten]

2024-05-07 Thread via GitHub
GlutenPerfBot commented on PR #5649: URL: https://github.com/apache/incubator-gluten/pull/5649#issuecomment-2099706937 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL][CI] Fix clang-format version [incubator-gluten]

2024-05-07 Thread via GitHub
yma11 commented on PR #5650: URL: https://github.com/apache/incubator-gluten/pull/5650#issuecomment-2099698178 What's the difference between `12` and `15`? `15` is used as consistent with CH backend. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5651][CH] Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing to_date/to_timestamp [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5652: URL: https://github.com/apache/incubator-gluten/pull/5652#issuecomment-2099694263 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Fix clang-format version [incubator-gluten]

2024-05-07 Thread via GitHub
PHILO-HE commented on PR #5650: URL: https://github.com/apache/incubator-gluten/pull/5650#issuecomment-2099694178 @yma11, could you take a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-5651][CH] Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing to_date/to_timestamp [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5652: URL: https://github.com/apache/incubator-gluten/pull/5652#issuecomment-2099692496 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5651][CH] Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing to_date/to_timestamp [incubator-gluten]

2024-05-07 Thread via GitHub
zzcclp commented on PR #5652: URL: https://github.com/apache/incubator-gluten/pull/5652#issuecomment-2099692384 @loneylee please help to review, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-5651][CH] Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing to_date/to_timestamp [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5652: URL: https://github.com/apache/incubator-gluten/pull/5652#issuecomment-2099692335 https://github.com/apache/incubator-gluten/issues/5651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5651][CH] Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing to_date/to_timestamp [incubator-gluten]

2024-05-07 Thread via GitHub
zzcclp opened a new pull request, #5652: URL: https://github.com/apache/incubator-gluten/pull/5652 ## What changes were proposed in this pull request? Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing

[I] [CH] Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing to_date/to_timestamp [incubator-gluten]

2024-05-07 Thread via GitHub
zzcclp opened a new issue, #5651: URL: https://github.com/apache/incubator-gluten/issues/5651 ### Backend CH (ClickHouse) ### Bug description Fix error 'Illegal type of argument of function parseDateTimeInJodaSyntaxOrNull, expected String, got Date32' when executing

Re: [PR] [GLUTEN-5414] [VL] Support Arrow native memory pool usage track [incubator-gluten]

2024-05-07 Thread via GitHub
zhztheplayer commented on PR #5550: URL: https://github.com/apache/incubator-gluten/pull/5550#issuecomment-2099676944 > Can you help merge this one? Thanks! @zhztheplayer Merged. And please fill in the PR description if possible. -- This is an automated message from the Apache

Re: [PR] [GLUTEN-5414] [VL] Support Arrow native memory pool usage track [incubator-gluten]

2024-05-07 Thread via GitHub
zhztheplayer merged PR #5550: URL: https://github.com/apache/incubator-gluten/pull/5550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-5414] [VL] Support Arrow native memory pool usage track (#5550)

2024-05-07 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new cee1f3bd8 [GLUTEN-5414] [VL] Support

Re: [PR] [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not [incubator-gluten]

2024-05-07 Thread via GitHub
zhztheplayer merged PR #5649: URL: https://github.com/apache/incubator-gluten/pull/5649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not (#5649)

2024-05-07 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new e633887c8 [VL] Add a bad test case that

Re: [PR] [GLUTEN-4917][CI] remove miniconda folder in image [incubator-gluten]

2024-05-07 Thread via GitHub
GlutenPerfBot commented on PR #5646: URL: https://github.com/apache/incubator-gluten/pull/5646#issuecomment-2099654127 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2099651706 After I enable HDFS in ARROW, I can successfully read csv file in HDFS. ``` scala> val filePath = "/input/student.csv" filePath: String = /input/student.csv

Re: [PR] [VL][CI] Fix clang-format version [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5650: URL: https://github.com/apache/incubator-gluten/pull/5650#issuecomment-2099646822 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][CI] Fix clang-format version [incubator-gluten]

2024-05-07 Thread via GitHub
PHILO-HE opened a new pull request, #5650: URL: https://github.com/apache/incubator-gluten/pull/5650 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5599][VL] Support json_tuple [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5600: URL: https://github.com/apache/incubator-gluten/pull/5600#issuecomment-2099632359 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5639] [CH] [DRAFT] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5640: URL: https://github.com/apache/incubator-gluten/pull/5640#issuecomment-2099630870 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#issuecomment-2099630447 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not [incubator-gluten]

2024-05-07 Thread via GitHub
liujiayi771 commented on PR #5649: URL: https://github.com/apache/incubator-gluten/pull/5649#issuecomment-2099629935 @zhztheplayer Thank you for adding this bad case. I will help to see how to convert the intermediate output of Velox to Spark. -- This is an automated message from the

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#issuecomment-2099628883 ok @baibaichen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
baibaichen commented on PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#issuecomment-2099627692 > For velox backend, it check overflow in native binary arithmetic too, can you try to change the code to not transform checkoverflow? @jinchengchenghh would you

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2099626710 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
baibaichen commented on code in PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#discussion_r1593308395 ## gluten-core/src/main/scala/org/apache/gluten/utils/DecimalArithmeticUtil.scala: ## @@ -159,56 +163,30 @@ object DecimalArithmeticUtil { } //

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#issuecomment-2099625156 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#issuecomment-2099624798 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Enable map_zip_with, zip_with functions (#5610)

2024-05-07 Thread zhli
This is an automated email from the ASF dual-hosted git repository. zhli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new e975bf368 [VL] Enable map_zip_with,

Re: [PR] [VL] Enable map_zip_with, zip_with functions [incubator-gluten]

2024-05-07 Thread via GitHub
zhli1142015 merged PR #5610: URL: https://github.com/apache/incubator-gluten/pull/5610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5599][VL] Support json_tuple [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5600: URL: https://github.com/apache/incubator-gluten/pull/5600#issuecomment-2099623250 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable map_zip_with, zip_with functions [incubator-gluten]

2024-05-07 Thread via GitHub
zhli1142015 commented on code in PR #5610: URL: https://github.com/apache/incubator-gluten/pull/5610#discussion_r1593306096 ## gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -278,6 +278,8 @@ class VeloxTestSettings extends

Re: [PR] [DNM][GLUTEN-5548][VL] test dynamic setting [incubator-gluten]

2024-05-07 Thread via GitHub
zhli1142015 commented on PR #5506: URL: https://github.com/apache/incubator-gluten/pull/5506#issuecomment-2099621498 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [VL] Unsupported type for hash: ARRAY [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on issue #5642: URL: https://github.com/apache/incubator-gluten/issues/5642#issuecomment-2099610544 > This should be resolved by Velox PR [facebookincubator/velox#9414](https://github.com/facebookincubator/velox/pull/9414) Oh, I thought I had seen this error

Re: [PR] [VL][DOC] Suggest enable vcpkg for docker build in centos [incubator-gluten]

2024-05-07 Thread via GitHub
ulysses-you commented on PR #5641: URL: https://github.com/apache/incubator-gluten/pull/5641#issuecomment-2099609109 @FelixYBW @weiting-chen @zhouyuan I believe there is an issue https://github.com/apache/incubator-gluten/pull/5033 before going to enbale vcpkg by default ? -- This is

(incubator-gluten) branch main updated: [GLUTEN-4917][CI] Remove miniconda folder in image (#5646)

2024-05-07 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 01979372c [GLUTEN-4917][CI] Remove

Re: [PR] [GLUTEN-4917][CI] remove miniconda folder in image [incubator-gluten]

2024-05-07 Thread via GitHub
PHILO-HE merged PR #5646: URL: https://github.com/apache/incubator-gluten/pull/5646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL][DOC] Suggest enable vcpkg for docker build in centos [incubator-gluten]

2024-05-07 Thread via GitHub
zml1206 commented on PR #5641: URL: https://github.com/apache/incubator-gluten/pull/5641#issuecomment-2099605523 > Actually we are going to enable vcpkg=on as default. The dynamic build script is still there but CI won't track it. @weiting-chen Default `on` is more friendly to novices

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2099604964 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414] [VL] Support Arrow native memory pool usage track [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on PR #5550: URL: https://github.com/apache/incubator-gluten/pull/5550#issuecomment-2099594838 Can you help merge this one? Thanks! @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-4917][VL] static packaging refine [incubator-gluten]

2024-05-07 Thread via GitHub
ulysses-you commented on PR #5033: URL: https://github.com/apache/incubator-gluten/pull/5033#issuecomment-2099564330 hi @zhouyuan if there any blocker on this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [GLUTEN-5352][GLUTEN-5459][CH]Fix and improve year function [incubator-gluten]

2024-05-07 Thread via GitHub
KevinyhZou commented on PR #5455: URL: https://github.com/apache/incubator-gluten/pull/5455#issuecomment-2099561256 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5649: URL: https://github.com/apache/incubator-gluten/pull/5649#issuecomment-2099549984 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not [incubator-gluten]

2024-05-07 Thread via GitHub
zhztheplayer commented on PR #5649: URL: https://github.com/apache/incubator-gluten/pull/5649#issuecomment-2099549998 cc @liujiayi771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5649: URL: https://github.com/apache/incubator-gluten/pull/5649#issuecomment-2099549776 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Add a bad test case that final aggregate of collect_list is fallen back while partial aggregate is not [incubator-gluten]

2024-05-07 Thread via GitHub
zhztheplayer opened a new pull request, #5649: URL: https://github.com/apache/incubator-gluten/pull/5649 With whole stage fallback feature, we can manage to create a plan (AE=on) like: ``` Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=393] +- HashAggregate(keys=[],

Re: [I] [VL] Spark 3.5 Unit Tests track [incubator-gluten]

2024-05-07 Thread via GitHub
yma11 commented on issue #5309: URL: https://github.com/apache/incubator-gluten/issues/5309#issuecomment-2099546785 Currently all gaps for Spark3.5 UTs are filled. The failed UTs include: `reading _tmp_metadata_row_index - not present in a table`, `reading _tmp_metadata_row_index -

(incubator-gluten) branch main updated: [GLUTEN-5603] Add new added Spark3.4 UTs in Gluten for Spark3.5 (#5637)

2024-05-07 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 75fa35c46 [GLUTEN-5603] Add new added

Re: [PR] [GLUTEN-5603] Add new added Spark3.4 UTs in Gluten for Spark3.5 [incubator-gluten]

2024-05-07 Thread via GitHub
zhouyuan merged PR #5637: URL: https://github.com/apache/incubator-gluten/pull/5637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Unsupported type for hash: ARRAY [incubator-gluten]

2024-05-07 Thread via GitHub
marin-ma commented on issue #5642: URL: https://github.com/apache/incubator-gluten/issues/5642#issuecomment-2099544660 This should be resolved by Velox PR https://github.com/facebookincubator/velox/pull/9414 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2099529883 > We also need to add HDFS support for arrow dataset. > > ``` > caused by: java.lang.RuntimeException: Got HDFS URI but Arrow compiled without HDFS support

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on code in PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#discussion_r1593241871 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -510,42 +493,71 @@ object ExpressionConverter extends

Re: [PR] [VL] Enable compile_arrow_java by default to avoid invalid pointer error [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5648: URL: https://github.com/apache/incubator-gluten/pull/5648#issuecomment-2099519100 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Enable compile_arrow_java by default to avoid invalid pointer error [incubator-gluten]

2024-05-07 Thread via GitHub
PHILO-HE opened a new pull request, #5648: URL: https://github.com/apache/incubator-gluten/pull/5648 ## What changes were proposed in this pull request? Though the reported issue is on centos-7 by now, it's still possible that user encounters such issue on other OS. So let's directly

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#issuecomment-2099508924 I think we can also remove `getResultTypeForOperation` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#issuecomment-2099508881 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#issuecomment-2099506872 For velox backend, it check overflow in native binary arithmetic too, can you try to change the code to not transform checkoverflow? -- This is an automated message

Re: [PR] [GLUTEN-5620][CORE] Simplify Decimal process logic [incubator-gluten]

2024-05-07 Thread via GitHub
jinchengchenghh commented on code in PR #5621: URL: https://github.com/apache/incubator-gluten/pull/5621#discussion_r1593210424 ## backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala: ## @@ -257,6 +257,7 @@ object CHBackendSettings

[PR] [VL] Daily Update Velox Version (2024_05_08) [incubator-gluten]

2024-05-07 Thread via GitHub
GlutenPerfBot opened a new pull request, #5647: URL: https://github.com/apache/incubator-gluten/pull/5647 Upstream Velox's New Commits: ```txt ac553396c by Ke, Fix PartitionIdGenerator's multiplier initialization for VectorHasher (9713) 7cfb42fb1 by joey.ljy, Fix the

Re: [I] Besides Centos and Ubuntu systems, does the gluten project support the Maipo system? [incubator-gluten]

2024-05-07 Thread via GitHub
PHILO-HE commented on issue #4932: URL: https://github.com/apache/incubator-gluten/issues/4932#issuecomment-2099502958 See https://github.com/apache/incubator-gluten/issues/4935#issuecomment-1992859638. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [VL] Daily Update Velox Version (2024_05_08) [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5647: URL: https://github.com/apache/incubator-gluten/pull/5647#issuecomment-2099502851 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-4917][CI] remove miniconda folder in image [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5646: URL: https://github.com/apache/incubator-gluten/pull/5646#issuecomment-2099480794 https://github.com/apache/incubator-gluten/issues/4917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4917][CI] remove miniconda folder in image [incubator-gluten]

2024-05-07 Thread via GitHub
zhouyuan opened a new pull request, #5646: URL: https://github.com/apache/incubator-gluten/pull/5646 ## What changes were proposed in this pull request? remove miniconda folder to save disk space ## How was this patch tested? pass GHA -- This is an automated

Re: [PR] [VL] Add test for getbit Spark function [incubator-gluten]

2024-05-07 Thread via GitHub
PHILO-HE commented on code in PR #5633: URL: https://github.com/apache/incubator-gluten/pull/5633#discussion_r1593211031 ## backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala: ## @@ -41,6 +41,12 @@ class ScalarFunctionsValidateSuite

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-05-07 Thread via GitHub
GlutenPerfBot commented on PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#issuecomment-2099470021 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2099459389 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch zip_with deleted (was f0d47023a)

2024-05-07 Thread zhli
This is an automated email from the ASF dual-hosted git repository. zhli pushed a change to branch zip_with in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git was f0d47023a add ut The revisions that were on this branch are still contained in other references;

Re: [PR] [VL] Enable map_zip_with, zip_with functions [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5610: URL: https://github.com/apache/incubator-gluten/pull/5610#issuecomment-2099452976 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) 01/01: add ut

2024-05-07 Thread zhli
This is an automated email from the ASF dual-hosted git repository. zhli pushed a commit to branch zip_with in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git commit f0d47023a3088675c7444f97f3a3300626aecca0 Author: zhli1142015 AuthorDate: Wed May 8 07:04:19 2024 +0800

(incubator-gluten) branch zip_with created (now f0d47023a)

2024-05-07 Thread zhli
This is an automated email from the ASF dual-hosted git repository. zhli pushed a change to branch zip_with in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git at f0d47023a add ut This branch includes the following new commits: new f0d47023a add ut The 1

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240508) [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5645: URL: https://github.com/apache/incubator-gluten/pull/5645#issuecomment-2099450116 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240508) [incubator-gluten]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #5645: URL: https://github.com/apache/incubator-gluten/pull/5645#issuecomment-2099449918 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240508) [incubator-gluten]

2024-05-07 Thread via GitHub
kyligence-git opened a new pull request, #5645: URL: https://github.com/apache/incubator-gluten/pull/5645 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-05-07 Thread via GitHub
zhli1142015 commented on code in PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#discussion_r1593188492 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1230,9 +1230,10 @@ object GlutenConfig { val

[I] [VL] Failed to parse proto from s3://xxx from 179665 for 10 [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW opened a new issue, #5644: URL: https://github.com/apache/incubator-gluten/issues/5644 ### Backend VL (Velox) ### Bug description ``` Error Source: RUNTIME Error Code: UNKNOWN Reason: Failed to parse proto from

[I] [VL] the key in unnest Operator only support field [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW opened a new issue, #5643: URL: https://github.com/apache/incubator-gluten/issues/5643 ### Backend VL (Velox) ### Bug description ``` Error Source: RUNTIME Error Code: INVALID_STATE Reason: the key in unnest Operator only support field Retriable:

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-05-07 Thread via GitHub
GlutenPerfBot commented on PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#issuecomment-2099312895 = Performance report for TPCH SF2000 with Velox backend, for reference only query

[I] [VL] Unsupported type for hash: ARRAY [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW opened a new issue, #5642: URL: https://github.com/apache/incubator-gluten/issues/5642 ### Backend VL (Velox) ### Bug description ``` java.lang.RuntimeException: Exception: VeloxUserError Error Source: USER Error Code: INVALID_ARGUMENT Reason:

Re: [I] [VL] Json support in Gluten/Velox tracker [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on issue #5504: URL: https://github.com/apache/incubator-gluten/issues/5504#issuecomment-2098933305 https://github.com/apache/incubator-gluten/pull/5600 add json_tuple function -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2098924939 @PHILO-HE Any update of the issues here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#issuecomment-2098921945 @WangGuangxin can you help to resolve conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [VL] Pass file size and modification time to split [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on PR #5632: URL: https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2098920594 Can you comment a bit how these info are used by Velox? Is it aligned with Spark's behavior? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [VL] Spark width_bucket function support [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on PR #5634: URL: https://github.com/apache/incubator-gluten/pull/5634#issuecomment-2098916704 > hose specifal cases as the result type already be set to Velox uses Presto implementation. You may need to create a new function for Velox/Spark, and pass the reference of

Re: [PR] [GLUTEN-5603] Add new added Spark3.4 UTs in Gluten for Spark3.5 [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on PR #5637: URL: https://github.com/apache/incubator-gluten/pull/5637#issuecomment-2098910136 If there are failed UTs, let's track here: https://github.com/apache/incubator-gluten/issues/5309 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [VL][DOC] Suggest enable vcpkg for docker build in centos [incubator-gluten]

2024-05-07 Thread via GitHub
FelixYBW commented on PR #5641: URL: https://github.com/apache/incubator-gluten/pull/5641#issuecomment-2098906756 Actually we are going to enable vcpkg=on as default. The dynamic build script is still there but CI won't track it. @weiting-chen -- This is an automated message from

(incubator-gluten) branch main updated: [VL] Enable split preloading by default (#5456)

2024-05-07 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 254d62e72 [VL] Enable split preloading

  1   2   >