Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2116789351 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-17 Thread via GitHub
yaooqinn merged PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-16 Thread via GitHub
jinchengchenghh commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1604244527 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala: ## @@ -18,6 +18,15 @@ package org.apache.gluten.expression

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-16 Thread via GitHub
jinchengchenghh commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1604244527 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala: ## @@ -18,6 +18,15 @@ package org.apache.gluten.expression

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-16 Thread via GitHub
ulysses-you commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1604240574 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala: ## @@ -18,6 +18,15 @@ package org.apache.gluten.expression

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-16 Thread via GitHub
jinchengchenghh commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1604232341 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala: ## @@ -18,6 +18,15 @@ package org.apache.gluten.expression

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
ulysses-you commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1602624507 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala: ## @@ -18,6 +18,15 @@ package org.apache.gluten.expression

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
jinchengchenghh commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1602573722 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala: ## @@ -18,6 +18,15 @@ package org.apache.gluten.expression

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
ulysses-you commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2113972798 cc @jinchengchenghh @baibaichen @PHILO-HE thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2113731716 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2112072687 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
ulysses-you commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1601172081 ## gluten-core/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala: ## @@ -450,14 +450,6 @@ trait SparkPlanExecApi {

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111857742 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-15 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111660451 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111536591 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111520790 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111520635 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
ulysses-you opened a new pull request, #5752: URL: https://github.com/apache/incubator-gluten/pull/5752 ## What changes were proposed in this pull request? - Port `DecimalPrecisionSuite` into gluten. - Add dataType in `ExpressionTransformer` to help check data type ## How