Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

WangGuangxin commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1593888422 ## gluten-core/src/main/scala/io/glutenproject/extension/columnar/RewriteTypedImperativeAggregate.scala: ## @@ -67,6 +100,28 @@ object

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

zhztheplayer commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1591954924 ## gluten-core/src/main/scala/io/glutenproject/extension/columnar/RewriteTypedImperativeAggregate.scala: ## @@ -67,6 +100,28 @@ object

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

zhztheplayer commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1591954924 ## gluten-core/src/main/scala/io/glutenproject/extension/columnar/RewriteTypedImperativeAggregate.scala: ## @@ -67,6 +100,28 @@ object

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

zhztheplayer commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1591954924 ## gluten-core/src/main/scala/io/glutenproject/extension/columnar/RewriteTypedImperativeAggregate.scala: ## @@ -67,6 +100,28 @@ object

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

liujiayi771 commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2076680006 @WangGuangxin Any progress of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

WangGuangxin commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1538532110 ## gluten-core/src/main/scala/io/glutenproject/extension/columnar/RewriteTypedImperativeAggregate.scala: ## @@ -40,6 +41,38 @@ object

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

liujiayi771 commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1536728309 ## gluten-core/src/main/scala/io/glutenproject/extension/columnar/RewriteTypedImperativeAggregate.scala: ## @@ -40,6 +41,38 @@ object

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

WangGuangxin commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2011045153 > this yes, we should merge to upsteam first before merge this PR -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

zhztheplayer commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2010990615 Hi @WangGuangxin so the current plan is to merge https://github.com/WangGuangxin/gluten/commit/97db869a56e8d42c0782e4e8218e1937e40682ce to upstream Velox before this ? Am

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

liujiayi771 commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008652742 @WangGuangxin Perhaps we could create an issue in the upstream Velox community to remove this verification. -- This is an automated message from the Apache Git Service.

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

zhztheplayer commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1531488552 ## backends-velox/src/test/scala/io/glutenproject/execution/TestOperator.scala: ## @@ -1233,4 +1233,12 @@ class TestOperator extends

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

zhztheplayer commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008617781 Thank you in advance! > I believe the change on Gluten side is ready now. Did that mean this PR can be merged prior to merging Velox changes? -- This is an

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

WangGuangxin commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008557794 I believe the change on Gluten side is ready now. But the `ApproxPercentileAggregate` implements in velox has to make some minor modification, becasue when add

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

zhouyuan commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008478357 CC: @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

github-actions[bot] commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2005348332 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

github-actions[bot] commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2005347612 https://github.com/apache/incubator-gluten/issues/4889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

WangGuangxin opened a new pull request, #5007: URL: https://github.com/apache/incubator-gluten/pull/5007 ## What changes were proposed in this pull request? Support approx_percentile for VL backend (Fixes: \#4889) ## How was this patch tested? UT --