Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

GlutenPerfBot commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2120364854 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer merged PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

GlutenPerfBot commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2120227131 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

Yohahaha commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2119971067 > Hi @Yohahaha the benchmark is currently unstable because of network issues. Let's wait until we get a valid result after the issues get fixed. ok -- This is an

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2119948260 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2119946353 Hi @Yohahaha the benchmark is currently unstable because of network issues. Let's wait until we get a valid result after the issues get fixed. -- This is an automated

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2119576181 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

Yohahaha commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2117551983 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2117039157 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2117021394 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116856661 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

Yohahaha commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116552304 > > > @Yohahaha Seems to be that the block reservation code can be very suitable to become a individual `AllocationListener`. Would you like to check on that? > > > >

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

Yohahaha commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116552140 > ListenableMemoryAllocator make sense for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

Yohahaha commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116550590 After some tries I would like to say ReservationListener is a hook to another memory management system and should be as simple as possible, MemoryAllocator is a common class

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116535745 > > @Yohahaha Seems to be that the block reservation code can be very suitable to become a individual `AllocationListener`. Would you like to check on that? > > I

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

Yohahaha commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116501561 > @Yohahaha Seems to be that the block reservation code can be very suitable to become a individual `AllocationListener`. Would you like to check on that? I see it,

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

zhztheplayer commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116483438 @Yohahaha Seems to be that the block reservation code can be very suitable to become a individual `AllocationListener`. Would you like to check on that? -- This is an

Re: [PR] [VL] Move memory reservation block computation logic into ListenableAllocator [incubator-gluten]

github-actions[bot] commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2114457000 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?