Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1604269082 ## cpp/core/shuffle/HashPartitioner.cc: ## @@ -16,9 +16,28 @@ */ #include "shuffle/HashPartitioner.h" +#include Review Comment: Please remove.

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2116518948 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2116449714 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2115948066 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2115647055 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2115642848 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114965347 > > I tested it using centos8 and ubuntu2004, but the local development environment could not reproduce it. > > > > @kerwin-zk Do you mean it cannot be

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114948379 > I tested it using centos8 and ubuntu2004, but the local development environment could not reproduce it. Do you mean it cannot be reproduce on centos8? What GCC version

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114941266 > @kerwin-zk It's weird that I cannot reproduce the UT failure on my dev environment (ubuntu 22.04), but can reproduce that in the docker container (centos stream 8).

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114875088 1. @kerwin-zk It's weird that I cannot reproduce the UT failure on my dev environment (ubuntu 22.04), but can reproduce that in the docker container (centos stream 8). --

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602952627 ## gluten-data/src/main/java/org/apache/gluten/vectorized/ShuffleWriterJniWrapper.java: ## @@ -161,8 +167,10 @@ public native long nativeMake( long

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1603027472 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.cc: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114729874 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602927339 ## cpp/core/shuffle/ShuffleReader.cc: ## @@ -16,6 +16,9 @@ */ #include "ShuffleReader.h" + +#include Review Comment: Unintended change? -- This

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602927339 ## cpp/core/shuffle/ShuffleReader.cc: ## @@ -16,6 +16,9 @@ */ #include "ShuffleReader.h" + +#include Review Comment: Unintended change? -- This

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602744985 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.cc: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114108829 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114107721 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2114076185 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602561639 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.cc: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602560233 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.h: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602527162 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.h: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602519192 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.h: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2113907004 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2113906603 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602507034 ## cpp/velox/shuffle/VeloxShuffleWriter.h: ## @@ -132,6 +132,8 @@ class VeloxShuffleWriter final : public ShuffleWriter { arrow::Status

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2113718355 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2112981961 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2112908284 > Could you add cpp UT for sort-based shuffle? If it's possible to implement another `LocalRssClient` for sort-based shuffle and use it in native tests, we can reuse the

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599300738 ## cpp/core/jni/JniWrapper.cc: ## @@ -148,6 +149,69 @@ class JavaInputStreamAdaptor final : public arrow::io::InputStream { bool closed_ = false; };

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599300738 ## cpp/core/jni/JniWrapper.cc: ## @@ -148,6 +149,69 @@ class JavaInputStreamAdaptor final : public arrow::io::InputStream { bool closed_ = false; };

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1601882027 ## cpp/core/shuffle/HashPartitioner.cc: ## @@ -52,4 +52,33 @@ arrow::Status gluten::HashPartitioner::compute( return arrow::Status::OK(); }

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2112893168 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2112869952 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1601210868 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.cc: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2111791910 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1601021801 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.h: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1601018809 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.h: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2111530688 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2111527701 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2111410162 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110582368 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110297522 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-211029 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110244501 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110044454 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109842234 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109813010 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109800277 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109789645 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109723320 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109721484 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599663921 ## cpp/velox/shuffle/VeloxSortBasedShuffleWriter.cc: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109688171 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599407096 ## cpp/core/shuffle/HashPartitioner.cc: ## @@ -52,4 +52,33 @@ arrow::Status gluten::HashPartitioner::compute( return arrow::Status::OK(); }

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109602406 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109577592 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109574897 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109169780 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599300738 ## cpp/core/jni/JniWrapper.cc: ## @@ -148,6 +149,69 @@ class JavaInputStreamAdaptor final : public arrow::io::InputStream { bool closed_ = false; };

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599290918 ## cpp/core/jni/JniWrapper.cc: ## @@ -148,6 +149,69 @@ class JavaInputStreamAdaptor final : public arrow::io::InputStream { bool closed_ = false; };

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599288631 ## cpp/core/jni/JniWrapper.cc: ## @@ -148,6 +149,69 @@ class JavaInputStreamAdaptor final : public arrow::io::InputStream { bool closed_ = false; };

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109140852 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2108108869 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2107516246 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1597965285 ## cpp/velox/shuffle/VeloxShuffleWriter.h: ## @@ -132,6 +132,8 @@ class VeloxShuffleWriter final : public ShuffleWriter { arrow::Status

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

marin-ma commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1597917109 ## cpp/core/jni/JniWrapper.cc: ## @@ -148,6 +149,69 @@ class JavaInputStreamAdaptor final : public arrow::io::InputStream { bool closed_ = false; };

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2104486158 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2104452837 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1596492952 ## cpp/velox/shuffle/VeloxShuffleWriter.h: ## @@ -132,6 +132,8 @@ class VeloxShuffleWriter final : public ShuffleWriter { arrow::Status

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2104216712 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2104206856 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

kerwin-zk commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1596242830 ## cpp/velox/shuffle/VeloxShuffleWriter.cc: ## @@ -376,8 +386,145 @@ arrow::Status VeloxShuffleWriter::partitioningAndDoSplit(facebook::velox::RowVec

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

zhouyuan commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1596226525 ## cpp/velox/shuffle/VeloxShuffleWriter.cc: ## @@ -376,8 +386,145 @@ arrow::Status VeloxShuffleWriter::partitioningAndDoSplit(facebook::velox::RowVec

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2103668516 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2103667167 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

FelixYBW commented on code in PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1595874723 ## cpp/velox/shuffle/VeloxShuffleWriter.h: ## @@ -132,6 +132,8 @@ class VeloxShuffleWriter final : public ShuffleWriter { arrow::Status

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

FelixYBW commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2103267810 Thank you for the PR! Waiting for long time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2103029195 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2102892979 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2102594110 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2102577681 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2102577287 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2102576899 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?