Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2012523835 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE merged PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-20 Thread via GitHub
zhli1142015 commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531700862 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -129,6 +129,13 @@ class SparkPlanExecApiImpl extends

Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2009058696 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531682348 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -129,6 +129,13 @@ class SparkPlanExecApiImpl extends

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2008595501 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
rui-mo commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531463499 ## gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala: ## @@ -199,6 +199,10 @@ trait SparkPlanExecApi { throw new

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
zhli1142015 commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531459439 ## gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala: ## @@ -199,6 +199,10 @@ trait SparkPlanExecApi { throw new

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
rui-mo commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531417665 ## gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala: ## @@ -199,6 +199,10 @@ trait SparkPlanExecApi { throw new

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
zhli1142015 commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2006250724 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
zhli1142015 commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2006248851 @PHILO-HE and @rui-mo , could you help review this? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-18 Thread via GitHub
zhli1142015 commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2005754756 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2005751846 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2005751683 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] support uuid function [incubator-gluten]

2024-03-18 Thread via GitHub
zhli1142015 opened a new pull request, #5014: URL: https://github.com/apache/incubator-gluten/pull/5014 ## What changes were proposed in this pull request? Support uuid function. ## How was this patch tested? UT. -- This is an automated message from the Apache