Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

ulysses-you commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2011006314 It seems the failed tests are irrelevant, I tried to re-run the failed tests. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2009516887 @liujiayi771 @ulysses-you Could you help to review again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2009516553 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2009094966 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531653906 ## gluten-core/src/main/scala/io/glutenproject/utils/PullOutProjectHelper.scala: ## @@ -57,12 +57,13 @@ trait PullOutProjectHelper { protected def

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531653906 ## gluten-core/src/main/scala/io/glutenproject/utils/PullOutProjectHelper.scala: ## @@ -57,12 +57,13 @@ trait PullOutProjectHelper { protected def

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

ulysses-you commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531615518 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531602106 ## backends-velox/src/main/scala/io/glutenproject/execution/GenerateExecTransformer.scala: ## @@ -141,92 +108,100 @@ case class GenerateExecTransformer(

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2008930913 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531597159 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

taiyang-li commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531541641 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531532126 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531529571 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531484022 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531484022 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531482873 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531479331 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

ulysses-you commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531433566 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531430562 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531422585 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

ulysses-you commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531399817 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1530600585 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1530596160 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1530596160 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1530590055 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1530582237 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1530193158 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2006944215 cc @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

liujiayi771 commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2006938506 @marin-ma `RewriteSparkPlanRulesManager` will fallback these pre/post project. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2006772890 cc: @zhouyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2006770007 @liujiayi771 Could you help to review? I also have concerns about the fallback mechanism after pulling out the pre/post project. As the rules are applied before

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2006617281 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2006144758 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2006047531 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-1996727008 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-1996726664 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

marin-ma opened a new pull request, #4952: URL: https://github.com/apache/incubator-gluten/pull/4952 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To