[GitHub] [incubator-hudi] vinothchandar commented on issue #1492: [HUDI-761] Refactoring rollback and restore actions using the ActionExecutor abstraction

2020-04-12 Thread GitBox
vinothchandar commented on issue #1492: [HUDI-761] Refactoring rollback and restore actions using the ActionExecutor abstraction URL: https://github.com/apache/incubator-hudi/pull/1492#issuecomment-612778656 Rebased again.. Will wait for CI to pass and merge. -

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1492: [HUDI-761] Refactoring rollback and restore actions using the ActionExecutor abstraction

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1492: [HUDI-761] Refactoring rollback and restore actions using the ActionExecutor abstraction URL: https://github.com/apache/incubator-hudi/pull/1492#discussion_r407346793 ## File path: hudi-client/src/main/java/org/apache/hudi/

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1492: [HUDI-761] Refactoring rollback and restore actions using the ActionExecutor abstraction

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1492: [HUDI-761] Refactoring rollback and restore actions using the ActionExecutor abstraction URL: https://github.com/apache/incubator-hudi/pull/1492#discussion_r407342052 ## File path: hudi-client/src/main/java/org/apache/hudi/table

[GitHub] [incubator-hudi] liujianhuiouc commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
liujianhuiouc commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1509#issuecomment-612771752 thank you for you reminding, it's my company email, i have set it with personal mailbox -

[GitHub] [incubator-hudi] bvaradar merged pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar merged pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495 This is an automated message from the Apache Git Service

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
codecov-io edited a comment on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#issuecomment-610761048 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1495?src=pr&el=h1) Report

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407328188 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.jav

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407328044 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/H

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
garyli1019 commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407326317 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java

[GitHub] [incubator-hudi] bvaradar commented on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#issuecomment-612752623 @vinothchandar : Addressed comments. Will merge once the CI passes.

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407320551 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commi

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407320563 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commi

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407320535 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commi

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407320570 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/Write

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407320544 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commi

[jira] [Updated] (HUDI-30) Explore support for Spark Datasource V2

2020-04-12 Thread Yanjia Gary Li (Jira)
[ https://issues.apache.org/jira/browse/HUDI-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanjia Gary Li updated HUDI-30: --- Status: In Progress (was: Open) > Explore support for Spark Datasource V2 > ---

[jira] [Assigned] (HUDI-30) Explore support for Spark Datasource V2

2020-04-12 Thread Yanjia Gary Li (Jira)
[ https://issues.apache.org/jira/browse/HUDI-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanjia Gary Li reassigned HUDI-30: -- Assignee: Yanjia Gary Li > Explore support for Spark Datasource V2 >

[jira] [Created] (HUDI-788) Hudi writer and Hudi Reader split

2020-04-12 Thread wangmeng (Jira)
wangmeng created HUDI-788: - Summary: Hudi writer and Hudi Reader split Key: HUDI-788 URL: https://issues.apache.org/jira/browse/HUDI-788 Project: Apache Hudi (incubating) Issue Type: Improvement

[GitHub] [incubator-hudi] lamber-ken commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
lamber-ken commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1509#issuecomment-612738631 Hi @liujianhuiouc, thanks for your contribution, your email may be wrong, check it `git config --list | grep email`.

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #246

2020-04-12 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.36 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/conf: logging settings.xml toolchains.xml /home/jenkins/tools/maven/apache-maven-3.5.

[GitHub] [incubator-hudi] liujianhuiouc commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
liujianhuiouc commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1509#issuecomment-612734787 @n3nash help to merge that This is an automated me

[GitHub] [incubator-hudi] vinothchandar merged pull request #1510: [HUDI-786] Disabling flaky test in InlineFileSystem

2020-04-12 Thread GitBox
vinothchandar merged pull request #1510: [HUDI-786] Disabling flaky test in InlineFileSystem URL: https://github.com/apache/incubator-hudi/pull/1510 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-hudi] superguhua commented on issue #143: Tracking ticket for folks to be added to slack group

2020-04-12 Thread GitBox
superguhua commented on issue #143: Tracking ticket for folks to be added to slack group URL: https://github.com/apache/incubator-hudi/issues/143#issuecomment-612722711 Please, add me supergu...@163.com Thanks! This is an

[incubator-hudi] branch master updated: [MINOR] Disabling flaky test in InlineFileSystem (#1510)

2020-04-12 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new 447ba3b [MINOR] Disabling flaky test in

[jira] [Updated] (HUDI-786) InlineFileSystem.read API should ensure content beyond inline length gets an EOF

2020-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-786: Labels: pull-request-available (was: ) > InlineFileSystem.read API should ensure content beyond inli

[GitHub] [incubator-hudi] nsivabalan opened a new pull request #1510: [HUDI-786] Disabling flaky test in InlineFileSystem

2020-04-12 Thread GitBox
nsivabalan opened a new pull request #1510: [HUDI-786] Disabling flaky test in InlineFileSystem URL: https://github.com/apache/incubator-hudi/pull/1510 - Disabling flaky test in InlineFileSystem. Need time to work on investigating and put up a fix. This pull request is a trivial re

[GitHub] [incubator-hudi] vinothchandar commented on issue #1498: Migrating parquet table to hudi issue [SUPPORT]

2020-04-12 Thread GitBox
vinothchandar commented on issue #1498: Migrating parquet table to hudi issue [SUPPORT] URL: https://github.com/apache/incubator-hudi/issues/1498#issuecomment-612709170 Few clarifications: >For initial bench-marking we generate standard tpch data Is it possible to share the

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand

2020-04-12 Thread GitBox
yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand URL: https://github.com/apache/incubator-hudi/pull/1449#discussion_r407278226 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestCleansCommand.java ## @@ -0,0

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand

2020-04-12 Thread GitBox
yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand URL: https://github.com/apache/incubator-hudi/pull/1449#discussion_r407278986 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestCleansCommand.java ## @@ -0,0

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand

2020-04-12 Thread GitBox
yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand URL: https://github.com/apache/incubator-hudi/pull/1449#discussion_r407278779 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestCleansCommand.java ## @@ -0,0

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand

2020-04-12 Thread GitBox
yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand URL: https://github.com/apache/incubator-hudi/pull/1449#discussion_r407278439 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestCleansCommand.java ## @@ -0,0

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand

2020-04-12 Thread GitBox
yanghua commented on a change in pull request #1449: [HUDI-698]Add unit test for CleansCommand URL: https://github.com/apache/incubator-hudi/pull/1449#discussion_r407278918 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestCleansCommand.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on issue #1174: [HUDI-96]: Implemented command line options instead of positional arguments for CLI commands

2020-04-12 Thread GitBox
vinothchandar commented on issue #1174: [HUDI-96]: Implemented command line options instead of positional arguments for CLI commands URL: https://github.com/apache/incubator-hudi/pull/1174#issuecomment-612703547 @pratyakshsharma @n3nash this has been around for sometime.. does @hddong also

[GitHub] [incubator-hudi] vinothchandar edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
vinothchandar edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-612703386 @lamber-ken what you are testing is the worst case workload for upsert.. i.e all updates.. Thanks for testing it out.. It seems

[GitHub] [incubator-hudi] vinothchandar commented on issue #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
vinothchandar commented on issue #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-612703386 @lamber-ken what you are testing is the worst case workload for upsert.. i.e all updates.. Thanks for testing it out.. It seems like joi

[GitHub] [incubator-hudi] vinothchandar merged pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema

2020-04-12 Thread GitBox
vinothchandar merged pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema URL: https://github.com/apache/incubator-hudi/pull/1427 This is an automated me

[incubator-hudi] branch master updated: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema (#1427)

2020-04-12 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new 6d7ca2c [HUDI-727]: Copy default values

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407273922 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.jav

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407274513 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/H

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407274239 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/D

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407273794 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.jav

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407274109 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/checkpointing/I

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407274259 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/H

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407272545 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407272307 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407272044 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407272746 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407273467 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/

[GitHub] [incubator-hudi] bvaradar commented on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#issuecomment-612693953 @vinothchandar : Addressed review comments. Please take a look when you get a chance. -

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407267696 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commi

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
codecov-io edited a comment on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#issuecomment-610761048 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1495?src=pr&el=h1) Report

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
codecov-io edited a comment on issue #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#issuecomment-610761048 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1495?src=pr&el=h1) Report

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407252846 ## File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieWrite

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407252832 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commi

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407252838 ## File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieWrite

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407252843 ## File path: hudi-client/src/main/java/org/apache/hudi/client/AbstractHoo

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407252830 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/commi

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407252828 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/Write

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package

2020-04-12 Thread GitBox
bvaradar commented on a change in pull request #1495: [HUDI-770] Organize upsert/insert API implementation under a single package URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r407252820 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/Write

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

2020-04-12 Thread GitBox
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5 URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report > Merging [#1504](https://codecov.

[GitHub] [incubator-hudi] xushiyan edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

2020-04-12 Thread GitBox
xushiyan edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5 URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612666380 > hi.. Wondering why codecov reports lower coverage? This will be a problem that we need to resolve early on.. thoughts?

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
garyli1019 commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407244940 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/Delt

[GitHub] [incubator-hudi] pratyakshsharma commented on issue #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema

2020-04-12 Thread GitBox
pratyakshsharma commented on issue #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema URL: https://github.com/apache/incubator-hudi/pull/1427#issuecomment-612667219 @vinothchandar please take a pass. -

[GitHub] [incubator-hudi] xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

2020-04-12 Thread GitBox
xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5 URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612666380 > hi.. Wondering why codecov reports lower coverage? This will be a problem that we need to resolve early on.. thoughts? @vinothc

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
lamber-ken edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-612580029 hi @nsivabalan, first of all, amazing job 👍 👍 tested with same dataset provided in #1469 From the spark stage ui, we can see

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r407235240 ## File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieSimpleIndex.java ## @@ -0,0 +1,

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r407235052 ## File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieSimpleIndex.java ## @@ -0,0 +1,

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r407234877 ## File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieSimpleIndex.java ## @@ -0,0 +1,

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407233504 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/D

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate checkpoint provider with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407233388 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.jav

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource URL: https://github.com/apache/incubator-hudi/pull/1500#discussion_r407232918 ## File path: hudi-spark/src/test/java/DataSourceUtilsTest.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource URL: https://github.com/apache/incubator-hudi/pull/1500#discussion_r407232758 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtil

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource URL: https://github.com/apache/incubator-hudi/pull/1500#discussion_r407232824 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtil

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource URL: https://github.com/apache/incubator-hudi/pull/1500#discussion_r407233044 ## File path: hudi-spark/src/test/java/org/apache/hudi/table/NoOpBul

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource

2020-04-12 Thread GitBox
vinothchandar commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource URL: https://github.com/apache/incubator-hudi/pull/1500#discussion_r407232596 ## File path: hudi-client/src/main/java/org/apache/hudi/config/Hoodi

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

2020-04-12 Thread GitBox
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5 URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report > Merging [#1504](https://codecov.

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema

2020-04-12 Thread GitBox
codecov-io edited a comment on issue #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema URL: https://github.com/apache/incubator-hudi/pull/1427#issuecomment-601680873 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/14

[GitHub] [incubator-hudi] ahmed-elfar commented on issue #1498: Migrating parquet table to hudi issue [SUPPORT]

2020-04-12 Thread GitBox
ahmed-elfar commented on issue #1498: Migrating parquet table to hudi issue [SUPPORT] URL: https://github.com/apache/incubator-hudi/issues/1498#issuecomment-612650421 @vinothchandar Thank you very much for your answer and help, and everyone participated to resolve the issue. We alre

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
codecov-io edited a comment on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1509#issuecomment-612629725 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1509?src=pr&el=h1) Report > Merging [#1509](h

[GitHub] [incubator-hudi] codecov-io commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
codecov-io commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1509#issuecomment-612629725 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1509?src=pr&el=h1) Report > Merging [#1509](https://

[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1174: [HUDI-96]: Implemented command line options instead of positional arguments for CLI commands

2020-04-12 Thread GitBox
pratyakshsharma commented on a change in pull request #1174: [HUDI-96]: Implemented command line options instead of positional arguments for CLI commands URL: https://github.com/apache/incubator-hudi/pull/1174#discussion_r407205799 ## File path: hudi-cli/src/main/java/org/apache/h

[GitHub] [incubator-hudi] liujianhuiouc commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
liujianhuiouc commented on issue #1509: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1509#issuecomment-612623104 the origin pull is https://github.com/apache/incubator-hudi/pull/1216 -

[GitHub] [incubator-hudi] liujianhuiouc opened a new pull request #1509: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
liujianhuiouc opened a new pull request #1509: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1509 add insert info with insert records num in the HoodieCommitMeta. because of the file id is unknown, set it as empty string

[jira] [Assigned] (HUDI-777) Update Deltastreamer param description for --target-table

2020-04-12 Thread Iftach Schonbaum (Jira)
[ https://issues.apache.org/jira/browse/HUDI-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iftach Schonbaum reassigned HUDI-777: - Assignee: Iftach Schonbaum > Update Deltastreamer param description for --target-table > -

[GitHub] [incubator-hudi] liujianhuiouc closed pull request #1216: [HUDI-525] lack of insert info in delta_commit inflight

2020-04-12 Thread GitBox
liujianhuiouc closed pull request #1216: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1216 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema

2020-04-12 Thread GitBox
pratyakshsharma commented on a change in pull request #1427: [HUDI-727]: Copy default values of fields if not present when rewriting incoming record with new schema URL: https://github.com/apache/incubator-hudi/pull/1427#discussion_r407199166 ## File path: hudi-common/src/main/java

[jira] [Resolved] (HUDI-782) Add support for aliyun OSS

2020-04-12 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf resolved HUDI-782. Resolution: Fixed Fixed via master: 5d717a28f45137bea71dffa31b0ae7ccbf1bda00 > Add support for aliyun OSS >

[jira] [Updated] (HUDI-738) Add error msg in DeltaStreamer if `filterDupes=true` is enabled for `operation=UPSERT`.

2020-04-12 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf updated HUDI-738: --- Fix Version/s: 0.6.0 > Add error msg in DeltaStreamer if `filterDupes=true` is enabled for > `operation=UPSERT`. > -

[jira] [Updated] (HUDI-758) Modify Integration test to include incremental queries on RO, RT views

2020-04-12 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf updated HUDI-758: --- Fix Version/s: 0.6.0 > Modify Integration test to include incremental queries on RO, RT views > ---

[incubator-hudi] branch asf-site updated: Travis CI build asf-site

2020-04-12 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new 93eef62 Travis CI build asf-site 93

[jira] [Updated] (HUDI-740) Fix can not specify the sparkMaster and code clean for SparkUtil

2020-04-12 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf updated HUDI-740: --- Fix Version/s: 0.6.0 > Fix can not specify the sparkMaster and code clean for SparkUtil > -

[incubator-hudi] branch asf-site updated: [HUDI-782] Add doc for OSS filesystem (#1508)

2020-04-12 Thread leesf
This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new fbb83fe [HUDI-782] Add doc for OSS f

[GitHub] [incubator-hudi] leesf merged pull request #1508: [HUDI-782] Add doc for OSS filesystem

2020-04-12 Thread GitBox
leesf merged pull request #1508: [HUDI-782] Add doc for OSS filesystem URL: https://github.com/apache/incubator-hudi/pull/1508 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
lamber-ken edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-612580029 hi @nsivabalan, first of all, amazing job 👍 👍 tested with same dataset provided in #1469 From the spark stage ui, we can see

[GitHub] [incubator-hudi] lamber-ken commented on issue #1402: [WIP][HUDI-407] Adding Simple Index

2020-04-12 Thread GitBox
lamber-ken commented on issue #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-612580029 hi @nsivabalan, first of all, amazing job 👍 👍 Test with same dataset provided in #1469 ![image](https://user-images.githubu