[GitHub] [hudi] veenaypatil commented on pull request #2998: [HUDI-1426] Rename classname in camel case format

2021-05-29 Thread GitBox
veenaypatil commented on pull request #2998: URL: https://github.com/apache/hudi/pull/2998#issuecomment-850940456 @leesf in which module do we maintain the doc ? is it a different repo ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hudi] pratyakshsharma commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

2021-05-29 Thread GitBox
pratyakshsharma commented on pull request #2768: URL: https://github.com/apache/hudi/pull/2768#issuecomment-850885803 > @vingov for an extra pair of eyes. @pratyakshsharma any testing done for the PR? any way to add a test for the tool? No I have not done any testing. Currently

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] pratyakshsharma commented on pull request #2967: Added blog for Hudi cleaner service

2021-05-29 Thread GitBox
pratyakshsharma commented on pull request #2967: URL: https://github.com/apache/hudi/pull/2967#issuecomment-850883744 @nsivabalan Please ignore run command section coming twice. That is because of the way screenshots are taken. -- This is an automated message from the Apache Git

[GitHub] [hudi] pratyakshsharma commented on pull request #2967: Added blog for Hudi cleaner service

2021-05-29 Thread GitBox
pratyakshsharma commented on pull request #2967: URL: https://github.com/apache/hudi/pull/2967#issuecomment-850883551 https://user-images.githubusercontent.com/30863489/120081999-1145ec80-c0de-11eb-9280-a91d260a126f.png;>

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2542: [WIP] Global consistency

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2542: URL: https://github.com/apache/hudi/pull/2542#issuecomment-849630457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2542: [WIP] Global consistency

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2542: URL: https://github.com/apache/hudi/pull/2542#issuecomment-849630457 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2542: [WIP] Global consistency

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2542: URL: https://github.com/apache/hudi/pull/2542#issuecomment-849630457 #

[hudi] branch master updated: [HUDI-1879] Support Partition Prune For MergeOnRead Snapshot Table (#2926)

2021-05-29 Thread garyli
This is an automated email from the ASF dual-hosted git repository. garyli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new dcd7c33 [HUDI-1879] Support Partition Prune For

[GitHub] [hudi] garyli1019 merged pull request #2926: [HUDI-1879] Support Partition Prune For MergeOnRead Snapshot Table

2021-05-29 Thread GitBox
garyli1019 merged pull request #2926: URL: https://github.com/apache/hudi/pull/2926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hudi] arun990 opened a new issue #3009: Dependency error when attempt to build Hudi from git source ..

2021-05-29 Thread GitBox
arun990 opened a new issue #3009: URL: https://github.com/apache/hudi/issues/3009 Hi, Followed the steps to get the hudi soruce from git and build it and getting the build failure error as mentioned below: Please help. [INFO] Hudi ...

[GitHub] [hudi] codope commented on pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-29 Thread GitBox
codope commented on pull request #2915: URL: https://github.com/apache/hudi/pull/2915#issuecomment-850826058 > @codope : all feedback addressed? can we review. or do ping us here once its ready for review. @nsivabalan Almost all comments are addressed. One remaining is regarding

[GitHub] [hudi] wangxianghu commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-29 Thread GitBox
wangxianghu commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r641933205 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -72,8 +71,11 @@ public static final

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-29 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r641931702 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -72,8 +71,11 @@ public static final

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-29 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r641931227 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -72,8 +71,11 @@ public static final

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-29 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[hudi] branch master updated (974b476 -> 0709c62)

2021-05-29 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from 974b476 [HUDI-1940] Add SqlQueryBasedTransformer unit test (#3004) add 0709c62 [HUDI-1800] Exclude file

[GitHub] [hudi] nsivabalan merged pull request #2902: [HUDI-1800] Exclude file slices in pending compaction when performing small file sizing

2021-05-29 Thread GitBox
nsivabalan merged pull request #2902: URL: https://github.com/apache/hudi/pull/2902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hudi] nsivabalan commented on pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-29 Thread GitBox
nsivabalan commented on pull request #2915: URL: https://github.com/apache/hudi/pull/2915#issuecomment-850821638 @codope : all feedback addressed? can we review. or do ping us here once its ready for review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] nsivabalan commented on a change in pull request #2967: Added blog for Hudi cleaner service

2021-05-29 Thread GitBox
nsivabalan commented on a change in pull request #2967: URL: https://github.com/apache/hudi/pull/2967#discussion_r641926942 ## File path: docs/_posts/2021-05-28-employing-right-configurations-for-hudi-cleaner.md ## @@ -0,0 +1,106 @@ +--- +title: "Employing correct

[GitHub] [hudi] nsivabalan commented on a change in pull request #2438: [HUDI-1447] DeltaStreamer kafka source supports consuming from specified timestamp

2021-05-29 Thread GitBox
nsivabalan commented on a change in pull request #2438: URL: https://github.com/apache/hudi/pull/2438#discussion_r641925742 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java ## @@ -326,6 +328,16 @@ private boolean

[GitHub] [hudi] veenaypatil commented on pull request #2998: [HUDI-1426] Rename classname in camel case format

2021-05-29 Thread GitBox
veenaypatil commented on pull request #2998: URL: https://github.com/apache/hudi/pull/2998#issuecomment-850810460 Yes sure, will create a PR for correcting doc, closing this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hudi] veenaypatil closed pull request #2998: [HUDI-1426] Rename classname in camel case format

2021-05-29 Thread GitBox
veenaypatil closed pull request #2998: URL: https://github.com/apache/hudi/pull/2998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hudi] leesf commented on pull request #2998: [HUDI-1426] Rename classname in camel case format

2021-05-29 Thread GitBox
leesf commented on pull request #2998: URL: https://github.com/apache/hudi/pull/2998#issuecomment-850806372 > @leesf I agree, this will be breaking change once users upgrade to new version, I think if we don't want to do this change, we should at least update the document to correct class