nsivabalan commented on a change in pull request #2993:
URL: https://github.com/apache/hudi/pull/2993#discussion_r641931702
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -72,8 +71,11 @@
public static final String PRECOMBINE_FIELD_PROP =
"hoodie.datasource.write.precombine.field";
public static final String WRITE_PAYLOAD_CLASS =
"hoodie.datasource.write.payload.class";
public static final String DEFAULT_WRITE_PAYLOAD_CLASS =
OverwriteWithLatestAvroPayload.class.getName();
+
public static final String KEYGENERATOR_CLASS_PROP =
"hoodie.datasource.write.keygenerator.class";
- public static final String DEFAULT_KEYGENERATOR_CLASS =
SimpleAvroKeyGenerator.class.getName();
+ public static final String KEYGENERATOR_TYPE_PROP =
"hoodie.datasource.write.keygenerator.type";
+ public static final String DEFAULT_KEYGENERATOR_TYPE = "simple";
Review comment:
I would propose to may be deprecate the old config. and convert the old
one to new one (within parametersWithWriteDefaults or somewhere). Let's not
have two conflicting configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
