[GitHub] [hudi] PrabhuJoseph commented on a diff in pull request #8512: [HUDI-6057] Support Flink 1.17

2023-04-26 Thread via GitHub
PrabhuJoseph commented on code in PR #8512: URL: https://github.com/apache/hudi/pull/8512#discussion_r1178045112 ## pom.xml: ## @@ -2373,9 +2374,23 @@ + + flink1.17 + Review Comment: Done. -- This is an automated message from the Apache

[GitHub] [hudi] PrabhuJoseph commented on a diff in pull request #8512: [HUDI-6057] Support Flink 1.17

2023-04-26 Thread via GitHub
PrabhuJoseph commented on code in PR #8512: URL: https://github.com/apache/hudi/pull/8512#discussion_r1177726966 ## scripts/release/deploy_staging_jars.sh: ## @@ -75,6 +75,7 @@ declare -a ALL_VERSION_OPTS=( "-Dscala-2.12 -Dflink1.14 -Davro.version=1.10.0 -pl

[GitHub] [hudi] PrabhuJoseph commented on a diff in pull request #8512: [HUDI-6057] Support Flink 1.17

2023-04-26 Thread via GitHub
PrabhuJoseph commented on code in PR #8512: URL: https://github.com/apache/hudi/pull/8512#discussion_r1177726006 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/sort/SortOperator.java: ## @@ -89,7 +95,7 @@ public void open() throws Exception {

[GitHub] [hudi] PrabhuJoseph commented on a diff in pull request #8512: [HUDI-6057] Support Flink 1.17

2023-04-24 Thread via GitHub
PrabhuJoseph commented on code in PR #8512: URL: https://github.com/apache/hudi/pull/8512#discussion_r1175582627 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/sort/SortOperator.java: ## @@ -89,7 +95,7 @@ public void open() throws Exception {

[GitHub] [hudi] PrabhuJoseph commented on a diff in pull request #8512: [HUDI-6057] Support Flink 1.17

2023-04-24 Thread via GitHub
PrabhuJoseph commented on code in PR #8512: URL: https://github.com/apache/hudi/pull/8512#discussion_r1175553090 ## pom.xml: ## @@ -2373,6 +2374,17 @@ + + flink1.17 + +1.5.6 + + + + flink1.17 + +

[GitHub] [hudi] PrabhuJoseph commented on a diff in pull request #8512: [HUDI-6057] Support Flink 1.17

2023-04-20 Thread via GitHub
PrabhuJoseph commented on code in PR #8512: URL: https://github.com/apache/hudi/pull/8512#discussion_r1173064499 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/sort/SortOperator.java: ## @@ -89,7 +95,7 @@ public void open() throws Exception {