[GitHub] [hudi] YannByron commented on a diff in pull request #7196: [MINOR] move logic for deleting active instant to HoodieActiveTimeline

YannByron commented on code in PR #7196: URL: https://github.com/apache/hudi/pull/7196#discussion_r1032443092 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java: ## @@ -267,21 +267,27 @@ public void deleteCompactionRequested(HoodieInstan

[GitHub] [hudi] YannByron commented on a diff in pull request #7196: [MINOR] move logic for deleting active instant to HoodieActiveTimeline

YannByron commented on code in PR #7196: URL: https://github.com/apache/hudi/pull/7196#discussion_r1032441668 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java: ## @@ -267,21 +267,27 @@ public void deleteCompactionRequested(HoodieInstan

[GitHub] [hudi] YannByron commented on a diff in pull request #7196: [MINOR] move logic for deleting active instant to HoodieActiveTimeline

YannByron commented on code in PR #7196: URL: https://github.com/apache/hudi/pull/7196#discussion_r1032441151 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java: ## @@ -570,12 +570,24 @@ private boolean deleteArchivedInstants(List

[GitHub] [hudi] YannByron commented on a diff in pull request #7196: [MINOR] move logic for deleting active instant to HoodieActiveTimeline

YannByron commented on code in PR #7196: URL: https://github.com/apache/hudi/pull/7196#discussion_r1032440004 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java: ## @@ -570,12 +570,24 @@ private boolean deleteArchivedInstants(List

[GitHub] [hudi] YannByron commented on a diff in pull request #7196: [MINOR] move logic for deleting active instant to HoodieActiveTimeline

YannByron commented on code in PR #7196: URL: https://github.com/apache/hudi/pull/7196#discussion_r1022483387 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java: ## @@ -257,46 +257,36 @@ public static void deleteInstantFile(FileSystem fs

[GitHub] [hudi] YannByron commented on a diff in pull request #7196: [MINOR] move logic for deleting active instant to HoodieActiveTimeline

YannByron commented on code in PR #7196: URL: https://github.com/apache/hudi/pull/7196#discussion_r1022461347 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java: ## @@ -257,46 +257,36 @@ public static void deleteInstantFile(FileSystem fs