[GitHub] [hudi] YannByron commented on pull request #4083: [HUDI-2837] The original hoodie.table.name should be maintained in Spark SQL

2022-01-08 Thread GitBox
YannByron commented on pull request #4083: URL: https://github.com/apache/hudi/pull/4083#issuecomment-1008236642 @dongkelun LGTM, just left some minor comments. @xushiyan Further review whether this strategy makes sense. -- This is an automated message from the Apache Git Service. To

[GitHub] [hudi] YannByron commented on pull request #4083: [HUDI-2837] The original hoodie.table.name should be maintained in Spark SQL

2021-12-28 Thread GitBox
YannByron commented on pull request #4083: URL: https://github.com/apache/hudi/pull/4083#issuecomment-1002380413 @dongkelun @xushiyan I offer another solution to discuss. Query incrementally in hive need to set `hoodie.%s.consume.start.timestamp` which is used in

[GitHub] [hudi] YannByron commented on pull request #4083: [HUDI-2837] The original hoodie.table.name should be maintained in Spark SQL

2021-12-27 Thread GitBox
YannByron commented on pull request #4083: URL: https://github.com/apache/hudi/pull/4083#issuecomment-1001899518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hudi] YannByron commented on pull request #4083: [HUDI-2837] The original hoodie.table.name should be maintained in Spark SQL

2021-12-27 Thread GitBox
YannByron commented on pull request #4083: URL: https://github.com/apache/hudi/pull/4083#issuecomment-1001894512 I'm sorry of not supporting this pr to solve the problems that `set the start query time of the table` and `query incrementally`. Some points we should think about: 1. as