alexeykudinkin commented on code in PR #7490:
URL: https://github.com/apache/hudi/pull/7490#discussion_r1051282103
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -1556,6 +1556,47 @@ public void testColStatsPrefixLookup() throws
IOException {
}
}
+
+ @Test
+ public void testRollbackinMDT() throws IOException {
+ tableType = COPY_ON_WRITE;
+ initPath();
+ init(tableType);
+ HoodieSparkEngineContext engineContext = new HoodieSparkEngineContext(jsc);
+ SparkRDDWriteClient client = new SparkRDDWriteClient(engineContext,
writeConfig);
+ // Write 1 (Bulk insert)
+ String commit1 = HoodieActiveTimeline.createNewInstantTime();
+ String commit2 = HoodieActiveTimeline.createNewInstantTime(5);
+ List<HoodieRecord> records = dataGen.generateInserts(commit1, 20);
+ client.startCommitWithTime(commit1);
+ List<WriteStatus> writeStatuses =
client.bulkInsert(jsc.parallelize(records, 1), commit1).collect();
+ assertNoWriteErrors(writeStatuses);
+
+ // Write 2 (inserts)
+ client.startCommitWithTime(commit2);
+
+ records = dataGen.generateInserts(commit2, 20);
+ writeStatuses = client.insert(jsc.parallelize(records, 1),
commit2).collect();
+ assertNoWriteErrors(writeStatuses);
+ // remove latest completed delta commit from MDT.
+ Path toDelete = new Path(metaClient.getMetaPath() + "/metadata/.hoodie/" +
commit2 + ".deltacommit");
+ metaClient.getFs().delete(toDelete);
+
+ // Write 3 (updates)
+ client = new SparkRDDWriteClient(engineContext, writeConfig);
+ String commit3 = HoodieActiveTimeline.createNewInstantTime();
+ client.startCommitWithTime(commit3);
+ records = dataGen.generateUniqueUpdates(commit3, 10);
+ writeStatuses = client.upsert(jsc.parallelize(records, 1),
commit3).collect();
+ assertNoWriteErrors(writeStatuses);
+
+ // ensure that 000003 is after rollback of the partially failed 2nd commit.
+ HoodieTableMetaClient metadataMetaClient =
HoodieTableMetaClient.builder().setBasePath(metaClient.getMetaPath()+"/metadata/").setConf(metaClient.getHadoopConf()).build();
+ List<HoodieInstant> mdtInstants =
metadataMetaClient.reloadActiveTimeline().getInstants().collect(Collectors.toList());
Review Comment:
This doesn't seem to be used. Where do we do validation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
