[GitHub] [hudi] boneanxs commented on a diff in pull request #5679: [MINOR] Fix the issue when handling conf hoodie.datasource.write.operation=bulk_insert in sql mode

[GitBox]

boneanxs commented on code in PR #5679:
URL: https://github.com/apache/hudi/pull/5679#discussion_r882258541


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -129,7 +129,8 @@ trait ProvidesHoodieConfig extends Logging {
       .getOrElse(classOf[ComplexKeyGenerator].getCanonicalName)
 
     val enableBulkInsert = 
parameters.getOrElse(DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.key,
-      DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.defaultValue()).toBoolean
+      DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.defaultValue()).toBoolean 
||
+      
parameters.get(DataSourceWriteOptions.OPERATION.key).exists(_.equalsIgnoreCase(WriteOperationType.BULK_INSERT.value))

Review Comment:
   Sry, don't get your point, could you please explain more? Do you mean I 
should change like this?
   
   ```scala
   val enableBulkInsert = 
parameters.get(DataSourceWriteOptions.OPERATION.key).exists(_.equalsIgnoreCase(WriteOperationType.BULK_INSERT.value))
 || parameters.getOrElse(DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.key,
         DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.defaultValue()).toBoolean
   ```



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -129,7 +129,8 @@ trait ProvidesHoodieConfig extends Logging {
       .getOrElse(classOf[ComplexKeyGenerator].getCanonicalName)
 
     val enableBulkInsert = 
parameters.getOrElse(DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.key,
-      DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.defaultValue()).toBoolean
+      DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.defaultValue()).toBoolean 
||
+      
parameters.get(DataSourceWriteOptions.OPERATION.key).exists(_.equalsIgnoreCase(WriteOperationType.BULK_INSERT.value))

Review Comment:
   Sry, don't get your point, could you please explain more? Do you mean I 
should change like this?
   
   ```scala
   val enableBulkInsert = 
parameters.get(DataSourceWriteOptions.OPERATION.key).exists(_.equalsIgnoreCase(WriteOperationType.BULK_INSERT.value))
 || parameters.getOrElse(DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.key,
         DataSourceWriteOptions.SQL_ENABLE_BULK_INSERT.defaultValue()).toBoolean
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org