[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-07-24 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1271800816 ## hudi-spark-datasource/hudi-spark2/src/main/scala/org/apache/spark/sql/adapter/Spark2Adapter.scala: ## @@ -186,4 +186,13 @@ class Spark2Adapter extends SparkAdapter {

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-06-08 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1223761168 ## hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java: ## @@ -50,20 +56,25 @@ /** * Implementation of {@link HoodieTableMetadata}

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-06-08 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1222992789 ## hudi-common/src/main/java/org/apache/hudi/metadata/AbstractHoodieTableMetadata.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-06-08 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1222992789 ## hudi-common/src/main/java/org/apache/hudi/metadata/AbstractHoodieTableMetadata.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-06-08 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1222499227 ## hudi-common/src/main/java/org/apache/hudi/metadata/AbstractHoodieTableMetadata.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-06-08 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1222426029 ## hudi-common/src/main/java/org/apache/hudi/internal/schema/utils/Conversions.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-06-06 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1220712391 ## hudi-common/src/main/java/org/apache/hudi/metadata/AbstractHoodieTableMetadata.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-06-06 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1220712391 ## hudi-common/src/main/java/org/apache/hudi/metadata/AbstractHoodieTableMetadata.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-31 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1211261314 ## hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java: ## @@ -96,11 +109,32 @@ public List getPartitionPathWithPathPrefixes(List

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-23 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1201575964 ## hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java: ## @@ -96,11 +109,32 @@ public List getPartitionPathWithPathPrefixes(List

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-23 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1201575964 ## hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java: ## @@ -96,11 +109,32 @@ public List getPartitionPathWithPathPrefixes(List

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-22 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r117268 ## hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java: ## @@ -96,11 +109,32 @@ public List getPartitionPathWithPathPrefixes(List

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-22 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r117268 ## hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java: ## @@ -96,11 +109,32 @@ public List getPartitionPathWithPathPrefixes(List

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-21 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1199888295 ## hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java: ## @@ -121,14 +184,24 @@ private List getPartitionPathWithPathPrefix(String

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-12 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1191976171 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/FilterGenVisitor.java: ## @@ -42,9 +43,10 @@ private String quoteStringLiteral(String value) { }

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-12 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1191975737 ## hudi-spark-datasource/hudi-spark2/src/main/scala/org/apache/spark/sql/adapter/Spark2Adapter.scala: ## @@ -186,4 +186,13 @@ class Spark2Adapter extends SparkAdapter {

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-12 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1191973525 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/SparkHoodieTableFileIndex.scala: ## @@ -307,8 +318,20 @@ class SparkHoodieTableFileIndex(spark:

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-12 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1191878586 ## hudi-common/src/main/java/org/apache/hudi/expression/Expression.java: ## @@ -40,14 +51,19 @@ public enum Operator { } } - private final List children; +

[GitHub] [hudi] boneanxs commented on a diff in pull request #8452: [HUDI-6077] Add more partition push down filters

2023-05-03 Thread via GitHub
boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1184492603 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/storage/row/TestHoodieRowCreateHandle.java: ## @@ -190,16 +189,8 @@ public void