[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-10-26 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r1006287106 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieColumnProjectionUtils.java: ## @@ -109,4 +109,22 @@ public static List>

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-06-16 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r899667357 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -76,8 +76,10 @@ public class HiveSyncConfig extends HoodieSyncConfig {

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-06-16 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r899666955 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HoodieAvroParquetInputFormat.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-06-16 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r899667357 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -76,8 +76,10 @@ public class HiveSyncConfig extends HoodieSyncConfig {

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-06-16 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r899666955 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HoodieAvroParquetInputFormat.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-06-13 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r895736114 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HoodieAvroParquetInputFormat.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-06-13 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r895728574 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HoodieAvroParquetReader.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-06-13 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r895724346 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HoodieAvroParquetReader.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-27 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r883598776 ## hudi-common/src/main/java/org/apache/hudi/common/util/Option.java: ## @@ -76,6 +76,10 @@ public static Option of(T value) { return new Option<>(value); }

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-23 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r879378219 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieHiveUtils.java: ## @@ -146,4 +154,74 @@ public static List getIncrementalTableNames(JobContext job)

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-20 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r878161873 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HudiAvroParquetReader.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-20 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r878137673 ## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieColumnProjectionUtils.java: ## @@ -109,4 +109,25 @@ public static List>

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-15 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r873107531 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-14 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r873107531 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-14 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r872982532 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-14 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r872981445 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-14 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r872981445 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {

[GitHub] [hudi] cdmikechen commented on a diff in pull request #3391: [HUDI-83] Fix Timestamp/Date type read by Hive3

2022-05-11 Thread GitBox
cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r870837005 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {