[GitHub] [hudi] danny0405 commented on a diff in pull request #8079: [HUDI-5863] Fix HoodieMetadataFileSystemView serving stale view at the timeline server

2023-03-03 Thread via GitHub
danny0405 commented on code in PR #8079: URL: https://github.com/apache/hudi/pull/8079#discussion_r1125407040 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -181,22 +181,24 @@ private boolean isLocalViewBehind(Context ctx) {

[GitHub] [hudi] danny0405 commented on a diff in pull request #8079: [HUDI-5863] Fix HoodieMetadataFileSystemView serving stale view at the timeline server

2023-03-01 Thread via GitHub
danny0405 commented on code in PR #8079: URL: https://github.com/apache/hudi/pull/8079#discussion_r1122370993 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java: ## @@ -282,6 +286,20 @@ public void reset() { } } + /** +

[GitHub] [hudi] danny0405 commented on a diff in pull request #8079: [HUDI-5863] Fix HoodieMetadataFileSystemView serving stale view at the timeline server

2023-03-01 Thread via GitHub
danny0405 commented on code in PR #8079: URL: https://github.com/apache/hudi/pull/8079#discussion_r1122369457 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -187,12 +200,20 @@ private boolean syncIfLocalViewBehind(Context ctx)

[GitHub] [hudi] danny0405 commented on a diff in pull request #8079: [HUDI-5863] Fix HoodieMetadataFileSystemView serving stale view at the timeline server

2023-03-01 Thread via GitHub
danny0405 commented on code in PR #8079: URL: https://github.com/apache/hudi/pull/8079#discussion_r1121420324 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -187,12 +200,20 @@ private boolean syncIfLocalViewBehind(Context ctx)

[GitHub] [hudi] danny0405 commented on a diff in pull request #8079: [HUDI-5863] Fix HoodieMetadataFileSystemView serving stale view at the timeline server

2023-03-01 Thread via GitHub
danny0405 commented on code in PR #8079: URL: https://github.com/apache/hudi/pull/8079#discussion_r1121419697 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -187,12 +200,20 @@ private boolean syncIfLocalViewBehind(Context ctx)

[GitHub] [hudi] danny0405 commented on a diff in pull request #8079: [HUDI-5863] Fix HoodieMetadataFileSystemView serving stale view at the timeline server

2023-03-01 Thread via GitHub
danny0405 commented on code in PR #8079: URL: https://github.com/apache/hudi/pull/8079#discussion_r1121418704 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -151,30 +156,38 @@ public void stop() { * Determines if local

[GitHub] [hudi] danny0405 commented on a diff in pull request #8079: [HUDI-5863] Fix HoodieMetadataFileSystemView serving stale view at the timeline server

2023-03-01 Thread via GitHub
danny0405 commented on code in PR #8079: URL: https://github.com/apache/hudi/pull/8079#discussion_r1121416847 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java: ## @@ -282,6 +286,20 @@ public void reset() { } } + /** +