danny0405 commented on code in PR #8079:
URL: https://github.com/apache/hudi/pull/8079#discussion_r1125407040
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -181,22 +181,24 @@ private boolean isLocalViewBehind(Context ctx) {
* Syncs data-set view if local view is behind.
*/
private boolean syncIfLocalViewBehind(Context ctx) {
- if (isLocalViewBehind(ctx)) {
- String basePath =
ctx.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM);
- String lastKnownInstantFromClient =
ctx.queryParamAsClass(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS,
String.class).getOrDefault(HoodieTimeline.INVALID_INSTANT_TS);
- SyncableFileSystemView view = viewManager.getFileSystemView(basePath);
- synchronized (view) {
- if (isLocalViewBehind(ctx)) {
- HoodieTimeline localTimeline =
viewManager.getFileSystemView(basePath).getTimeline();
- LOG.info("Syncing view as client passed last known instant " +
lastKnownInstantFromClient
- + " as last known instant but server has the following last
instant on timeline :"
- + localTimeline.lastInstant());
- view.sync();
- return true;
- }
+ boolean result = false;
+ String basePath =
ctx.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM);
+ SyncableFileSystemView view = viewManager.getFileSystemView(basePath);
+ synchronized (view) {
+ if (isLocalViewBehind(ctx)) {
+
+ String lastKnownInstantFromClient = ctx.queryParamAsClass(
+ RemoteHoodieTableFileSystemView.LAST_INSTANT_TS, String.class)
+ .getOrDefault(HoodieTimeline.INVALID_INSTANT_TS);
+ HoodieTimeline localTimeline =
viewManager.getFileSystemView(basePath).getTimeline();
+ LOG.info("Syncing view as client passed last known instant " +
lastKnownInstantFromClient
+ + " as last known instant but server has the following last
instant on timeline :"
+ + localTimeline.lastInstant());
+ view.sync();
+ result = true;
Review Comment:
Can we return directly from this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
