[GitHub] [hudi] danny0405 commented on a diff in pull request #8546: [MINOR] Add log in flink compact/cluster commit sink for troubleshoot…

2023-04-26 Thread via GitHub
danny0405 commented on code in PR #8546: URL: https://github.com/apache/hudi/pull/8546#discussion_r1178572693 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -97,6 +97,11 @@ public void open(Configuration

[GitHub] [hudi] danny0405 commented on a diff in pull request #8546: [MINOR] Add log in flink compact/cluster commit sink for troubleshoot…

2023-04-25 Thread via GitHub
danny0405 commented on code in PR #8546: URL: https://github.com/apache/hudi/pull/8546#discussion_r1177310563 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionCommitSink.java: ## @@ -101,6 +101,12 @@ public void open(Configuration

[GitHub] [hudi] danny0405 commented on a diff in pull request #8546: [MINOR] Add log in flink compact/cluster commit sink for troubleshoot…

2023-04-25 Thread via GitHub
danny0405 commented on code in PR #8546: URL: https://github.com/apache/hudi/pull/8546#discussion_r1177245362 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -150,6 +159,13 @@ private void doCommit(String

[GitHub] [hudi] danny0405 commented on a diff in pull request #8546: [MINOR] Add log in flink compact/cluster commit sink for troubleshoot…

2023-04-25 Thread via GitHub
danny0405 commented on code in PR #8546: URL: https://github.com/apache/hudi/pull/8546#discussion_r1176706593 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -150,6 +159,13 @@ private void doCommit(String

[GitHub] [hudi] danny0405 commented on a diff in pull request #8546: [MINOR] Add log in flink compact/cluster commit sink for troubleshoot…

2023-04-24 Thread via GitHub
danny0405 commented on code in PR #8546: URL: https://github.com/apache/hudi/pull/8546#discussion_r1176009567 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -141,6 +141,15 @@ private void

[GitHub] [hudi] danny0405 commented on a diff in pull request #8546: [MINOR] Add log in flink compact/cluster commit sink for troubleshoot…

2023-04-23 Thread via GitHub
danny0405 commented on code in PR #8546: URL: https://github.com/apache/hudi/pull/8546#discussion_r1174732825 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java: ## @@ -120,6 +120,11 @@ private void