danny0405 commented on code in PR #8546: URL: https://github.com/apache/hudi/pull/8546#discussion_r1177310563
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionCommitSink.java: ########## @@ -101,6 +101,12 @@ public void open(Configuration parameters) throws Exception { @Override public void invoke(CompactionCommitEvent event, Context context) throws Exception { final String instant = event.getInstant(); + if (event.isFailed() || !this.conf.getBoolean(FlinkOptions.IGNORE_FAILED) + && event.getWriteStatuses().stream().anyMatch(writeStatus -> writeStatus.getTotalErrorRecords() > 0)) { + LOG.warn("Receive abnormal CompactionCommitEvent of instant " + instant + ", task ID is " + event.getTaskID() Review Comment: Can remove this `|| !this.conf.getBoolean(FlinkOptions.IGNORE_FAILED` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org