[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-06-02 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1215147991 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exceptio

[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-06-01 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1213860936 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exceptio

[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-06-01 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1212738284 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exceptio

[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-06-01 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1212707111 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exceptio

[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-05-31 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1212541100 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exceptio

[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-05-30 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1209968975 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exceptio

[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-05-28 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1208865367 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exceptio

[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

2023-05-27 Thread via GitHub
danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1208240329 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java: ## @@ -69,7 +70,7 @@ public class ClientIds implements AutoCloseable, Serializable