danny0405 commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1213860936
########## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ########## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exception { } } + @Test + void testAutoGenerateClient() { + Configuration conf = getConf(); + OptionsInference.setupClientId(conf); + assertNotNull(conf.getString(FlinkOptions.WRITE_CLIENT_ID), "auto generate client failed!"); + } Review Comment: > all writer will shared the ckp_meta How could that happen then providing the last client already sent the heartbeat? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org