[GitHub] [hudi] danny0405 commented on a diff in pull request #8863: [HUDI-6305] s3a parameters cannot be filtered

2023-06-06 Thread via GitHub
danny0405 commented on code in PR #8863: URL: https://github.com/apache/hudi/pull/8863#discussion_r1218971522 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -49,8 +48,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8863: [HUDI-6305] s3a parameters cannot be filtered

2023-06-05 Thread via GitHub
danny0405 commented on code in PR #8863: URL: https://github.com/apache/hudi/pull/8863#discussion_r1218836936 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -49,8 +48,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8863: [HUDI-6305] s3a parameters cannot be filtered

2023-06-02 Thread via GitHub
danny0405 commented on code in PR #8863: URL: https://github.com/apache/hudi/pull/8863#discussion_r1215143645 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -49,8 +48,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8863: [HUDI-6305] s3a parameters cannot be filtered

2023-06-02 Thread via GitHub
danny0405 commented on code in PR #8863: URL: https://github.com/apache/hudi/pull/8863#discussion_r1214049669 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -49,8 +48,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8863: [HUDI-6305] s3a parameters cannot be filtered

2023-06-02 Thread via GitHub
danny0405 commented on code in PR #8863: URL: https://github.com/apache/hudi/pull/8863#discussion_r1213988452 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -49,8 +48,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8863: [HUDI-6305] s3a parameters cannot be filtered

2023-06-01 Thread via GitHub
danny0405 commented on code in PR #8863: URL: https://github.com/apache/hudi/pull/8863#discussion_r1213851720 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -49,8 +48,7 @@ public static