[GitHub] [hudi] danny0405 commented on a diff in pull request #8863: [HUDI-6305] s3a parameters cannot be filtered

[via GitHub]

danny0405 commented on code in PR #8863:
URL: https://github.com/apache/hudi/pull/8863#discussion_r1214049669


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java:
##########
@@ -49,8 +48,7 @@ public static org.apache.hadoop.conf.Configuration 
getParquetConf(
    */
   public static org.apache.hadoop.conf.Configuration 
getHadoopConf(Configuration conf) {
     org.apache.hadoop.conf.Configuration hadoopConf = 
FlinkClientUtil.getHadoopConf();
-    Map<String, String> options = 
FlinkOptions.getPropertiesWithPrefix(conf.toMap(), HADOOP_PREFIX);
-    options.forEach(hadoopConf::set);
+    conf.toMap().forEach(hadoopConf::set);

Review Comment:
   Does these work for you?
   
   ```java
   hadoop.fs.s3a.access.key
   hadoop.fs.s3a.secret.key,
   hadoop.fs.s3a.endpoint,
   hadoop.fs.s3a.impl.disable.cache,
   hadoop.fs.s3a.impl,
   hadoop.fs.s3a.connection.maximum
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org