danny0405 commented on code in PR #9087: URL: https://github.com/apache/hudi/pull/9087#discussion_r1250442036
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/update/strategy/FlinkConsistentBucketUpdateStrategy.java: ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.sink.clustering.update.strategy; + +import org.apache.hudi.client.HoodieFlinkWriteClient; +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.model.HoodieAvroRecord; +import org.apache.hudi.common.model.HoodieFileGroupId; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.model.HoodieRecordLocation; +import org.apache.hudi.common.model.HoodieRecordPayload; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.table.timeline.HoodieTimeline; +import org.apache.hudi.common.util.ClusteringUtils; +import org.apache.hudi.common.util.ValidationUtils; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.index.bucket.ConsistentBucketIdentifier; +import org.apache.hudi.table.HoodieFlinkTable; +import org.apache.hudi.table.action.cluster.strategy.UpdateStrategy; +import org.apache.hudi.table.action.cluster.util.ConsistentHashingUpdateStrategyUtils; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Update strategy for consistent hashing bucket index. If updates to file groups that are under clustering are identified, then the current batch of records will route to both old and new file groups + * (i.e., dual write) + */ +public class FlinkConsistentBucketUpdateStrategy<T extends HoodieRecordPayload> extends UpdateStrategy<T, List<Pair<List<HoodieRecord>, String>>> { + + private static final Logger LOG = LoggerFactory.getLogger(FlinkConsistentBucketUpdateStrategy.class); + + private boolean initialized = false; + private List<String> indexKeyFields; + private Map<String, Pair<String, ConsistentBucketIdentifier>> partitionToIdentifier; + private String lastRefreshInstant = HoodieTimeline.INIT_INSTANT_TS; + Review Comment: I didn't see `lastRefreshInstant` is used anywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
