danny0405 commented on PR #8107:
URL: https://github.com/apache/hudi/pull/8107#issuecomment-1540027454
Tests have passed:
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16954&view=results
--
This is an automated message from the Apache Git Service.
To respo
danny0405 commented on PR #8107:
URL: https://github.com/apache/hudi/pull/8107#issuecomment-1538168229
Should be a flaky test:
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16934&view=logs&j=600e7de6-e133-5e69-e615-50ee129b3c08&t=bbbd7bcc-ae73-56b8-887a-cd2d6
danny0405 commented on PR #8107:
URL: https://github.com/apache/hudi/pull/8107#issuecomment-1537657119
Looks good! It is great if we can move the decision `
!props.containsKey(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key())
into a tool method in KeyGenUtils.autoGenerateRecordKeys(TypedP
danny0405 commented on PR #8107:
URL: https://github.com/apache/hudi/pull/8107#issuecomment-1537297965
And this one: `org.apache.hudi.TestDataSourceDefaults`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
danny0405 commented on PR #8107:
URL: https://github.com/apache/hudi/pull/8107#issuecomment-1537296681
Only one test failure:
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16905&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=e0ae894b-41c9-5f4b-7ed2-bdf524
danny0405 commented on PR #8107:
URL: https://github.com/apache/hudi/pull/8107#issuecomment-1532483205
> Need closure on wrapping the key generator impl as @danny0405 was
suggesting, among other things.
>
> @danny0405 we need to do this for Flink as well. thoughts?
Flink alread
