danny0405 commented on PR #8326: URL: https://github.com/apache/hudi/pull/8326#issuecomment-1496950173
> It's no longer "pre" combine/ deduplicate incoming batch, but rather combine on write I agree, the `preCombine` is kind of confusing and for the literal meanings, it seems to do the payload merging for in-mem records, while the `hoodie.payload.ordering.field` is more straight-forward at lest for the option name, we know that it can be used for both in-mem mering and base + delta combining. In general, `preCombine` is not a good name because it exposed the physical characteristic to users, no one is familiar with what a `Combine` or `preCombine` is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
