[GitHub] [hudi] dongkelun commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-08 Thread GitBox
dongkelun commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r966535607 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -539,4 +543,19 @@ public void handle(@NotNull Context context) throws

[GitHub] [hudi] dongkelun commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-07 Thread GitBox
dongkelun commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r965462117 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -539,4 +543,19 @@ public void handle(@NotNull Context context) throws

[GitHub] [hudi] dongkelun commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-07 Thread GitBox
dongkelun commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r965460402 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -539,4 +543,19 @@ public void handle(@NotNull Context context) throws

[GitHub] [hudi] dongkelun commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-07 Thread GitBox
dongkelun commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r965446536 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -539,4 +543,19 @@ public void handle(@NotNull Context context) throws

[GitHub] [hudi] dongkelun commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-07 Thread GitBox
dongkelun commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r964449710 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -502,14 +502,20 @@ public void handle(@NotNull Context context) throws

[GitHub] [hudi] dongkelun commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-06 Thread GitBox
dongkelun commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r964285634 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -502,14 +502,20 @@ public void handle(@NotNull Context context) throws

[GitHub] [hudi] dongkelun commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-06 Thread GitBox
dongkelun commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r964283533 ## hudi-common/src/main/avro/HoodieCleanMetadata.avsc: ## @@ -23,6 +23,7 @@ {"name": "timeTakenInMillis", "type": "long"}, {"name": "totalFilesDeleted",