[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-21 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r878689578 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala: ## @@ -763,4 +763,22 @@ class TestCreateTable extends

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-21 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r878690224 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala: ## @@ -763,4 +763,22 @@ class TestCreateTable extends

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-21 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r878689578 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala: ## @@ -763,4 +763,22 @@ class TestCreateTable extends

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-18 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r875597408 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala: ## @@ -763,4 +763,22 @@ class TestCreateTable extends

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-18 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r875510464 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala: ## @@ -763,4 +763,22 @@ class TestCreateTable extends

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-18 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r875509658 ## hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala: ## @@ -206,29 +236,17 @@ class HoodieCatalog extends

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-18 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r875507389 ## hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala: ## @@ -206,29 +236,17 @@ class HoodieCatalog extends

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5588: [HUDI-4100] CTAS failed to clean up when given an illegal MANAGED table definition

2022-05-15 Thread GitBox
jinxing64 commented on code in PR #5588: URL: https://github.com/apache/hudi/pull/5588#discussion_r873303190 ## hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala: ## @@ -192,8 +200,31 @@ class HoodieCatalog extends