[GitHub] [hudi] jonvex commented on a diff in pull request #8638: added new exception types

2023-05-24 Thread via GitHub
jonvex commented on code in PR #8638: URL: https://github.com/apache/hudi/pull/8638#discussion_r1204601709 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java: ## @@ -193,8 +201,8 @@ public Schema getTargetSchema() { String targetReg

[GitHub] [hudi] jonvex commented on a diff in pull request #8638: added new exception types

2023-05-23 Thread via GitHub
jonvex commented on code in PR #8638: URL: https://github.com/apache/hudi/pull/8638#discussion_r1202703409 ## hudi-common/src/main/java/org/apache/hudi/exception/HoodieMetaSyncException.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [hudi] jonvex commented on a diff in pull request #8638: added new exception types

2023-05-23 Thread via GitHub
jonvex commented on code in PR #8638: URL: https://github.com/apache/hudi/pull/8638#discussion_r1202703409 ## hudi-common/src/main/java/org/apache/hudi/exception/HoodieMetaSyncException.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [hudi] jonvex commented on a diff in pull request #8638: added new exception types

2023-05-23 Thread via GitHub
jonvex commented on code in PR #8638: URL: https://github.com/apache/hudi/pull/8638#discussion_r1202697891 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/RowBasedSchemaProvider.java: ## @@ -44,7 +45,12 @@ public RowBasedSchemaProvider(StructType rowStruct) {

[GitHub] [hudi] jonvex commented on a diff in pull request #8638: added new exception types

2023-05-23 Thread via GitHub
jonvex commented on code in PR #8638: URL: https://github.com/apache/hudi/pull/8638#discussion_r1202691156 ## hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/AvroConversionUtils.scala: ## @@ -138,18 +139,26 @@ object AvroConversionUtils { def convertStructTypeToA

[GitHub] [hudi] jonvex commented on a diff in pull request #8638: added new exception types

2023-05-15 Thread via GitHub
jonvex commented on code in PR #8638: URL: https://github.com/apache/hudi/pull/8638#discussion_r1194295333 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/exception/HoodieDeltaStreamerSchemaCompatibilityException.java: ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache