[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r973735858 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java: ## @@ -18,19 +18,22 @@ package

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r973735796 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/metrics/HoodieLockMetrics.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r968757057 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/metrics/HoodieLockMetrics.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r968757634 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/metrics/HoodieLockMetrics.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r968757057 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/metrics/HoodieLockMetrics.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r965494212 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java: ## @@ -83,6 +83,11 @@ public class HoodieMetricsConfig extends

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r965487305 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java: ## @@ -130,6 +140,13 @@ public Timer.Context getIndexCtx() { return

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r965477406 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java: ## @@ -83,6 +83,11 @@ public class HoodieMetricsConfig extends

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r965475615 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java: ## @@ -64,13 +69,18 @@ public void lock() { boolean

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r961900715 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java: ## @@ -470,8 +471,14 @@ protected void preCommit(HoodieInstant

[GitHub] [hudi] jsbali commented on a diff in pull request #6502: HUDI-4722 Added locking metrics for Hudi

jsbali commented on code in PR #6502: URL: https://github.com/apache/hudi/pull/6502#discussion_r961900521 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/metrics/HoodieLockMetrics.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache