[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-08-03 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1283870818 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/ConsistentBucketBulkInsertDataInternalWriterHelper.java: ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-08-03 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1283870066 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BucketBulkInsertDataInternalWriterHelper.java: ## @@ -65,7 +71,6 @@ public void

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-08-03 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1283867267 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/ConsistentBucketIndexBulkInsertPartitionerWithRows.java: ## @@ -0,0 +1,154 @@ +/* + *

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-08-03 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1283865112 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/SparkConsistentBucketClusteringExecutionStrategy.java: ## @@ -79,15 +94,19 @@

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-07-27 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1277121112 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/ConsistentBucketIndexUtils.java: ## @@ -270,4 +273,24 @@ private static boolean

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-07-27 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1277119817 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java: ## @@ -117,6 +119,29 @@ public static String

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-07-27 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1276987981 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/SparkConsistentBucketClusteringExecutionStrategy.java: ## @@ -79,15 +94,19 @@

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-07-27 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1276987330 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/ConsistentHashingBucketInsertPartitioner.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-07-27 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1276987211 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/util/ConsistentHashingUpdateStrategyUtils.java: ## @@ -83,7 +83,7 @@ private static

[GitHub] [hudi] leesf commented on a diff in pull request #9199: [HUDI-6534]Support consistent hashing row writer

2023-07-24 Thread via GitHub
leesf commented on code in PR #9199: URL: https://github.com/apache/hudi/pull/9199#discussion_r1273032213 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/ConsistentBucketIndexBulkInsertPartitionerWithRows.java: ## @@ -0,0 +1,154 @@ +/* + *