leesf commented on code in PR #9199:
URL: https://github.com/apache/hudi/pull/9199#discussion_r1283865112
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/SparkConsistentBucketClusteringExecutionStrategy.java:
##########
@@ -79,15 +94,19 @@ public HoodieData<WriteStatus>
performClusteringWithRecordsRDD(HoodieData<Hoodie
HoodieWriteConfig newConfig =
HoodieWriteConfig.newBuilder().withProps(props).build();
RDDConsistentBucketBulkInsertPartitioner<T> partitioner = new
RDDConsistentBucketBulkInsertPartitioner<>(getHoodieTable(), strategyParams,
preserveHoodieMetadata);
+ addHashingChildNodes(partitioner, extraMetadata);
+
+ return (HoodieData<WriteStatus>) SparkBulkInsertHelper.newInstance()
+ .bulkInsert(inputRecords, instantTime, getHoodieTable(), newConfig,
false, partitioner, true, numOutputGroups);
+ }
+
+ private void addHashingChildNodes(ConsistentHashingBucketInsertPartitioner
partitioner, Map<String, String> extraMetadata) {
try {
List<ConsistentHashingNode> nodes =
ConsistentHashingNode.fromJsonString(extraMetadata.get(BaseConsistentHashingBucketClusteringPlanStrategy.METADATA_CHILD_NODE_KEY));
Review Comment:
will the nodes be null and need check in addHashingChildrenNodes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
