[GitHub] [hudi] liujinhui1994 commented on a change in pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

Sat, 20 Feb 2021 05:58:43 -0800 


liujinhui1994 commented on a change in pull request #2443:
URL: https://github.com/apache/hudi/pull/2443#discussion_r579660766



##########
File path: 
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -58,8 +58,8 @@
 
   private final HiveSyncConfig cfg;
   private HoodieHiveClient hoodieHiveClient = null;
-  private final String snapshotTableName;
-  private final Option<String> roTableTableName;
+  private String snapshotTableName = null;
+  private Option<String> roTableTableName = null;

Review comment:
       I think it’s better to keep the original name




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to