[GitHub] [hudi] lw309637554 commented on a change in pull request #2142: [HUDI-1203] add port configuration for EmbeddedTimelineService

2020-10-05 Thread GitBox
lw309637554 commented on a change in pull request #2142: URL: https://github.com/apache/hudi/pull/2142#discussion_r499550041 ## File path: hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/TimelineService.java ## @@ -98,16 +98,42 @@ public

[GitHub] [hudi] lw309637554 commented on a change in pull request #2142: [HUDI-1203] add port configuration for EmbeddedTimelineService

2020-10-05 Thread GitBox
lw309637554 commented on a change in pull request #2142: URL: https://github.com/apache/hudi/pull/2142#discussion_r499549836 ## File path: hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/TimelineService.java ## @@ -98,16 +98,42 @@ public

[GitHub] [hudi] lw309637554 commented on a change in pull request #2142: [HUDI-1203] add port configuration for EmbeddedTimelineService

2020-10-05 Thread GitBox
lw309637554 commented on a change in pull request #2142: URL: https://github.com/apache/hudi/pull/2142#discussion_r499548663 ## File path: hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/TimelineService.java ## @@ -98,16 +98,42 @@ public

[GitHub] [hudi] lw309637554 commented on a change in pull request #2142: [HUDI-1203] add port configuration for EmbeddedTimelineService

2020-10-05 Thread GitBox
lw309637554 commented on a change in pull request #2142: URL: https://github.com/apache/hudi/pull/2142#discussion_r499545082 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java ## @@ -39,17 +39,19 @@

[GitHub] [hudi] lw309637554 commented on a change in pull request #2142: [HUDI-1203] add port configuration for EmbeddedTimelineService

2020-10-05 Thread GitBox
lw309637554 commented on a change in pull request #2142: URL: https://github.com/apache/hudi/pull/2142#discussion_r499544639 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieClient.java ## @@ -102,7 +102,8 @@ private synchronized