[GitHub] [hudi] nsivabalan commented on a diff in pull request #5462: [HUDI-3995] Making pref optimizations for bulk insert row writer path

nsivabalan commented on code in PR #5462: URL: https://github.com/apache/hudi/pull/5462#discussion_r866736485 ## hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java: ## @@ -42,7 +42,9 @@ public static final String OPERATION_METADATA_FIELD = "_hoodie_opera

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5462: [HUDI-3995] Making pref optimizations for bulk insert row writer path

nsivabalan commented on code in PR #5462: URL: https://github.com/apache/hudi/pull/5462#discussion_r861390575 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/RowKeyGeneratorHelper.java: ## @@ -234,13 +237,14 @@ public static Object getNestedFieldVal(Row row

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5462: [HUDI-3995] Making pref optimizations for bulk insert row writer path

nsivabalan commented on code in PR #5462: URL: https://github.com/apache/hudi/pull/5462#discussion_r861359728 ## hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/HoodieDatasetBulkInsertHelper.java: ## @@ -57,18 +61,18 @@ public class HoodieDatasetBulkInsertH

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5462: [HUDI-3995] Making pref optimizations for bulk insert row writer path

nsivabalan commented on code in PR #5462: URL: https://github.com/apache/hudi/pull/5462#discussion_r861359423 ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java: ## @@ -386,12 +386,14 @@ public void validateTableProperties(Properties properties