[GitHub] [hudi] nsivabalan commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-07 Thread GitBox
nsivabalan commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r965436152 ## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ## @@ -539,4 +543,19 @@ public void handle(@NotNull Context context) throws

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

2022-09-06 Thread GitBox
nsivabalan commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r964245759 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java: ## @@ -64,11 +65,16 @@ private int