prashantwason commented on a change in pull request #2026:
URL: https://github.com/apache/hudi/pull/2026#discussion_r475932300



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java
##########
@@ -147,7 +153,7 @@ public RemoteHoodieTableFileSystemView(String server, int 
port, HoodieTableMetaC
     String url = builder.toString();
     LOG.info("Sending request : (" + url + ")");
     Response response;
-    int timeout = 1000 * 300; // 5 min timeout
+    int timeout = this.timeoutSecs * 1000; // msec

Review comment:
       Yes, msec.

##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java
##########
@@ -52,7 +54,7 @@
   public static final String DEFAULT_FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE = 
"false";
   public static final String DEFUALT_REMOTE_VIEW_SERVER_HOST = "localhost";
   public static final Integer DEFAULT_REMOTE_VIEW_SERVER_PORT = 26754;
-
+  public static final Integer DEFAULT_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS = 
300 * 60; // 5 min

Review comment:
       Corrected.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to