[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r615512372 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -105,14 +117,25 @@ public static H

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r615512419 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -105,14 +117,25 @@ public static H

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r615510834 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/ReplaceArchivalHelper.java ## @@ -68,6 +68,11 @@ public static boolean d

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r615508860 ## File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java ## @@ -177,10 +161,14 @@ public HoodieTestTable addDeltaCommit(

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611792855 ## File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FileCreateUtils.java ## @@ -157,11 +157,19 @@ public static void createReplaceCommit

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611372415 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -76,15 +76,16 @@ public static Hoo

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611067880 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,10 +74,21 @@ public static Hoo

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611070455 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java ## @@ -245,7 +245,7 @@ public final void reset() {

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611068273 ## File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FileCreateUtils.java ## @@ -157,11 +157,19 @@ public static void createReplaceCommit

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611068142 ## File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java ## @@ -239,14 +227,6 @@ public HoodieTestTable addRequestedComp

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611067880 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,10 +74,21 @@ public static Hoo

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r610259030 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,9 +76,14 @@ public static Hood

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r610259030 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,9 +76,14 @@ public static Hood

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r610259030 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,9 +76,14 @@ public static Hood

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r610256593 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,9 +76,14 @@ public static Hood

[GitHub] [hudi] ssdong commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r609231425 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,9 +76,14 @@ public static Hood